Title: [207473] trunk/Source/WebInspectorUI
Revision
207473
Author
commit-qu...@webkit.org
Date
2016-10-18 11:08:16 -0700 (Tue, 18 Oct 2016)

Log Message

REGRESSION(r201171): Web Inspector: Timeline Recording playhead should always start immediately, not wait until first event
https://bugs.webkit.org/show_bug.cgi?id=163583
<rdar://problem/28815882>

Patch by Joseph Pecoraro <pecor...@apple.com> on 2016-10-18
Reviewed by Timothy Hatcher.

* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._startUpdatingCurrentTime):
Revert logic change introduced by r201171 with no explanation.
Whenever we get a start time we should use it, regardless of
of what the current time is, precisely because the backend is
informing us of the start time to use.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (207472 => 207473)


--- trunk/Source/WebInspectorUI/ChangeLog	2016-10-18 17:43:33 UTC (rev 207472)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-10-18 18:08:16 UTC (rev 207473)
@@ -1,3 +1,18 @@
+2016-10-18  Joseph Pecoraro  <pecor...@apple.com>
+
+        REGRESSION(r201171): Web Inspector: Timeline Recording playhead should always start immediately, not wait until first event
+        https://bugs.webkit.org/show_bug.cgi?id=163583
+        <rdar://problem/28815882>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/TimelineRecordingContentView.js:
+        (WebInspector.TimelineRecordingContentView.prototype._startUpdatingCurrentTime):
+        Revert logic change introduced by r201171 with no explanation.
+        Whenever we get a start time we should use it, regardless of
+        of what the current time is, precisely because the backend is
+        informing us of the start time to use.
+
 2016-10-17  Joseph Pecoraro  <pecor...@apple.com>
 
         Web Inspector: Add toggles for debugger pauses at console.assert failures

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (207472 => 207473)


--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js	2016-10-18 17:43:33 UTC (rev 207472)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js	2016-10-18 18:08:16 UTC (rev 207473)
@@ -439,9 +439,9 @@
         if (!WebInspector.visible)
             return;
 
-        if (typeof startTime === "number" && !isNaN(this._currentTime))
+        if (typeof startTime === "number")
             this._currentTime = startTime;
-        else {
+        else if (!isNaN(this._currentTime)) {
             // This happens when you stop and later restart recording.
             // COMPATIBILITY (iOS 9): Timeline.recordingStarted events did not include a timestamp.
             // We likely need to jump into the future to a better current time which we can
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to