Title: [207488] trunk/Source/WebCore
Revision
207488
Author
commit-qu...@webkit.org
Date
2016-10-18 14:03:03 -0700 (Tue, 18 Oct 2016)

Log Message

Modern media controls don't update their rendering correctly
https://bugs.webkit.org/show_bug.cgi?id=163603
<rdar://problem/28826022>

Patch by Antoine Quint <grao...@apple.com> on 2016-10-18
Reviewed by Dean Jackson.

There are rendering issues when we use an absolutely-positioned element
as the top-most element in a media element's shadow root (webkit.org/b/163592).
Since we only need for that element to be positioned, we can use "position: relative"
instead, which removes the rendering issues.

* Modules/modern-media-controls/controls/media-controls.css:
(.media-controls):
(.media-controls,): Deleted.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (207487 => 207488)


--- trunk/Source/WebCore/ChangeLog	2016-10-18 20:55:49 UTC (rev 207487)
+++ trunk/Source/WebCore/ChangeLog	2016-10-18 21:03:03 UTC (rev 207488)
@@ -1,3 +1,20 @@
+2016-10-18  Antoine Quint  <grao...@apple.com>
+
+        Modern media controls don't update their rendering correctly
+        https://bugs.webkit.org/show_bug.cgi?id=163603
+        <rdar://problem/28826022>
+
+        Reviewed by Dean Jackson.
+
+        There are rendering issues when we use an absolutely-positioned element
+        as the top-most element in a media element's shadow root (webkit.org/b/163592).
+        Since we only need for that element to be positioned, we can use "position: relative"
+        instead, which removes the rendering issues.
+
+        * Modules/modern-media-controls/controls/media-controls.css:
+        (.media-controls):
+        (.media-controls,): Deleted.
+
 2016-10-18  Dean Jackson  <d...@apple.com>
 
         Add preliminary support for extended colors to WebCore::Color

Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css (207487 => 207488)


--- trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css	2016-10-18 20:55:49 UTC (rev 207487)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css	2016-10-18 21:03:03 UTC (rev 207488)
@@ -23,7 +23,11 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-.media-controls,
+/* We need to use relative positioning due to webkit.org/b/163603 */
+.media-controls {
+    position: relative;
+}
+
 .media-controls > .controls-bar {
     position: absolute;
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to