Title: [207496] trunk/Source/WebCore
Revision
207496
Author
commit-qu...@webkit.org
Date
2016-10-18 16:04:13 -0700 (Tue, 18 Oct 2016)

Log Message

Web Inspector: AXI: focused/focusable state should be based on Accessibility Object instead of Element
https://bugs.webkit.org/show_bug.cgi?id=163088
<rdar://problem/16421985>

Patch by Aaron Chu <aaron_...@apple.com> on 2016-10-18
Reviewed by Darin Adler.

Changed code in InspectDOMAgent so that it determines the focusability of a Node based
on the AccessibilityNodeObject and not the Element class.

Covered by existing tests:
LayoutTests/inspector/dom/getAccessibilityPropertiesForNode.html

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (207495 => 207496)


--- trunk/Source/WebCore/ChangeLog	2016-10-18 22:57:34 UTC (rev 207495)
+++ trunk/Source/WebCore/ChangeLog	2016-10-18 23:04:13 UTC (rev 207496)
@@ -1,3 +1,20 @@
+2016-10-18  Aaron Chu  <aaron_...@apple.com>
+
+        Web Inspector: AXI: focused/focusable state should be based on Accessibility Object instead of Element
+        https://bugs.webkit.org/show_bug.cgi?id=163088
+        <rdar://problem/16421985>
+
+        Reviewed by Darin Adler.
+
+        Changed code in InspectDOMAgent so that it determines the focusability of a Node based
+        on the AccessibilityNodeObject and not the Element class.
+
+        Covered by existing tests: 
+        LayoutTests/inspector/dom/getAccessibilityPropertiesForNode.html
+
+        * inspector/InspectorDOMAgent.cpp:
+        (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
+
 2016-10-18  Anders Carlsson  <ander...@apple.com>
 
         Get rid of more WebHistoryItem cruft

Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (207495 => 207496)


--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp	2016-10-18 22:57:34 UTC (rev 207495)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp	2016-10-18 23:04:13 UTC (rev 207496)
@@ -1675,7 +1675,7 @@
             }
             
             if (is<Element>(*node)) {
-                supportsFocused = downcast<Element>(*node).isFocusable();
+                supportsFocused = axObject->canSetFocusAttribute();
                 if (supportsFocused)
                     focused = axObject->isFocused();
             }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to