Log Message
Move HTML Interactive Form Validation behind an experimental flag https://bugs.webkit.org/show_bug.cgi?id=163673
Reviewed by Daniel Bates. Source/WebKit/mac: Re-disable HTML Interactive Form Validation by default on Mac WK1. * WebView/WebViewData.mm: (-[WebViewPrivate init]): Source/WebKit2: Move HTML Interactive Form Validation behind an experimental feature flag and disable by default until by have a better UI. * Shared/WebPreferencesDefinitions.h: * WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (207561 => 207562)
--- trunk/Source/WebKit/mac/ChangeLog 2016-10-19 20:10:40 UTC (rev 207561)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-10-19 20:29:02 UTC (rev 207562)
@@ -1,3 +1,15 @@
+2016-10-19 Chris Dumez <cdu...@apple.com>
+
+ Move HTML Interactive Form Validation behind an experimental flag
+ https://bugs.webkit.org/show_bug.cgi?id=163673
+
+ Reviewed by Daniel Bates.
+
+ Re-disable HTML Interactive Form Validation by default on Mac WK1.
+
+ * WebView/WebViewData.mm:
+ (-[WebViewPrivate init]):
+
2016-10-19 Myles C. Maxfield <mmaxfi...@apple.com>
[macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
Modified: trunk/Source/WebKit/mac/WebView/WebViewData.mm (207561 => 207562)
--- trunk/Source/WebKit/mac/WebView/WebViewData.mm 2016-10-19 20:10:40 UTC (rev 207561)
+++ trunk/Source/WebKit/mac/WebView/WebViewData.mm 2016-10-19 20:29:02 UTC (rev 207562)
@@ -143,7 +143,7 @@
zoomMultiplier = 1;
zoomsTextOnly = NO;
- interactiveFormValidationEnabled = YES;
+ interactiveFormValidationEnabled = NO;
// The default value should be synchronized with WebCore/page/Settings.cpp.
validationMessageTimerMagnification = 50;
Modified: trunk/Source/WebKit2/ChangeLog (207561 => 207562)
--- trunk/Source/WebKit2/ChangeLog 2016-10-19 20:10:40 UTC (rev 207561)
+++ trunk/Source/WebKit2/ChangeLog 2016-10-19 20:29:02 UTC (rev 207562)
@@ -1,3 +1,17 @@
+2016-10-19 Chris Dumez <cdu...@apple.com>
+
+ Move HTML Interactive Form Validation behind an experimental flag
+ https://bugs.webkit.org/show_bug.cgi?id=163673
+
+ Reviewed by Daniel Bates.
+
+ Move HTML Interactive Form Validation behind an experimental feature flag
+ and disable by default until by have a better UI.
+
+ * Shared/WebPreferencesDefinitions.h:
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+
2016-10-19 Damian Kaleta <dkal...@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=163292
Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (207561 => 207562)
--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-10-19 20:10:40 UTC (rev 207561)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-10-19 20:29:02 UTC (rev 207562)
@@ -179,7 +179,6 @@
macro(AsynchronousPluginInitializationEnabledForAllPlugins, asynchronousPluginInitializationEnabledForAllPlugins, Bool, bool, false, "", "") \
macro(ArtificialPluginInitializationDelayEnabled, artificialPluginInitializationDelayEnabled, Bool, bool, false, "", "") \
macro(TabToLinksEnabled, tabToLinksEnabled, Bool, bool, false, "", "") \
- macro(InteractiveFormValidationEnabled, interactiveFormValidationEnabled, Bool, bool, true, "", "") \
macro(ScrollingPerformanceLoggingEnabled, scrollingPerformanceLoggingEnabled, Bool, bool, false, "", "") \
macro(ScrollAnimatorEnabled, scrollAnimatorEnabled, Bool, bool, DEFAULT_WEBKIT_SCROLL_ANIMATOR_ENABLED, "", "") \
macro(ForceUpdateScrollbarsOnMainThreadForPerformanceTesting, forceUpdateScrollbarsOnMainThreadForPerformanceTesting, Bool, bool, false, "", "") \
@@ -290,6 +289,7 @@
macro(CSSGridLayoutEnabled, cssGridLayoutEnabled, Bool, bool, false, "CSS Grid", "CSS Grid Layout Module support") \
macro(SpringTimingFunctionEnabled, springTimingFunctionEnabled, Bool, bool, true, "CSS Spring Animations", "CSS Spring Animation prototype") \
macro(CustomElementsEnabled, customElementsEnabled, Bool, bool, true, "Custom Elements", "HTML Custom Elements prototype") \
+ macro(InteractiveFormValidationEnabled, interactiveFormValidationEnabled, Bool, bool, false, "HTML Interactive Form Validation", "HTML interactive form validation prototype") \
macro(GamepadsEnabled, gamepadsEnabled, Bool, bool, true, "Gamepads", "Web Gamepad API support") \
macro(ModernMediaControlsEnabled, modernMediaControlsEnabled, Bool, bool, false, "Modern Media Controls", "Use modern media controls look") \
macro(VariationFontsEnabled, variationFontsEnabled, Bool, bool, true, "Variation Fonts", "Enable variation fonts") \
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (207561 => 207562)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2016-10-19 20:10:40 UTC (rev 207561)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2016-10-19 20:29:02 UTC (rev 207562)
@@ -207,6 +207,9 @@
RuntimeEnabledFeatures::sharedFeatures().setCustomElementsEnabled(enabled);
#endif
+ if (preference == "WebKitInteractiveFormValidationEnabled")
+ RuntimeEnabledFeatures::sharedFeatures().setInteractiveFormValidationEnabled(enabled);
+
#if ENABLE(WEBGL2)
if (preference == "WebKitWebGL2Enabled")
RuntimeEnabledFeatures::sharedFeatures().setWebGL2Enabled(enabled);
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
