Title: [207571] trunk
Revision
207571
Author
rn...@webkit.org
Date
2016-10-19 15:06:47 -0700 (Wed, 19 Oct 2016)

Log Message

Annotate more DOM and HTML IDLs with CEReactions
https://bugs.webkit.org/show_bug.cgi?id=163653

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaselined the tests now that more test cases are passing.

* web-platform-tests/custom-elements/attribute-changed-callback-expected.txt:
* web-platform-tests/custom-elements/reactions/DOMStringMap-expected.txt:
* web-platform-tests/custom-elements/reactions/Document-expected.txt:
* web-platform-tests/custom-elements/reactions/Element-expected.txt:
* web-platform-tests/custom-elements/reactions/ElementContentEditable-expected.txt:
* web-platform-tests/custom-elements/reactions/HTMLElement-expected.txt:
* web-platform-tests/custom-elements/reactions/Selection-expected.txt:

Source/WebCore:

Added CEReactions to more IDL files.

Test: fast/custom-elements/reactions-for-webkit-extensions.html

* bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::deleteProperty): Instantiate CustomElementReactionStack, which is equivalent to
adding CEReactions in IDL.
(WebCore::JSDOMStringMap::putDelegate): Ditto.
* dom/Document.idl:
* dom/Element.idl:
* html/HTMLElement.idl:
* page/DOMSelection.idl:

LayoutTests:

Added a regression test to make sure webkitdropzone IDL attribute on HTMLElement
honors CEReactions semantics using the web-platform-tests' infrastructure I added.

* fast/custom-elements/reactions-for-webkit-extensions-expected.txt: Added.
* fast/custom-elements/reactions-for-webkit-extensions.html: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (207570 => 207571)


--- trunk/LayoutTests/ChangeLog	2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/ChangeLog	2016-10-19 22:06:47 UTC (rev 207571)
@@ -1,3 +1,16 @@
+2016-10-19  Ryosuke Niwa  <rn...@webkit.org>
+
+        Annotate more DOM and HTML IDLs with CEReactions
+        https://bugs.webkit.org/show_bug.cgi?id=163653
+
+        Reviewed by Darin Adler.
+
+        Added a regression test to make sure webkitdropzone IDL attribute on HTMLElement
+        honors CEReactions semantics using the web-platform-tests' infrastructure I added.
+
+        * fast/custom-elements/reactions-for-webkit-extensions-expected.txt: Added.
+        * fast/custom-elements/reactions-for-webkit-extensions.html: Added.
+
 2016-10-19  Ryan Haddad  <ryanhad...@apple.com>
 
         Unreviewed, rolling out r207557.

Added: trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions-expected.txt (0 => 207571)


--- trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions-expected.txt	2016-10-19 22:06:47 UTC (rev 207571)
@@ -0,0 +1,4 @@
+
+PASS dropzone on HTMLElement must enqueue an attributeChanged reaction when adding webkitdropzone content attribute 
+PASS dropzone on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute 
+

Added: trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions.html (0 => 207571)


--- trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions.html	                        (rev 0)
+++ trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions.html	2016-10-19 22:06:47 UTC (rev 207571)
@@ -0,0 +1,21 @@
+<!DOCTYPE html>
+<html>
+<head>
+<title>Custom Elements: CEReactions on Attr interface</title>
+<meta name="author" title="Ryosuke Niwa" href=""
+<meta name="assert" content="value of Attr interface must have CEReactions">
+<meta name="help" content="https://dom.spec.whatwg.org/#node">
+<script src=""
+<script src=""
+<script src=""
+<script src=""
+</head>
+<body>
+<div id="log"></div>
+<script>
+
+testReflectAttribute('webkitdropzone', 'webkitdropzone', 'copy', 'move', 'dropzone on HTMLElement');
+
+</script>
+</body>
+</html>

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (207570 => 207571)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-10-19 22:06:47 UTC (rev 207571)
@@ -1,3 +1,20 @@
+2016-10-19  Ryosuke Niwa  <rn...@webkit.org>
+
+        Annotate more DOM and HTML IDLs with CEReactions
+        https://bugs.webkit.org/show_bug.cgi?id=163653
+
+        Reviewed by Darin Adler.
+
+        Rebaselined the tests now that more test cases are passing.
+
+        * web-platform-tests/custom-elements/attribute-changed-callback-expected.txt:
+        * web-platform-tests/custom-elements/reactions/DOMStringMap-expected.txt:
+        * web-platform-tests/custom-elements/reactions/Document-expected.txt:
+        * web-platform-tests/custom-elements/reactions/Element-expected.txt:
+        * web-platform-tests/custom-elements/reactions/ElementContentEditable-expected.txt:
+        * web-platform-tests/custom-elements/reactions/HTMLElement-expected.txt:
+        * web-platform-tests/custom-elements/reactions/Selection-expected.txt:
+
 2016-10-19  Alex Christensen  <achristen...@webkit.org>
 
         Import encoding web-platform-tests

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/attribute-changed-callback-expected.txt (207570 => 207571)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/attribute-changed-callback-expected.txt	2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/attribute-changed-callback-expected.txt	2016-10-19 22:06:47 UTC (rev 207571)
@@ -8,5 +8,5 @@
 PASS Mutating observedAttributes after calling customElements.define must not affect the set of attributes for which attributedChangedCallback is invoked 
 PASS attributedChangedCallback must be enqueued for attributes specified in a non-Array iterable observedAttributes 
 FAIL attributedChangedCallback must be enqueued for style attribute change by mutating inline style declaration assert_equals: expected 1 but got 0
-FAIL attributedChangedCallback must not be enqueued when mutating inline style declaration if the style attribute is not observed undefined is not an object (evaluating 'log.type')
+PASS attributedChangedCallback must not be enqueued when mutating inline style declaration if the style attribute is not observed 
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/DOMStringMap-expected.txt (207570 => 207571)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/DOMStringMap-expected.txt	2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/DOMStringMap-expected.txt	2016-10-19 22:06:47 UTC (rev 207571)
@@ -1,10 +1,10 @@
 
-FAIL setter on DOMStringMap must enqueue an attributeChanged reaction when adding an observed data attribute assert_array_equals: lengths differ, expected 1 got 0
+PASS setter on DOMStringMap must enqueue an attributeChanged reaction when adding an observed data attribute 
 PASS setter on DOMStringMap must not enqueue an attributeChanged reaction when adding an unobserved data attribute 
-FAIL setter on DOMStringMap must enqueue an attributeChanged reaction when mutating the value of an observed data attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL setter on DOMStringMap must enqueue an attributeChanged reaction when mutating the value of an observed data attribute to the same value assert_array_equals: lengths differ, expected 2 got 1
+PASS setter on DOMStringMap must enqueue an attributeChanged reaction when mutating the value of an observed data attribute 
+PASS setter on DOMStringMap must enqueue an attributeChanged reaction when mutating the value of an observed data attribute to the same value 
 PASS setter on DOMStringMap must not enqueue an attributeChanged reaction when mutating the value of an unobserved data attribute 
-FAIL deleter on DOMStringMap must enqueue an attributeChanged reaction when removing an observed data attribute assert_array_equals: lengths differ, expected 2 got 1
+PASS deleter on DOMStringMap must enqueue an attributeChanged reaction when removing an observed data attribute 
 PASS deleter on DOMStringMap must not enqueue an attributeChanged reaction when removing an unobserved data attribute 
 PASS deleter on DOMStringMap must not enqueue an attributeChanged reaction when it does not remove a data attribute 
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Document-expected.txt (207570 => 207571)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Document-expected.txt	2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Document-expected.txt	2016-10-19 22:06:47 UTC (rev 207571)
@@ -1,5 +1,5 @@
 
 FAIL importNode on Document must construct a new custom element when importing a custom element assert_array_equals: lengths differ, expected 1 got 0
 PASS adoptNode on Document must enqueue an adopted reaction when importing a custom element 
-FAIL execCommand on Document must enqueue a disconnected reaction when deleting a custom element from a contenteditable element assert_array_equals: lengths differ, expected 1 got 0
+PASS execCommand on Document must enqueue a disconnected reaction when deleting a custom element from a contenteditable element 
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Element-expected.txt (207570 => 207571)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Element-expected.txt	2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Element-expected.txt	2016-10-19 22:06:47 UTC (rev 207571)
@@ -32,12 +32,12 @@
 PASS removeAttributeNode on Element must not enqueue an attributeChanged reaction when removing an existing unobserved attribute 
 PASS insertAdjacentElement on Element must enqueue a connected reaction 
 PASS insertAdjacentElement on Element must enqueue a disconnected reaction, an adopted reaction, and a connected reaction when the custom element was in another document 
-FAIL innerHTML on Element must enqueue a connected reaction for a newly constructed custom element assert_array_equals: lengths differ, expected 2 got 1
-FAIL innerHTML on Element must enqueue a attributeChanged reaction for a newly constructed custom element assert_array_equals: lengths differ, expected 3 got 1
-FAIL innerHTML on Element must enqueue a disconnected reaction assert_array_equals: lengths differ, expected 1 got 0
-FAIL outerHTML on Element must enqueue a connected reaction for a newly constructed custom element assert_array_equals: lengths differ, expected 2 got 1
-FAIL outerHTML on Element must enqueue a attributeChanged reaction for a newly constructed custom element assert_array_equals: lengths differ, expected 3 got 1
-FAIL outerHTML on Element must enqueue a disconnected reaction assert_array_equals: lengths differ, expected 1 got 0
-FAIL insertAdjacentHTML on Element must enqueue a connected reaction for a newly constructed custom element assert_array_equals: lengths differ, expected 2 got 1
-FAIL insertAdjacentHTML on Element must enqueue a attributeChanged reaction for a newly constructed custom element assert_array_equals: lengths differ, expected 3 got 1
+PASS innerHTML on Element must enqueue a connected reaction for a newly constructed custom element 
+PASS innerHTML on Element must enqueue a attributeChanged reaction for a newly constructed custom element 
+PASS innerHTML on Element must enqueue a disconnected reaction 
+PASS outerHTML on Element must enqueue a connected reaction for a newly constructed custom element 
+PASS outerHTML on Element must enqueue a attributeChanged reaction for a newly constructed custom element 
+PASS outerHTML on Element must enqueue a disconnected reaction 
+PASS insertAdjacentHTML on Element must enqueue a connected reaction for a newly constructed custom element 
+PASS insertAdjacentHTML on Element must enqueue a attributeChanged reaction for a newly constructed custom element 
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/ElementContentEditable-expected.txt (207570 => 207571)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/ElementContentEditable-expected.txt	2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/ElementContentEditable-expected.txt	2016-10-19 22:06:47 UTC (rev 207571)
@@ -1,4 +1,4 @@
 
-FAIL contentEditable on ElementContentEditable must enqueue an attributeChanged reaction when adding contenteditable content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL contentEditable on ElementContentEditable must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
+PASS contentEditable on ElementContentEditable must enqueue an attributeChanged reaction when adding contenteditable content attribute 
+PASS contentEditable on ElementContentEditable must enqueue an attributeChanged reaction when replacing an existing attribute 
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement-expected.txt (207570 => 207571)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement-expected.txt	2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement-expected.txt	2016-10-19 22:06:47 UTC (rev 207571)
@@ -1,26 +1,26 @@
 
-FAIL title on HTMLElement must enqueue an attributeChanged reaction when adding title content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL title on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL lang on HTMLElement must enqueue an attributeChanged reaction when adding lang content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL lang on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL translate on HTMLElement must enqueue an attributeChanged reaction when adding translate content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL translate on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL dir on HTMLElement must enqueue an attributeChanged reaction when adding dir content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL dir on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL hidden on HTMLElement must enqueue an attributeChanged reaction when adding hidden content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL hidden on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL tabIndex on HTMLElement must enqueue an attributeChanged reaction when adding tabindex content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL tabIndex on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL accessKey on HTMLElement must enqueue an attributeChanged reaction when adding accesskey content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL accessKey on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL draggable on HTMLElement must enqueue an attributeChanged reaction when adding draggable content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL draggable on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
+PASS title on HTMLElement must enqueue an attributeChanged reaction when adding title content attribute 
+PASS title on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute 
+PASS lang on HTMLElement must enqueue an attributeChanged reaction when adding lang content attribute 
+PASS lang on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute 
+PASS translate on HTMLElement must enqueue an attributeChanged reaction when adding translate content attribute 
+PASS translate on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute 
+PASS dir on HTMLElement must enqueue an attributeChanged reaction when adding dir content attribute 
+PASS dir on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute 
+PASS hidden on HTMLElement must enqueue an attributeChanged reaction when adding hidden content attribute 
+PASS hidden on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute 
+PASS tabIndex on HTMLElement must enqueue an attributeChanged reaction when adding tabindex content attribute 
+PASS tabIndex on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute 
+PASS accessKey on HTMLElement must enqueue an attributeChanged reaction when adding accesskey content attribute 
+PASS accessKey on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute 
+PASS draggable on HTMLElement must enqueue an attributeChanged reaction when adding draggable content attribute 
+PASS draggable on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute 
 FAIL dropzone on HTMLElement must enqueue an attributeChanged reaction when adding dropzone content attribute assert_array_equals: lengths differ, expected 1 got 0
 FAIL dropzone on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
 FAIL contextMenu on HTMLElement must enqueue an attributeChanged reaction when adding contextmenu content attribute assert_array_equals: lengths differ, expected 1 got 0
 FAIL contextMenu on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL spellcheck on HTMLElement must enqueue an attributeChanged reaction when adding spellcheck content attribute assert_array_equals: lengths differ, expected 1 got 0
-FAIL spellcheck on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
-FAIL innerText on HTMLElement must enqueue a disconnected reaction assert_array_equals: lengths differ, expected 1 got 0
-FAIL outerText on HTMLElement must enqueue a disconnected reaction assert_array_equals: lengths differ, expected 1 got 0
+PASS spellcheck on HTMLElement must enqueue an attributeChanged reaction when adding spellcheck content attribute 
+PASS spellcheck on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute 
+PASS innerText on HTMLElement must enqueue a disconnected reaction 
+PASS outerText on HTMLElement must enqueue a disconnected reaction 
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Selection-expected.txt (207570 => 207571)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Selection-expected.txt	2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Selection-expected.txt	2016-10-19 22:06:47 UTC (rev 207571)
@@ -1,3 +1,3 @@
 
-FAIL deleteFromDocument on Selection must enqueue a disconnected reaction assert_array_equals: lengths differ, expected 1 got 0
+PASS deleteFromDocument on Selection must enqueue a disconnected reaction 
 

Modified: trunk/Source/WebCore/ChangeLog (207570 => 207571)


--- trunk/Source/WebCore/ChangeLog	2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/Source/WebCore/ChangeLog	2016-10-19 22:06:47 UTC (rev 207571)
@@ -1,3 +1,23 @@
+2016-10-19  Ryosuke Niwa  <rn...@webkit.org>
+
+        Annotate more DOM and HTML IDLs with CEReactions
+        https://bugs.webkit.org/show_bug.cgi?id=163653
+
+        Reviewed by Darin Adler.
+
+        Added CEReactions to more IDL files.
+
+        Test: fast/custom-elements/reactions-for-webkit-extensions.html
+
+        * bindings/js/JSDOMStringMapCustom.cpp:
+        (WebCore::JSDOMStringMap::deleteProperty): Instantiate CustomElementReactionStack, which is equivalent to
+        adding CEReactions in IDL.
+        (WebCore::JSDOMStringMap::putDelegate): Ditto.
+        * dom/Document.idl:
+        * dom/Element.idl:
+        * html/HTMLElement.idl:
+        * page/DOMSelection.idl:
+
 2016-10-19  Ryan Haddad  <ryanhad...@apple.com>
 
         Unreviewed, rolling out r207557.

Modified: trunk/Source/WebCore/bindings/js/JSDOMStringMapCustom.cpp (207570 => 207571)


--- trunk/Source/WebCore/bindings/js/JSDOMStringMapCustom.cpp	2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/Source/WebCore/bindings/js/JSDOMStringMapCustom.cpp	2016-10-19 22:06:47 UTC (rev 207571)
@@ -26,6 +26,7 @@
 #include "config.h"
 #include "JSDOMStringMap.h"
 
+#include "CustomElementReactionQueue.h"
 #include "DOMStringMap.h"
 #include "JSNode.h"
 #include <runtime/IdentifierInlines.h>
@@ -62,6 +63,10 @@
 
 bool JSDOMStringMap::deleteProperty(JSCell* cell, ExecState* exec, PropertyName propertyName)
 {
+#if ENABLE(CUSTOM_ELEMENTS)
+    CustomElementReactionStack customElementReactionStack;
+#endif
+
     JSDOMStringMap* thisObject = jsCast<JSDOMStringMap*>(cell);
     if (propertyName.isSymbol())
         return Base::deleteProperty(thisObject, exec, propertyName);
@@ -81,6 +86,10 @@
     if (propertyName.isSymbol())
         return false;
 
+#if ENABLE(CUSTOM_ELEMENTS)
+    CustomElementReactionStack customElementReactionStack;
+#endif
+
     String stringValue = value.toString(exec)->value(exec);
     RETURN_IF_EXCEPTION(scope, false);
 

Modified: trunk/Source/WebCore/dom/Document.idl (207570 => 207571)


--- trunk/Source/WebCore/dom/Document.idl	2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/Source/WebCore/dom/Document.idl	2016-10-19 22:06:47 UTC (rev 207571)
@@ -83,7 +83,7 @@
     [MayThrowException] XPathResult evaluate(optional DOMString _expression_ = "undefined", optional Node? contextNode, optional XPathNSResolver? resolver, optional unsigned short type = 0, optional XPathResult? inResult);
 
     // FIXME: The default value for the last parameter should be the empty string.
-    boolean execCommand(DOMString command, optional boolean userInterface = false, optional DOMString? value = null);
+    [CEReactions] boolean execCommand(DOMString command, optional boolean userInterface = false, optional DOMString? value = null);
 
     boolean queryCommandEnabled(DOMString command);
     boolean queryCommandIndeterm(DOMString command);

Modified: trunk/Source/WebCore/dom/Element.idl (207570 => 207571)


--- trunk/Source/WebCore/dom/Element.idl	2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/Source/WebCore/dom/Element.idl	2016-10-19 22:06:47 UTC (rev 207571)
@@ -97,8 +97,8 @@
     sequence<DOMString> getAttributeNames();
 
     HTMLCollection getElementsByClassName(DOMString name);
-    [TreatNullAs=EmptyString, SetterMayThrowLegacyException] attribute DOMString innerHTML;
-    [TreatNullAs=EmptyString, SetterMayThrowLegacyException] attribute DOMString outerHTML;
+    [CEReactions, TreatNullAs=EmptyString, SetterMayThrowLegacyException] attribute DOMString innerHTML;
+    [CEReactions, TreatNullAs=EmptyString, SetterMayThrowLegacyException] attribute DOMString outerHTML;
 
     [CEReactions, Reflect=class] attribute DOMString className;
     [PutForwards=value] readonly attribute DOMTokenList classList;
@@ -125,7 +125,7 @@
 #endif
 
     [CEReactions, MayThrowLegacyException] Element insertAdjacentElement(DOMString where, Element element);
-    [MayThrowLegacyException] void insertAdjacentHTML(DOMString where, DOMString html);
+    [CEReactions, MayThrowLegacyException] void insertAdjacentHTML(DOMString where, DOMString html);
     [MayThrowLegacyException] void insertAdjacentText(DOMString where, DOMString text);
 
     [Conditional=POINTER_LOCK] void requestPointerLock();

Modified: trunk/Source/WebCore/html/HTMLElement.idl (207570 => 207571)


--- trunk/Source/WebCore/html/HTMLElement.idl	2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/Source/WebCore/html/HTMLElement.idl	2016-10-19 22:06:47 UTC (rev 207571)
@@ -26,28 +26,28 @@
     JSCustomPushEventHandlerScope,
     ExportMacro=WEBCORE_EXPORT,
 ] interface HTMLElement : Element {
-    [Reflect] attribute DOMString title;
-    [Reflect] attribute DOMString lang;
-    attribute boolean translate;
-    attribute DOMString dir;
+    [CEReactions, Reflect] attribute DOMString title;
+    [CEReactions, Reflect] attribute DOMString lang;
+    [CEReactions] attribute boolean translate;
+    [CEReactions] attribute DOMString dir;
 
-    attribute long tabIndex;
-    attribute boolean draggable;
+    [CEReactions] attribute long tabIndex;
+    [CEReactions] attribute boolean draggable;
 
-    [Reflect] attribute DOMString webkitdropzone;
+    [CEReactions, Reflect] attribute DOMString webkitdropzone;
     // FIXME: Support the standard HTML equivalent.
     // [PutForwards=value] readonly attribute DOMTokenList dropzone;
 
-    [Reflect] attribute boolean hidden;
-    [Reflect] attribute DOMString accessKey;
+    [CEReactions, Reflect] attribute boolean hidden;
+    [CEReactions, Reflect] attribute DOMString accessKey;
 
-    [TreatNullAs=EmptyString, SetterMayThrowLegacyException] attribute DOMString innerText;
-    [TreatNullAs=EmptyString, SetterMayThrowLegacyException] attribute DOMString outerText;
+    [CEReactions, SetterMayThrowLegacyException, TreatNullAs=EmptyString] attribute DOMString innerText;
+    [CEReactions, SetterMayThrowLegacyException, TreatNullAs=EmptyString] attribute DOMString outerText;
 
-    [SetterMayThrowLegacyException] attribute DOMString contentEditable;
+    [CEReactions, SetterMayThrowLegacyException] attribute DOMString contentEditable;
     readonly attribute boolean isContentEditable;
 
-    attribute boolean spellcheck;
+    [CEReactions] attribute boolean spellcheck;
 
     void click();
 

Modified: trunk/Source/WebCore/page/DOMSelection.idl (207570 => 207571)


--- trunk/Source/WebCore/page/DOMSelection.idl	2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/Source/WebCore/page/DOMSelection.idl	2016-10-19 22:06:47 UTC (rev 207571)
@@ -44,7 +44,7 @@
     [MayThrowException] void collapseToEnd();
     [MayThrowException] void collapseToStart();
 
-    void deleteFromDocument();
+    [CEReactions] void deleteFromDocument();
     boolean containsNode(Node node, optional boolean allowPartial = false);
     void selectAllChildren(Node node);
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to