Diff
Modified: trunk/Source/WebKit2/ChangeLog (98645 => 98646)
--- trunk/Source/WebKit2/ChangeLog 2011-10-27 22:05:17 UTC (rev 98645)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-27 22:07:32 UTC (rev 98646)
@@ -1,3 +1,27 @@
+2011-10-27 Anders Carlsson <[email protected]>
+
+ Rename Plugin::geometryDidChange to Plugin::deprecatedGeometryDidChange
+ https://bugs.webkit.org/show_bug.cgi?id=71065
+
+ Reviewed by Simon Fraser.
+
+ In preparation for adding a version of geometryDidChange that doesn't take window coordinates.
+
+ * PluginProcess/PluginControllerProxy.cpp:
+ (WebKit::PluginControllerProxy::geometryDidChange):
+ * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+ (WebKit::NetscapePlugin::deprecatedGeometryDidChange):
+ * WebProcess/Plugins/Netscape/NetscapePlugin.h:
+ * WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
+ (WebKit::BuiltInPDFView::deprecatedGeometryDidChange):
+ * WebProcess/Plugins/PDF/BuiltInPDFView.h:
+ * WebProcess/Plugins/Plugin.h:
+ * WebProcess/Plugins/PluginProxy.cpp:
+ (WebKit::PluginProxy::deprecatedGeometryDidChange):
+ * WebProcess/Plugins/PluginProxy.h:
+ * WebProcess/Plugins/PluginView.cpp:
+ (WebKit::PluginView::viewGeometryDidChange):
+
2011-10-27 Michael Saboff <[email protected]>
Investigate storing strings in 8-bit buffers when possible
Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp (98645 => 98646)
--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2011-10-27 22:05:17 UTC (rev 98645)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2011-10-27 22:07:32 UTC (rev 98646)
@@ -452,7 +452,7 @@
m_backingStore = ShareableBitmap::create(backingStoreHandle);
}
- m_plugin->geometryDidChange(frameRect, clipRect);
+ m_plugin->deprecatedGeometryDidChange(frameRect, clipRect);
}
void PluginControllerProxy::didEvaluateJavaScript(uint64_t requestID, const String& result)
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp (98645 => 98646)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2011-10-27 22:05:17 UTC (rev 98645)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2011-10-27 22:07:32 UTC (rev 98646)
@@ -660,7 +660,7 @@
return m_isTransparent;
}
-void NetscapePlugin::geometryDidChange(const IntRect& frameRect, const IntRect& clipRect)
+void NetscapePlugin::deprecatedGeometryDidChange(const IntRect& frameRect, const IntRect& clipRect)
{
ASSERT(m_isStarted);
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h (98645 => 98646)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h 2011-10-27 22:05:17 UTC (rev 98645)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h 2011-10-27 22:07:32 UTC (rev 98646)
@@ -168,7 +168,7 @@
virtual PlatformLayer* pluginLayer();
#endif
virtual bool isTransparent();
- virtual void geometryDidChange(const WebCore::IntRect& frameRect, const WebCore::IntRect& clipRect);
+ virtual void deprecatedGeometryDidChange(const WebCore::IntRect& frameRect, const WebCore::IntRect& clipRect);
virtual void visibilityDidChange();
virtual void frameDidFinishLoading(uint64_t requestID);
virtual void frameDidFail(uint64_t requestID, bool wasCancelled);
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp (98645 => 98646)
--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp 2011-10-27 22:05:17 UTC (rev 98645)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp 2011-10-27 22:07:32 UTC (rev 98646)
@@ -367,7 +367,7 @@
return false;
}
-void BuiltInPDFView::geometryDidChange(const IntRect& frameRect, const IntRect& clipRect)
+void BuiltInPDFView::deprecatedGeometryDidChange(const IntRect& frameRect, const IntRect& clipRect)
{
if (m_frameRect == frameRect) {
// Nothing to do.
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h (98645 => 98646)
--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h 2011-10-27 22:05:17 UTC (rev 98645)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h 2011-10-27 22:07:32 UTC (rev 98646)
@@ -77,7 +77,7 @@
virtual PlatformLayer* pluginLayer();
#endif
virtual bool isTransparent();
- virtual void geometryDidChange(const WebCore::IntRect& frameRect, const WebCore::IntRect& clipRect);
+ virtual void deprecatedGeometryDidChange(const WebCore::IntRect& frameRect, const WebCore::IntRect& clipRect);
virtual void visibilityDidChange();
virtual void frameDidFinishLoading(uint64_t requestID);
virtual void frameDidFail(uint64_t requestID, bool wasCancelled);
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h (98645 => 98646)
--- trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h 2011-10-27 22:05:17 UTC (rev 98645)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h 2011-10-27 22:07:32 UTC (rev 98646)
@@ -116,7 +116,7 @@
virtual bool isTransparent() = 0;
// Tells the plug-in that either the plug-ins frame rect or its clip rect has changed. Both rects are in window coordinates.
- virtual void geometryDidChange(const WebCore::IntRect& frameRect, const WebCore::IntRect& clipRect) = 0;
+ virtual void deprecatedGeometryDidChange(const WebCore::IntRect& frameRect, const WebCore::IntRect& clipRect) = 0;
// Tells the plug-in that it has been explicitly hidden or shown. (Note that this is not called when the plug-in becomes obscured from view on screen.)
virtual void visibilityDidChange() = 0;
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp (98645 => 98646)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2011-10-27 22:05:17 UTC (rev 98645)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2011-10-27 22:07:32 UTC (rev 98646)
@@ -233,7 +233,7 @@
m_connection->connection()->send(Messages::PluginControllerProxy::GeometryDidChange(m_frameRect, m_clipRect, contentsScaleFactor, pluginBackingStoreHandle), m_pluginInstanceID, CoreIPC::DispatchMessageEvenWhenWaitingForSyncReply);
}
-void PluginProxy::geometryDidChange(const IntRect& frameRect, const IntRect& clipRect)
+void PluginProxy::deprecatedGeometryDidChange(const IntRect& frameRect, const IntRect& clipRect)
{
m_frameRect = frameRect;
m_clipRect = clipRect;
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h (98645 => 98646)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h 2011-10-27 22:05:17 UTC (rev 98645)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h 2011-10-27 22:07:32 UTC (rev 98646)
@@ -71,7 +71,7 @@
virtual PlatformLayer* pluginLayer();
#endif
virtual bool isTransparent();
- virtual void geometryDidChange(const WebCore::IntRect& frameRect, const WebCore::IntRect& clipRect);
+ virtual void deprecatedGeometryDidChange(const WebCore::IntRect& frameRect, const WebCore::IntRect& clipRect);
virtual void visibilityDidChange();
virtual void frameDidFinishLoading(uint64_t requestID);
virtual void frameDidFail(uint64_t requestID, bool wasCancelled);
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (98645 => 98646)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2011-10-27 22:05:17 UTC (rev 98645)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2011-10-27 22:07:32 UTC (rev 98646)
@@ -726,7 +726,7 @@
rect = frameRect();
}
- m_plugin->geometryDidChange(rect, clipRectInWindowCoordinates());
+ m_plugin->deprecatedGeometryDidChange(rect, clipRectInWindowCoordinates());
}
void PluginView::viewVisibilityDidChange()
