Title: [207794] trunk/Source
Revision
207794
Author
[email protected]
Date
2016-10-24 17:45:03 -0700 (Mon, 24 Oct 2016)

Log Message

[Win] CMake build type is not set.
https://bugs.webkit.org/show_bug.cgi?id=163917

Reviewed by Alex Christensen.

The CMAKE_BUILD_TYPE variable should be set to Debug or Release.

Source/_javascript_Core:

* _javascript_Core.vcxproj/_javascript_Core.proj:

Source/WebCore:

* WebCore.vcxproj/WebCore.proj:

Source/WebKit:

* WebKit.vcxproj/WebKit.proj:

Source/WTF:

* WTF.vcxproj/WTF.proj:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (207793 => 207794)


--- trunk/Source/_javascript_Core/ChangeLog	2016-10-25 00:31:05 UTC (rev 207793)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-10-25 00:45:03 UTC (rev 207794)
@@ -1,3 +1,14 @@
+2016-10-24  Per Arne Vollan  <[email protected]>
+
+        [Win] CMake build type is not set.
+        https://bugs.webkit.org/show_bug.cgi?id=163917
+
+        Reviewed by Alex Christensen.
+
+        The CMAKE_BUILD_TYPE variable should be set to Debug or Release.
+
+        * _javascript_Core.vcxproj/_javascript_Core.proj:
+
 2016-10-24  Chris Dumez  <[email protected]>
 
         Reduce special handling for typed arrays in JSDOMConvert.h

Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.proj (207793 => 207794)


--- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.proj	2016-10-25 00:31:05 UTC (rev 207793)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.proj	2016-10-25 00:45:03 UTC (rev 207794)
@@ -28,7 +28,7 @@
     <ProgramFilesAAS64>Program Files\Common Files\Apple\Apple Application Support</ProgramFilesAAS64>
     <ConfigurationBuildDir>$(OBJROOT)\$(CONFIG)</ConfigurationBuildDir>  
     <OutputDirectory>$(DSTROOT)</OutputDirectory>
-	<CMakeCommandCommon>cmake $(SRCROOT) -DPORT=AppleWin $(DebugSuffixDefinition) -DWEBKIT_LIBRARIES_DIR=$(WebKit_Libraries.Replace('\','/')) -DCMAKE_MODULE_PATH=$(SRCROOT.Replace('\','/'))/AppleInternal/tools/cmake -DCMAKE_BINARY_DIR=$(OBJROOT.Replace('\','/'))/$(CONFIG) -DJAVASCRIPTCORE_DIR=$(SRCROOT.Replace('\','/'))</CMakeCommandCommon>
+	<CMakeCommandCommon>cmake $(SRCROOT) -DPORT=AppleWin $(DebugSuffixDefinition) -DWEBKIT_LIBRARIES_DIR=$(WebKit_Libraries.Replace('\','/')) -DCMAKE_MODULE_PATH=$(SRCROOT.Replace('\','/'))/AppleInternal/tools/cmake -DCMAKE_BINARY_DIR=$(OBJROOT.Replace('\','/'))/$(CONFIG) -DCMAKE_BUILD_TYPE=$(CONFIGURATION) -DJAVASCRIPTCORE_DIR=$(SRCROOT.Replace('\','/'))</CMakeCommandCommon>
   </PropertyGroup>
  
   <!-- Prepare for build -->

Modified: trunk/Source/WTF/ChangeLog (207793 => 207794)


--- trunk/Source/WTF/ChangeLog	2016-10-25 00:31:05 UTC (rev 207793)
+++ trunk/Source/WTF/ChangeLog	2016-10-25 00:45:03 UTC (rev 207794)
@@ -1,3 +1,14 @@
+2016-10-24  Per Arne Vollan  <[email protected]>
+
+        [Win] CMake build type is not set.
+        https://bugs.webkit.org/show_bug.cgi?id=163917
+
+        Reviewed by Alex Christensen.
+
+        The CMAKE_BUILD_TYPE variable should be set to Debug or Release.
+
+        * WTF.vcxproj/WTF.proj:
+
 2016-10-23  Yusuke Suzuki  <[email protected]>
 
         [DOMJIT] Add a way for DOMJIT::Patchpoint to express effects

Modified: trunk/Source/WTF/WTF.vcxproj/WTF.proj (207793 => 207794)


--- trunk/Source/WTF/WTF.vcxproj/WTF.proj	2016-10-25 00:31:05 UTC (rev 207793)
+++ trunk/Source/WTF/WTF.vcxproj/WTF.proj	2016-10-25 00:45:03 UTC (rev 207794)
@@ -28,7 +28,7 @@
     <ProgramFilesAAS64>Program Files\Common Files\Apple\Apple Application Support</ProgramFilesAAS64>
     <ConfigurationBuildDir>$(OBJROOT)\$(CONFIG)</ConfigurationBuildDir>
     <OutputDirectory>$(DSTROOT)</OutputDirectory>
-	<CMakeCommandCommon>cmake $(SRCROOT) -DPORT=AppleWin $(DebugSuffixDefinition) -DWEBKIT_LIBRARIES_DIR=$(WebKit_Libraries.Replace('\','/')) -DCMAKE_MODULE_PATH=$(SRCROOT.Replace('\','/'))/AppleInternal/tools/cmake -DCMAKE_BINARY_DIR=$(OBJROOT.Replace('\','/'))/$(CONFIG) -DWTF_DIR=$(SRCROOT.Replace('\','/'))</CMakeCommandCommon>
+	<CMakeCommandCommon>cmake $(SRCROOT) -DPORT=AppleWin $(DebugSuffixDefinition) -DWEBKIT_LIBRARIES_DIR=$(WebKit_Libraries.Replace('\','/')) -DCMAKE_MODULE_PATH=$(SRCROOT.Replace('\','/'))/AppleInternal/tools/cmake -DCMAKE_BINARY_DIR=$(OBJROOT.Replace('\','/'))/$(CONFIG) -DCMAKE_BUILD_TYPE=$(CONFIGURATION) -DWTF_DIR=$(SRCROOT.Replace('\','/'))</CMakeCommandCommon>
   </PropertyGroup>
 
   <!-- Prepare for build -->

Modified: trunk/Source/WebCore/ChangeLog (207793 => 207794)


--- trunk/Source/WebCore/ChangeLog	2016-10-25 00:31:05 UTC (rev 207793)
+++ trunk/Source/WebCore/ChangeLog	2016-10-25 00:45:03 UTC (rev 207794)
@@ -1,3 +1,14 @@
+2016-10-24  Per Arne Vollan  <[email protected]>
+
+        [Win] CMake build type is not set.
+        https://bugs.webkit.org/show_bug.cgi?id=163917
+
+        Reviewed by Alex Christensen.
+
+        The CMAKE_BUILD_TYPE variable should be set to Debug or Release.
+
+        * WebCore.vcxproj/WebCore.proj:
+
 2016-10-24  Yusuke Suzuki  <[email protected]>
 
         Unreviewed, attempt to fix Windows build after r207787

Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.proj (207793 => 207794)


--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.proj	2016-10-25 00:31:05 UTC (rev 207793)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.proj	2016-10-25 00:45:03 UTC (rev 207794)
@@ -28,7 +28,7 @@
     <ProgramFilesAAS64>Program Files\Common Files\Apple\Apple Application Support</ProgramFilesAAS64>
     <ConfigurationBuildDir>$(OBJROOT)\$(CONFIG)</ConfigurationBuildDir>  
     <OutputDirectory>$(DSTROOT)</OutputDirectory>
-	<CMakeCommandCommon>cmake $(SRCROOT) -DPORT=AppleWin $(DebugSuffixDefinition) -DINTERNAL_BUILD=1 -DWEBKIT_LIBRARIES_DIR=$(WebKit_Libraries.Replace('\','/')) -DCMAKE_MODULE_PATH=$(SRCROOT.Replace('\','/'))/AppleInternal/tools/cmake -DCMAKE_BINARY_DIR=$(OBJROOT.Replace('\','/'))/$(CONFIG) -DWEBCORE_DIR=$(SRCROOT.Replace('\','/'))</CMakeCommandCommon>
+	<CMakeCommandCommon>cmake $(SRCROOT) -DPORT=AppleWin $(DebugSuffixDefinition) -DINTERNAL_BUILD=1 -DWEBKIT_LIBRARIES_DIR=$(WebKit_Libraries.Replace('\','/')) -DCMAKE_MODULE_PATH=$(SRCROOT.Replace('\','/'))/AppleInternal/tools/cmake -DCMAKE_BINARY_DIR=$(OBJROOT.Replace('\','/'))/$(CONFIG) -DCMAKE_BUILD_TYPE=$(CONFIGURATION) -DWEBCORE_DIR=$(SRCROOT.Replace('\','/'))</CMakeCommandCommon>
   </PropertyGroup>
  
   <!-- Prepare for build -->

Modified: trunk/Source/WebKit/ChangeLog (207793 => 207794)


--- trunk/Source/WebKit/ChangeLog	2016-10-25 00:31:05 UTC (rev 207793)
+++ trunk/Source/WebKit/ChangeLog	2016-10-25 00:45:03 UTC (rev 207794)
@@ -1,3 +1,14 @@
+2016-10-24  Per Arne Vollan  <[email protected]>
+
+        [Win] CMake build type is not set.
+        https://bugs.webkit.org/show_bug.cgi?id=163917
+
+        Reviewed by Alex Christensen.
+
+        The CMAKE_BUILD_TYPE variable should be set to Debug or Release.
+
+        * WebKit.vcxproj/WebKit.proj:
+
 2016-10-19  Alex Christensen  <[email protected]>
 
         Revert r207151

Modified: trunk/Source/WebKit/WebKit.vcxproj/WebKit.proj (207793 => 207794)


--- trunk/Source/WebKit/WebKit.vcxproj/WebKit.proj	2016-10-25 00:31:05 UTC (rev 207793)
+++ trunk/Source/WebKit/WebKit.vcxproj/WebKit.proj	2016-10-25 00:45:03 UTC (rev 207794)
@@ -28,7 +28,7 @@
     <ProgramFilesAAS64>Program Files\Common Files\Apple\Apple Application Support</ProgramFilesAAS64>
     <ConfigurationBuildDir>$(OBJROOT)\$(CONFIG)</ConfigurationBuildDir>  
     <OutputDirectory>$(DSTROOT)</OutputDirectory>
-	<CMakeCommandCommon>cmake $(SRCROOT) -DPORT=AppleWin $(DebugSuffixDefinition) -DWEBKIT_LIBRARIES_DIR=$(WebKit_Libraries.Replace('\','/')) -DCMAKE_MODULE_PATH=$(SRCROOT.Replace('\','/'))/AppleInternal/tools/cmake -DCMAKE_BINARY_DIR=$(OBJROOT.Replace('\','/'))/$(CONFIG) -DWEBKIT_DIR=$(SRCROOT.Replace('\','/'))</CMakeCommandCommon>
+	<CMakeCommandCommon>cmake $(SRCROOT) -DPORT=AppleWin $(DebugSuffixDefinition) -DWEBKIT_LIBRARIES_DIR=$(WebKit_Libraries.Replace('\','/')) -DCMAKE_MODULE_PATH=$(SRCROOT.Replace('\','/'))/AppleInternal/tools/cmake -DCMAKE_BINARY_DIR=$(OBJROOT.Replace('\','/'))/$(CONFIG) -DCMAKE_BUILD_TYPE=$(CONFIGURATION) -DWEBKIT_DIR=$(SRCROOT.Replace('\','/'))</CMakeCommandCommon>
   </PropertyGroup>
  
   <!-- Prepare for build -->
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to