Title: [207807] trunk/Source/WebKit2
Revision
207807
Author
[email protected]
Date
2016-10-24 22:22:40 -0700 (Mon, 24 Oct 2016)

Log Message

REGRESSION (r206410): Sandbox violations beneath WebProcessProxy::platformIsBeingDebugged
https://bugs.webkit.org/show_bug.cgi?id=163879
<rdar://problem/28728735>

Reviewed by Darin Adler.

* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::platformIsBeingDebugged): Check if the current process, which is
  the UI process, is sandboxed before trying to find out if the Web process is being
  debugged.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (207806 => 207807)


--- trunk/Source/WebKit2/ChangeLog	2016-10-25 05:16:00 UTC (rev 207806)
+++ trunk/Source/WebKit2/ChangeLog	2016-10-25 05:22:40 UTC (rev 207807)
@@ -1,3 +1,16 @@
+2016-10-24  Dan Bernstein  <[email protected]>
+
+        REGRESSION (r206410): Sandbox violations beneath WebProcessProxy::platformIsBeingDebugged
+        https://bugs.webkit.org/show_bug.cgi?id=163879
+        <rdar://problem/28728735>
+
+        Reviewed by Darin Adler.
+
+        * UIProcess/Cocoa/WebProcessProxyCocoa.mm:
+        (WebKit::WebProcessProxy::platformIsBeingDebugged): Check if the current process, which is
+          the UI process, is sandboxed before trying to find out if the Web process is being
+          debugged.
+
 2016-10-21  Alex Christensen  <[email protected]>
 
         URL::port should return Optional<uint16_t>

Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebProcessProxyCocoa.mm (207806 => 207807)


--- trunk/Source/WebKit2/UIProcess/Cocoa/WebProcessProxyCocoa.mm	2016-10-25 05:16:00 UTC (rev 207806)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/WebProcessProxyCocoa.mm	2016-10-25 05:22:40 UTC (rev 207807)
@@ -27,6 +27,7 @@
 #import "WebProcessProxy.h"
 
 #import "ObjCObjectGraph.h"
+#import "SandboxUtilities.h"
 #import "WKBrowsingContextControllerInternal.h"
 #import "WKBrowsingContextHandleInternal.h"
 #import "WKTypeRefWrapper.h"
@@ -123,6 +124,10 @@
 
 bool WebProcessProxy::platformIsBeingDebugged() const
 {
+    // If the UI process is sandboxed, it cannot find out whether other processes are being debugged.
+    if (processIsSandboxed(getpid()))
+        return false;
+
     struct kinfo_proc info;
     int mib[] = { CTL_KERN, KERN_PROC, KERN_PROC_PID, processIdentifier() };
     size_t size = sizeof(info);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to