Title: [207835] trunk
Revision
207835
Author
[email protected]
Date
2016-10-25 12:22:54 -0700 (Tue, 25 Oct 2016)

Log Message

[Modern Media Controls] Media Controller: skip back support
https://bugs.webkit.org/show_bug.cgi?id=163725
<rdar://problem/27989480>

Patch by Antoine Quint <[email protected]> on 2016-10-25
Reviewed by Dean Jackson.

Source/WebCore:

We introduce the SkipBackSupport class which brings support for skipping back
30 seconds into the media by clicking on the skip back button in the media controls.

Test: http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html

* Modules/modern-media-controls/js-files:
* Modules/modern-media-controls/media/media-controller.js:
(MediaController):
* Modules/modern-media-controls/media/skip-back-support.js: Copied from Source/WebCore/Modules/modern-media-controls/media/media-controller.js.
(SkipBackSupport.prototype.get control):
(SkipBackSupport.prototype.buttonWasClicked):
(SkipBackSupport):
* WebCore.xcodeproj/project.pbxproj:

Tools:

* Scripts/webkitpy/layout_tests/servers/aliases.json: Adding a new alias such that we may
access the modern-media-controls source files through the web server.

LayoutTests:

Added a new test for the SkipBackButton class to ensure that we correctly seek back by 30 seconds when pressed.
Updated the other tests to reflect the addition of the SkipBackSupport class.

* http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click-expected.txt: Added.
* http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html: Added.
* media/modern-media-controls/media-controller/media-controller-constructor.html:
* media/modern-media-controls/media-controller/media-controller-resize.html:
* media/modern-media-controls/mute-support/mute-support-button-click.html:
* media/modern-media-controls/mute-support/mute-support-media-api.html:
* media/modern-media-controls/mute-support/mute-support-muted.html:
* media/modern-media-controls/start-support/start-support-audio.html:
* media/modern-media-controls/start-support/start-support-autoplay.html:
* media/modern-media-controls/start-support/start-support-click-to-start.html:
* media/modern-media-controls/start-support/start-support-error.html:
* media/modern-media-controls/start-support/start-support-fullscreen.html:
* media/modern-media-controls/start-support/start-support-manual-play.html:
* media/modern-media-controls/start-support/start-support-no-source.html:

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (207834 => 207835)


--- trunk/LayoutTests/ChangeLog	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/LayoutTests/ChangeLog	2016-10-25 19:22:54 UTC (rev 207835)
@@ -1,3 +1,29 @@
+2016-10-25  Antoine Quint  <[email protected]>
+
+        [Modern Media Controls] Media Controller: skip back support
+        https://bugs.webkit.org/show_bug.cgi?id=163725
+        <rdar://problem/27989480>
+
+        Reviewed by Dean Jackson.
+
+        Added a new test for the SkipBackButton class to ensure that we correctly seek back by 30 seconds when pressed.
+        Updated the other tests to reflect the addition of the SkipBackSupport class.
+
+        * http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click-expected.txt: Added.
+        * http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html: Added.
+        * media/modern-media-controls/media-controller/media-controller-constructor.html:
+        * media/modern-media-controls/media-controller/media-controller-resize.html:
+        * media/modern-media-controls/mute-support/mute-support-button-click.html:
+        * media/modern-media-controls/mute-support/mute-support-media-api.html:
+        * media/modern-media-controls/mute-support/mute-support-muted.html:
+        * media/modern-media-controls/start-support/start-support-audio.html:
+        * media/modern-media-controls/start-support/start-support-autoplay.html:
+        * media/modern-media-controls/start-support/start-support-click-to-start.html:
+        * media/modern-media-controls/start-support/start-support-error.html:
+        * media/modern-media-controls/start-support/start-support-fullscreen.html:
+        * media/modern-media-controls/start-support/start-support-manual-play.html:
+        * media/modern-media-controls/start-support/start-support-no-source.html:
+
 2016-10-25  Commit Queue  <[email protected]>
 
         Unreviewed, rolling out r207578.

Added: trunk/LayoutTests/http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click-expected.txt (0 => 207835)


--- trunk/LayoutTests/http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click-expected.txt	2016-10-25 19:22:54 UTC (rev 207835)
@@ -0,0 +1,20 @@
+Testing the SkipBackSupport behavior by clicking on the mute button.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+
+Dispatching click event to the skip back button
+
+seeked event was dispatched
+PASS media.currentTime is 20
+
+Dispatching click event to the skip back button
+
+seeked event was dispatched
+PASS media.currentTime is within 0.1 of 0
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Added: trunk/LayoutTests/http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html (0 => 207835)


--- trunk/LayoutTests/http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html	                        (rev 0)
+++ trunk/LayoutTests/http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html	2016-10-25 19:22:54 UTC (rev 207835)
@@ -0,0 +1,82 @@
+<script src=""
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
+<body>
+<video src="" style="width: 320px; height: 240px;"></video>
+<div id="shadow"></div>
+<script type="text/_javascript_">
+
+window.jsTestIsAsync = true;
+
+description("Testing the <code>SkipBackSupport</code> behavior by clicking on the mute button.");
+
+iconService.directoryPath = "/modern-media-controls/images";
+
+const shadowRoot = document.querySelector("div#shadow").attachShadow({ mode: "open" });
+const media = document.querySelector("video");
+const mediaController = createControls(shadowRoot, media, null);
+
+media.addEventListener("canplaythrough", event => {
+    media.currentTime = 50;
+    clickSkipBackButton();
+});
+
+let numberOfEvents = 0;
+media.addEventListener("seeked", function() {
+    debug("");
+    debug("seeked event was dispatched");
+
+    numberOfEvents++;
+
+    if (numberOfEvents == 1) {
+        shouldBe("media.currentTime", "20");
+        clickSkipBackButton();
+    } else if (numberOfEvents == 2) {
+        shouldBeCloseTo("media.currentTime", 0, 0.1);
+        debug("");
+        shadowRoot.host.remove();
+        media.remove();
+        finishJSTest();
+    }
+});
+
+function clickSkipBackButton()
+{
+    debug("");
+    debug("Dispatching click event to the skip back button");
+    mediaController.controls.skipBackButton.element.click();
+}
+
+</script>
+<script src=""
+</body>

Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-constructor.html (207834 => 207835)


--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-constructor.html	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-constructor.html	2016-10-25 19:22:54 UTC (rev 207835)
@@ -27,6 +27,7 @@
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>

Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-resize.html (207834 => 207835)


--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-resize.html	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-resize.html	2016-10-25 19:22:54 UTC (rev 207835)
@@ -27,6 +27,7 @@
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>

Modified: trunk/LayoutTests/media/modern-media-controls/mute-support/mute-support-button-click.html (207834 => 207835)


--- trunk/LayoutTests/media/modern-media-controls/mute-support/mute-support-button-click.html	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/LayoutTests/media/modern-media-controls/mute-support/mute-support-button-click.html	2016-10-25 19:22:54 UTC (rev 207835)
@@ -27,6 +27,7 @@
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>

Modified: trunk/LayoutTests/media/modern-media-controls/mute-support/mute-support-media-api.html (207834 => 207835)


--- trunk/LayoutTests/media/modern-media-controls/mute-support/mute-support-media-api.html	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/LayoutTests/media/modern-media-controls/mute-support/mute-support-media-api.html	2016-10-25 19:22:54 UTC (rev 207835)
@@ -27,6 +27,7 @@
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>

Modified: trunk/LayoutTests/media/modern-media-controls/mute-support/mute-support-muted.html (207834 => 207835)


--- trunk/LayoutTests/media/modern-media-controls/mute-support/mute-support-muted.html	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/LayoutTests/media/modern-media-controls/mute-support/mute-support-muted.html	2016-10-25 19:22:54 UTC (rev 207835)
@@ -27,6 +27,7 @@
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>

Modified: trunk/LayoutTests/media/modern-media-controls/start-support/start-support-audio.html (207834 => 207835)


--- trunk/LayoutTests/media/modern-media-controls/start-support/start-support-audio.html	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/LayoutTests/media/modern-media-controls/start-support/start-support-audio.html	2016-10-25 19:22:54 UTC (rev 207835)
@@ -27,6 +27,7 @@
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>

Modified: trunk/LayoutTests/media/modern-media-controls/start-support/start-support-autoplay.html (207834 => 207835)


--- trunk/LayoutTests/media/modern-media-controls/start-support/start-support-autoplay.html	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/LayoutTests/media/modern-media-controls/start-support/start-support-autoplay.html	2016-10-25 19:22:54 UTC (rev 207835)
@@ -27,6 +27,7 @@
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>

Modified: trunk/LayoutTests/media/modern-media-controls/start-support/start-support-click-to-start.html (207834 => 207835)


--- trunk/LayoutTests/media/modern-media-controls/start-support/start-support-click-to-start.html	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/LayoutTests/media/modern-media-controls/start-support/start-support-click-to-start.html	2016-10-25 19:22:54 UTC (rev 207835)
@@ -27,6 +27,7 @@
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>

Modified: trunk/LayoutTests/media/modern-media-controls/start-support/start-support-error.html (207834 => 207835)


--- trunk/LayoutTests/media/modern-media-controls/start-support/start-support-error.html	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/LayoutTests/media/modern-media-controls/start-support/start-support-error.html	2016-10-25 19:22:54 UTC (rev 207835)
@@ -27,6 +27,7 @@
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>

Modified: trunk/LayoutTests/media/modern-media-controls/start-support/start-support-fullscreen.html (207834 => 207835)


--- trunk/LayoutTests/media/modern-media-controls/start-support/start-support-fullscreen.html	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/LayoutTests/media/modern-media-controls/start-support/start-support-fullscreen.html	2016-10-25 19:22:54 UTC (rev 207835)
@@ -27,6 +27,7 @@
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>

Modified: trunk/LayoutTests/media/modern-media-controls/start-support/start-support-manual-play.html (207834 => 207835)


--- trunk/LayoutTests/media/modern-media-controls/start-support/start-support-manual-play.html	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/LayoutTests/media/modern-media-controls/start-support/start-support-manual-play.html	2016-10-25 19:22:54 UTC (rev 207835)
@@ -27,6 +27,7 @@
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>

Modified: trunk/LayoutTests/media/modern-media-controls/start-support/start-support-no-source.html (207834 => 207835)


--- trunk/LayoutTests/media/modern-media-controls/start-support/start-support-no-source.html	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/LayoutTests/media/modern-media-controls/start-support/start-support-no-source.html	2016-10-25 19:22:54 UTC (rev 207835)
@@ -27,6 +27,7 @@
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
+<script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>
 <script src="" type="text/_javascript_"></script>

Modified: trunk/Source/WebCore/ChangeLog (207834 => 207835)


--- trunk/Source/WebCore/ChangeLog	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/Source/WebCore/ChangeLog	2016-10-25 19:22:54 UTC (rev 207835)
@@ -1,3 +1,25 @@
+2016-10-25  Antoine Quint  <[email protected]>
+
+        [Modern Media Controls] Media Controller: skip back support
+        https://bugs.webkit.org/show_bug.cgi?id=163725
+        <rdar://problem/27989480>
+
+        Reviewed by Dean Jackson.
+
+        We introduce the SkipBackSupport class which brings support for skipping back
+        30 seconds into the media by clicking on the skip back button in the media controls.
+
+        Test: http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html
+
+        * Modules/modern-media-controls/js-files:
+        * Modules/modern-media-controls/media/media-controller.js:
+        (MediaController):
+        * Modules/modern-media-controls/media/skip-back-support.js: Copied from Source/WebCore/Modules/modern-media-controls/media/media-controller.js.
+        (SkipBackSupport.prototype.get control):
+        (SkipBackSupport.prototype.buttonWasClicked):
+        (SkipBackSupport):
+        * WebCore.xcodeproj/project.pbxproj:
+
 2016-10-25  Commit Queue  <[email protected]>
 
         Unreviewed, rolling out r207578.

Modified: trunk/Source/WebCore/Modules/modern-media-controls/js-files (207834 => 207835)


--- trunk/Source/WebCore/Modules/modern-media-controls/js-files	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/Source/WebCore/Modules/modern-media-controls/js-files	2016-10-25 19:22:54 UTC (rev 207835)
@@ -28,7 +28,8 @@
 controls/airplay-placard.js
 controls/pip-placard.js
 media/media-controller-support.js
+media/mute-support.js
+media/skip-back-support.js
 media/start-support.js
-media/mute-support.js
 media/media-controller.js
 main.js

Modified: trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js (207834 => 207835)


--- trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js	2016-10-25 19:22:54 UTC (rev 207835)
@@ -38,8 +38,9 @@
         this.controls = new MacOSInlineMediaControls
         shadowRoot.appendChild(this.controls.element);        
 
+        new MuteSupport(this);
+        new SkipBackSupport(this);
         new StartSupport(this);
-        new MuteSupport(this);
 
         this._updateControlsSize();
         media.addEventListener("resize", this);

Copied: trunk/Source/WebCore/Modules/modern-media-controls/media/skip-back-support.js (from rev 207834, trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js) (0 => 207835)


--- trunk/Source/WebCore/Modules/modern-media-controls/media/skip-back-support.js	                        (rev 0)
+++ trunk/Source/WebCore/Modules/modern-media-controls/media/skip-back-support.js	2016-10-25 19:22:54 UTC (rev 207835)
@@ -0,0 +1,44 @@
+/*
+ * Copyright (C) 2016 Apple Inc. All Rights Reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+const SkipBackSeconds = 30;
+
+class SkipBackSupport extends MediaControllerSupport
+{
+
+    // Protected
+
+    get control()
+    {
+        return this.mediaController.controls.skipBackButton;
+    }
+
+    buttonWasClicked(control)
+    {
+        const media = this.mediaController.media;
+        media.currentTime = Math.max(media.currentTime - SkipBackSeconds, media.seekable.start(0));
+    }
+
+}

Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (207834 => 207835)


--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2016-10-25 19:22:54 UTC (rev 207835)
@@ -9866,6 +9866,7 @@
 		71CC7A1F152A0BFE009EEAF9 /* SVGAnimatedEnumeration.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SVGAnimatedEnumeration.cpp; sourceTree = "<group>"; };
 		71D02D901DB55C4E00DD5CF5 /* main.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode._javascript_; path = main.js; sourceTree = "<group>"; };
 		71D02D921DB55C4E00DD5CF5 /* media-controller.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode._javascript_; path = "media-controller.js"; sourceTree = "<group>"; };
+		71D2554F1DB900020004D76B /* skip-back-support.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode._javascript_; path = "skip-back-support.js"; sourceTree = "<group>"; };
 		71D6AA711DA4EAF700B23969 /* [email protected] */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "[email protected]"; sourceTree = "<group>"; };
 		71D6AA721DA4EAF700B23969 /* [email protected] */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "[email protected]"; sourceTree = "<group>"; };
 		71D6AA731DA4EAF700B23969 /* [email protected] */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "[email protected]"; sourceTree = "<group>"; };
@@ -9940,6 +9941,7 @@
 		71E2183917359FB8006E6E4D /* PlugInsResourcesData.cpp */ = {isa = PBXFileReference; explicitFileType = sourcecode.cpp.cpp; fileEncoding = 4; path = PlugInsResourcesData.cpp; sourceTree = "<group>"; };
 		71E623CE151F72A60036E2F4 /* SVGAnimatedIntegerOptionalInteger.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SVGAnimatedIntegerOptionalInteger.cpp; sourceTree = "<group>"; };
 		71E623CF151F72A60036E2F4 /* SVGAnimatedIntegerOptionalInteger.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SVGAnimatedIntegerOptionalInteger.h; sourceTree = "<group>"; };
+		71E6B2CF1DBE5D9A00C0A13E /* js-files */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = "js-files"; sourceTree = "<group>"; };
 		71FB967A1383D64600AC8A4C /* SVGAnimatedEnumerationPropertyTearOff.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SVGAnimatedEnumerationPropertyTearOff.h; sourceTree = "<group>"; };
 		724ED3291A3A7E5400F5F13C /* EXTBlendMinMax.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = EXTBlendMinMax.cpp; sourceTree = "<group>"; };
 		724ED32A1A3A7E5400F5F13C /* EXTBlendMinMax.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EXTBlendMinMax.h; sourceTree = "<group>"; };
@@ -17769,6 +17771,7 @@
 				7177E2461DB80D2F00919A0B /* media-controller-support.js */,
 				71D02D921DB55C4E00DD5CF5 /* media-controller.js */,
 				7177E2471DB80D2F00919A0B /* mute-support.js */,
+				71D2554F1DB900020004D76B /* skip-back-support.js */,
 				7177E2481DB80D2F00919A0B /* start-support.js */,
 			);
 			path = media;
@@ -17777,6 +17780,7 @@
 		71D6AA391DA4EAF700B23969 /* modern-media-controls */ = {
 			isa = PBXGroup;
 			children = (
+				71E6B2CF1DBE5D9A00C0A13E /* js-files */,
 				71D02D901DB55C4E00DD5CF5 /* main.js */,
 				716FA0D71DB26591007323CC /* controls */,
 				71D6AA6F1DA4EAF700B23969 /* images */,

Modified: trunk/Tools/ChangeLog (207834 => 207835)


--- trunk/Tools/ChangeLog	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/Tools/ChangeLog	2016-10-25 19:22:54 UTC (rev 207835)
@@ -1,3 +1,14 @@
+2016-10-25  Antoine Quint  <[email protected]>
+
+        [Modern Media Controls] Media Controller: skip back support
+        https://bugs.webkit.org/show_bug.cgi?id=163725
+        <rdar://problem/27989480>
+
+        Reviewed by Dean Jackson.
+
+        * Scripts/webkitpy/layout_tests/servers/aliases.json: Adding a new alias such that we may
+        access the modern-media-controls source files through the web server.
+
 2016-10-19  Jer Noble  <[email protected]>
 
         Add WKWebView fullscreen delegate SPI

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/servers/aliases.json (207834 => 207835)


--- trunk/Tools/Scripts/webkitpy/layout_tests/servers/aliases.json	2016-10-25 19:22:12 UTC (rev 207834)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/servers/aliases.json	2016-10-25 19:22:54 UTC (rev 207835)
@@ -1,6 +1,7 @@
 [
     ["/js-test-resources", "resources"],
     ["/media-resources", "media"],
+    ["/modern-media-controls", "../Source/WebCore/Modules/modern-media-controls"],
     ["/resources/testharness.css", "resources/testharness.css"],
     ["/resources/testharness.js", "resources/testharness.js"],
     ["/resources/testharnessreport.js", "resources/testharnessreport.js"]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to