Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (207927 => 207928)
--- trunk/Source/_javascript_Core/ChangeLog 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-10-27 00:17:52 UTC (rev 207928)
@@ -1,3 +1,15 @@
+2016-10-26 Brian Burg <[email protected]>
+
+ Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
+ https://bugs.webkit.org/show_bug.cgi?id=164046
+
+ Reviewed by Joseph Pecoraro.
+
+ * inspector/InspectorFrontendChannel.h:
+ * inspector/remote/RemoteConnectionToTarget.h:
+ * inspector/remote/RemoteConnectionToTarget.mm:
+ (Inspector::RemoteConnectionToTarget::sendMessageToFrontend):
+
2016-10-26 JF Bastien <[email protected]>
WebAssembly: remove now-dead JSWasmModule
Modified: trunk/Source/_javascript_Core/inspector/InspectorFrontendChannel.h (207927 => 207928)
--- trunk/Source/_javascript_Core/inspector/InspectorFrontendChannel.h 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/_javascript_Core/inspector/InspectorFrontendChannel.h 2016-10-27 00:17:52 UTC (rev 207928)
@@ -42,7 +42,7 @@
virtual ~FrontendChannel() { }
virtual ConnectionType connectionType() const = 0;
- virtual bool sendMessageToFrontend(const String& message) = 0;
+ virtual void sendMessageToFrontend(const String& message) = 0;
};
} // namespace Inspector
Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteConnectionToTarget.h (207927 => 207928)
--- trunk/Source/_javascript_Core/inspector/remote/RemoteConnectionToTarget.h 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteConnectionToTarget.h 2016-10-27 00:17:52 UTC (rev 207928)
@@ -63,7 +63,7 @@
// FrontendChannel overrides.
ConnectionType connectionType() const override { return ConnectionType::Remote; }
- bool sendMessageToFrontend(const String&) override;
+ void sendMessageToFrontend(const String&) override;
private:
void dispatchAsyncOnTarget(void (^block)());
Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteConnectionToTarget.mm (207927 => 207928)
--- trunk/Source/_javascript_Core/inspector/remote/RemoteConnectionToTarget.mm 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteConnectionToTarget.mm 2016-10-27 00:17:52 UTC (rev 207928)
@@ -228,13 +228,12 @@
});
}
-bool RemoteConnectionToTarget::sendMessageToFrontend(const String& message)
+void RemoteConnectionToTarget::sendMessageToFrontend(const String& message)
{
- if (!m_target)
- return false;
+ if (!targetIdentifier())
+ return;
RemoteInspector::singleton().sendMessageToRemote(targetIdentifier().value(), message);
- return true;
}
void RemoteConnectionToTarget::setupRunLoop()
Modified: trunk/Source/WebCore/ChangeLog (207927 => 207928)
--- trunk/Source/WebCore/ChangeLog 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebCore/ChangeLog 2016-10-27 00:17:52 UTC (rev 207928)
@@ -1,3 +1,16 @@
+2016-10-26 Brian Burg <[email protected]>
+
+ Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
+ https://bugs.webkit.org/show_bug.cgi?id=164046
+
+ Reviewed by Joseph Pecoraro.
+
+ * inspector/InspectorClient.cpp:
+ (WebCore::InspectorClient::doDispatchMessageOnFrontendPage):
+ * inspector/InspectorClient.h:
+ * testing/Internals.cpp:
+ (WebCore::InspectorStubFrontend::sendMessageToFrontend):
+
2016-10-26 Chris Dumez <[email protected]>
The URLSearchParams constructor should take a union in parameter
Modified: trunk/Source/WebCore/inspector/InspectorClient.cpp (207927 => 207928)
--- trunk/Source/WebCore/inspector/InspectorClient.cpp 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebCore/inspector/InspectorClient.cpp 2016-10-27 00:17:52 UTC (rev 207928)
@@ -41,16 +41,13 @@
namespace WebCore {
-bool InspectorClient::doDispatchMessageOnFrontendPage(Page* frontendPage, const String& message)
+void InspectorClient::doDispatchMessageOnFrontendPage(Page* frontendPage, const String& message)
{
if (!frontendPage)
- return false;
+ return;
- String dispatchToFrontend = "InspectorFrontendAPI.dispatchMessageAsync(" + message + ");";
-
- // FIXME: This should execute the script in the appropriate world.
+ String dispatchToFrontend = makeString("InspectorFrontendAPI.dispatchMessageAsync(", message, ");");
frontendPage->mainFrame().script().evaluate(ScriptSourceCode(dispatchToFrontend));
- return true;
}
} // namespace WebCore
Modified: trunk/Source/WebCore/inspector/InspectorClient.h (207927 => 207928)
--- trunk/Source/WebCore/inspector/InspectorClient.h 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebCore/inspector/InspectorClient.h 2016-10-27 00:17:52 UTC (rev 207928)
@@ -63,7 +63,7 @@
virtual bool handleJavaScriptDialog(bool, const String*) { return false; }
- WEBCORE_EXPORT static bool doDispatchMessageOnFrontendPage(Page* frontendPage, const String& message);
+ WEBCORE_EXPORT static void doDispatchMessageOnFrontendPage(Page* frontendPage, const String& message);
};
} // namespace WebCore
Modified: trunk/Source/WebCore/testing/Internals.cpp (207927 => 207928)
--- trunk/Source/WebCore/testing/Internals.cpp 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebCore/testing/Internals.cpp 2016-10-27 00:17:52 UTC (rev 207928)
@@ -250,7 +250,7 @@
void setAttachedWindowHeight(unsigned) final { }
void setAttachedWindowWidth(unsigned) final { }
- bool sendMessageToFrontend(const String& message) final;
+ void sendMessageToFrontend(const String& message) final;
ConnectionType connectionType() const final { return ConnectionType::Local; }
Page* frontendPage() const
@@ -293,11 +293,11 @@
m_frontendWindow = nullptr;
}
-bool InspectorStubFrontend::sendMessageToFrontend(const String& message)
+void InspectorStubFrontend::sendMessageToFrontend(const String& message)
{
ASSERT_ARG(message, !message.isEmpty());
- return InspectorClient::doDispatchMessageOnFrontendPage(frontendPage(), message);
+ InspectorClient::doDispatchMessageOnFrontendPage(frontendPage(), message);
}
static bool markerTypeFrom(const String& markerType, DocumentMarker::MarkerType& result)
Modified: trunk/Source/WebKit/cf/ChangeLog (207927 => 207928)
--- trunk/Source/WebKit/cf/ChangeLog 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit/cf/ChangeLog 2016-10-27 00:17:52 UTC (rev 207928)
@@ -1,3 +1,13 @@
+2016-10-26 Brian Burg <[email protected]>
+
+ Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
+ https://bugs.webkit.org/show_bug.cgi?id=164046
+
+ Reviewed by Joseph Pecoraro.
+
+ * WebCoreSupport/WebInspectorClientCF.cpp:
+ (WebInspectorClient::sendMessageToFrontend):
+
2016-10-11 Alex Christensen <[email protected]>
Remove dead networking code
Modified: trunk/Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp (207927 => 207928)
--- trunk/Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp 2016-10-27 00:17:52 UTC (rev 207928)
@@ -89,9 +89,9 @@
CFPreferencesSetAppValue(createKeyForPreferences(key).get(), setting.createCFString().get(), kCFPreferencesCurrentApplication);
}
-bool WebInspectorClient::sendMessageToFrontend(const String& message)
+void WebInspectorClient::sendMessageToFrontend(const String& message)
{
- return doDispatchMessageOnFrontendPage(m_frontendPage, message);
+ doDispatchMessageOnFrontendPage(m_frontendPage, message);
}
bool WebInspectorClient::inspectorAttachDisabled()
Modified: trunk/Source/WebKit/mac/ChangeLog (207927 => 207928)
--- trunk/Source/WebKit/mac/ChangeLog 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-10-27 00:17:52 UTC (rev 207928)
@@ -1,3 +1,12 @@
+2016-10-26 Brian Burg <[email protected]>
+
+ Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
+ https://bugs.webkit.org/show_bug.cgi?id=164046
+
+ Reviewed by Joseph Pecoraro.
+
+ * WebCoreSupport/WebInspectorClient.h:
+
2016-10-21 Alex Christensen <[email protected]>
URL::port should return Optional<uint16_t>
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h (207927 => 207928)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2016-10-27 00:17:52 UTC (rev 207928)
@@ -73,7 +73,7 @@
void didSetSearchingForNode(bool) override;
- bool sendMessageToFrontend(const String&) override;
+ void sendMessageToFrontend(const String&) override;
ConnectionType connectionType() const override { return ConnectionType::Local; }
bool inspectorStartsAttached();
Modified: trunk/Source/WebKit/win/ChangeLog (207927 => 207928)
--- trunk/Source/WebKit/win/ChangeLog 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit/win/ChangeLog 2016-10-27 00:17:52 UTC (rev 207928)
@@ -1,3 +1,12 @@
+2016-10-26 Brian Burg <[email protected]>
+
+ Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
+ https://bugs.webkit.org/show_bug.cgi?id=164046
+
+ Reviewed by Joseph Pecoraro.
+
+ * WebCoreSupport/WebInspectorClient.h:
+
2016-10-19 Alex Christensen <[email protected]>
Revert r207151
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h (207927 => 207928)
--- trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h 2016-10-27 00:17:52 UTC (rev 207928)
@@ -63,7 +63,7 @@
// FrontendChannel API.
ConnectionType connectionType() const override { return ConnectionType::Local; }
- bool sendMessageToFrontend(const WTF::String&) override;
+ void sendMessageToFrontend(const WTF::String&) override;
bool inspectorStartsAttached();
void setInspectorStartsAttached(bool);
Modified: trunk/Source/WebKit2/ChangeLog (207927 => 207928)
--- trunk/Source/WebKit2/ChangeLog 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit2/ChangeLog 2016-10-27 00:17:52 UTC (rev 207928)
@@ -1,3 +1,14 @@
+2016-10-26 Brian Burg <[email protected]>
+
+ Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
+ https://bugs.webkit.org/show_bug.cgi?id=164046
+
+ Reviewed by Joseph Pecoraro.
+
+ * WebProcess/WebPage/WebInspector.cpp:
+ (WebKit::WebInspector::sendMessageToFrontend):
+ * WebProcess/WebPage/WebInspector.h:
+
2016-10-26 Eric Carlson <[email protected]>
[MediaStream] Add "has capture device" bit to media state flags
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp (207927 => 207928)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp 2016-10-27 00:17:52 UTC (rev 207928)
@@ -279,7 +279,7 @@
m_page->corePage()->inspectorController().dispatchMessageFromFrontend(message);
}
-bool WebInspector::sendMessageToFrontend(const String& message)
+void WebInspector::sendMessageToFrontend(const String& message)
{
#if ENABLE(INSPECTOR_SERVER)
if (m_remoteFrontendConnected)
@@ -287,7 +287,6 @@
else
#endif
m_frontendConnection->send(Messages::WebInspectorUI::SendMessageToFrontend(message), 0);
- return true;
}
#if ENABLE(INSPECTOR_SERVER)
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h (207927 => 207928)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h 2016-10-26 23:57:13 UTC (rev 207927)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h 2016-10-27 00:17:52 UTC (rev 207928)
@@ -44,7 +44,7 @@
void updateDockingAvailability();
- bool sendMessageToFrontend(const String& message) override;
+ void sendMessageToFrontend(const String& message) override;
ConnectionType connectionType() const override { return ConnectionType::Local; }
// Implemented in generated WebInspectorMessageReceiver.cpp
