Title: [98682] trunk/Tools
- Revision
- 98682
- Author
- [email protected]
- Date
- 2011-10-27 20:47:02 -0700 (Thu, 27 Oct 2011)
Log Message
REGRESSION (r98639): NRWT crashes when parsing leaks output
https://bugs.webkit.org/show_bug.cgi?id=71087
Unreviewed. Sadly we have no good way to test logging.
* Scripts/webkitpy/layout_tests/port/leakdetector.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (98681 => 98682)
--- trunk/Tools/ChangeLog 2011-10-28 02:54:17 UTC (rev 98681)
+++ trunk/Tools/ChangeLog 2011-10-28 03:47:02 UTC (rev 98682)
@@ -1,3 +1,12 @@
+2011-10-27 Eric Seidel <[email protected]>
+
+ REGRESSION (r98639): NRWT crashes when parsing leaks output
+ https://bugs.webkit.org/show_bug.cgi?id=71087
+
+ Unreviewed. Sadly we have no good way to test logging.
+
+ * Scripts/webkitpy/layout_tests/port/leakdetector.py:
+
2011-10-27 David Levin <[email protected]>
Test expectation errors should include the file name and platform in both the log and exception info.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py (98681 => 98682)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py 2011-10-28 02:54:17 UTC (rev 98681)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py 2011-10-28 03:47:02 UTC (rev 98682)
@@ -26,11 +26,14 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+import logging
import re
from webkitpy.common.system.executive import ScriptError
+_log = logging.getLogger(__name__)
+
# If other ports/platforms decide to support --leaks, we should see about sharing as much of this code as possible.
# Right now this code is only used by Apple's MacPort.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
