Diff
Modified: trunk/Tools/ChangeLog (98686 => 98687)
--- trunk/Tools/ChangeLog 2011-10-28 04:44:36 UTC (rev 98686)
+++ trunk/Tools/ChangeLog 2011-10-28 04:55:21 UTC (rev 98687)
@@ -1,3 +1,19 @@
+2011-10-27 Adam Barth <[email protected]>
+
+ Dis-integrate run-bindings-tests with webkitpy
+ https://bugs.webkit.org/show_bug.cgi?id=71092
+
+ Reviewed by Ryosuke Niwa.
+
+ These tests aren't really adding any value.
+
+ * Scripts/webkitpy/common/config/ports.py:
+ * Scripts/webkitpy/tool/commands/download_unittest.py:
+ * Scripts/webkitpy/tool/mocktool.py:
+ * Scripts/webkitpy/tool/steps/runtests.py:
+ * Scripts/webkitpy/tool/steps/runtests_unittest.py:
+ * Scripts/webkitpy/tool/steps/steps_unittest.py:
+
2011-10-27 Eric Seidel <[email protected]>
REGRESSION (r98639): NRWT crashes when parsing leaks output
Modified: trunk/Tools/Scripts/webkitpy/common/config/ports.py (98686 => 98687)
--- trunk/Tools/Scripts/webkitpy/common/config/ports.py 2011-10-28 04:44:36 UTC (rev 98686)
+++ trunk/Tools/Scripts/webkitpy/common/config/ports.py 2011-10-28 04:55:21 UTC (rev 98687)
@@ -117,10 +117,6 @@
return cls.script_shell_command("test-webkitperl")
@classmethod
- def run_bindings_tests_command(cls):
- return cls.script_shell_command("run-bindings-tests")
-
- @classmethod
def layout_tests_results_path(cls):
return "/tmp/layout-test-results/results.html"
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py (98686 => 98687)
--- trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2011-10-28 04:44:36 UTC (rev 98686)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2011-10-28 04:55:21 UTC (rev 98687)
@@ -89,7 +89,7 @@
self.assert_execute_outputs(Build(), [], options=self._default_options(), expected_stderr=expected_stderr)
def test_build_and_test(self):
- expected_stderr = "Updating working directory\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\n"
+ expected_stderr = "Updating working directory\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\n"
self.assert_execute_outputs(BuildAndTest(), [], options=self._default_options(), expected_stderr=expected_stderr)
def test_apply_attachment(self):
@@ -115,7 +115,7 @@
self.assert_execute_outputs(ApplyWatchList(), [10000], options=self._default_options(), expected_stderr=expected_stderr, tool=MockTool(log_executive=True))
def test_land(self):
- expected_stderr = "Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 50000\n"
+ expected_stderr = "Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 50000\n"
mock_tool = MockTool()
mock_tool.scm().create_patch = Mock(return_value="Patch1\nMockPatch\n")
mock_tool.checkout().modified_changelogs = Mock(return_value=[])
@@ -136,8 +136,6 @@
MOCK run_and_throw_if_fail: ['mock-test-webkitpy'], cwd=/mock-checkout
Running Perl unit tests
MOCK run_and_throw_if_fail: ['mock-test-webkitperl'], cwd=/mock-checkout
-Running Bindings tests
-MOCK run_and_throw_if_fail: ['mock-run-bindings-tests'], cwd=/mock-checkout
Running _javascript_Core tests
MOCK run_and_throw_if_fail: ['mock-run-javacriptcore-tests'], cwd=/mock-checkout
Running run-webkit-tests
@@ -150,7 +148,7 @@
self.assert_execute_outputs(LandCowboy(), [50000], options=self._default_options(), expected_stderr=expected_stderr, tool=mock_tool)
def test_land_red_builders(self):
- expected_stderr = 'Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 50000\n'
+ expected_stderr = 'Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 50000\n'
mock_tool = MockTool()
mock_tool.buildbot.light_tree_on_fire()
self.assert_execute_outputs(Land(), [50000], options=self._default_options(), expected_stderr=expected_stderr, tool=mock_tool)
@@ -176,7 +174,6 @@
Building WebKit
Running Python unit tests
Running Perl unit tests
-Running Bindings tests
Running _javascript_Core tests
Running run-webkit-tests
Committed r49824: <http://trac.webkit.org/changeset/49824>
@@ -193,7 +190,6 @@
Building WebKit
Running Python unit tests
Running Perl unit tests
-Running Bindings tests
Running _javascript_Core tests
Running run-webkit-tests
Committed r49824: <http://trac.webkit.org/changeset/49824>
@@ -203,7 +199,6 @@
Building WebKit
Running Python unit tests
Running Perl unit tests
-Running Bindings tests
Running _javascript_Core tests
Running run-webkit-tests
Committed r49824: <http://trac.webkit.org/changeset/49824>
Modified: trunk/Tools/Scripts/webkitpy/tool/mocktool.py (98686 => 98687)
--- trunk/Tools/Scripts/webkitpy/tool/mocktool.py 2011-10-28 04:44:36 UTC (rev 98686)
+++ trunk/Tools/Scripts/webkitpy/tool/mocktool.py 2011-10-28 04:55:21 UTC (rev 98687)
@@ -784,9 +784,6 @@
def build_webkit_command(self, build_style=None):
return ["mock-build-webkit"]
- def run_bindings_tests_command(self):
- return ["mock-run-bindings-tests"]
-
def prepare_changelog_command(self):
return ['mock-prepare-ChangeLog']
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py (98686 => 98687)
--- trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2011-10-28 04:44:36 UTC (rev 98686)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2011-10-28 04:55:21 UTC (rev 98687)
@@ -56,11 +56,6 @@
log("Running Perl unit tests")
self._tool.executive.run_and_throw_if_fail(perl_unittests_command, cwd=self._tool.scm().checkout_root)
- bindings_tests_command = self._tool.port().run_bindings_tests_command()
- if bindings_tests_command:
- log("Running Bindings tests")
- self._tool.executive.run_and_throw_if_fail(bindings_tests_command, cwd=self._tool.scm().checkout_root)
-
_javascript_core_tests_command = self._tool.port().run_javascriptcore_tests_command()
if _javascript_core_tests_command:
log("Running _javascript_Core tests")
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py (98686 => 98687)
--- trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py 2011-10-28 04:44:36 UTC (rev 98686)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py 2011-10-28 04:55:21 UTC (rev 98687)
@@ -38,8 +38,7 @@
tool._port.run_python_unittests_command = lambda: None
tool._port.run_perl_unittests_command = lambda: None
step = RunTests(tool, MockOptions(test=True, non_interactive=True, quiet=False))
- expected_stderr = """Running Bindings tests
-Running _javascript_Core tests
+ expected_stderr = """Running _javascript_Core tests
Running run-webkit-tests
"""
OutputCapture().assert_outputs(self, step.run, [{}], expected_stderr=expected_stderr)
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py (98686 => 98687)
--- trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py 2011-10-28 04:44:36 UTC (rev 98686)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py 2011-10-28 04:55:21 UTC (rev 98687)
@@ -79,8 +79,6 @@
MOCK run_and_throw_if_fail: ['Tools/Scripts/test-webkitpy'], cwd=/mock-checkout
Running Perl unit tests
MOCK run_and_throw_if_fail: ['Tools/Scripts/test-webkitperl'], cwd=/mock-checkout
-Running Bindings tests
-MOCK run_and_throw_if_fail: ['Tools/Scripts/run-bindings-tests'], cwd=/mock-checkout
Running _javascript_Core tests
MOCK run_and_throw_if_fail: ['Tools/Scripts/run-_javascript_core-tests'], cwd=/mock-checkout
Running run-webkit-tests
