Title: [208039] trunk
- Revision
- 208039
- Author
- commit-qu...@webkit.org
- Date
- 2016-10-27 23:27:29 -0700 (Thu, 27 Oct 2016)
Log Message
[Fetch API] Fetch ReadableStream should only clone the second branch
https://bugs.webkit.org/show_bug.cgi?id=164058
Patch by Youenn Fablet <you...@apple.com> on 2016-10-27
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
* web-platform-tests/fetch/api/response/response-clone-expected.txt:
Source/WebCore:
Covered by rebased tests.
* Modules/streams/ReadableStreamInternals.js:
(readableStreamTeePullFunction):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (208038 => 208039)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-10-28 06:12:10 UTC (rev 208038)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-10-28 06:27:29 UTC (rev 208039)
@@ -1,3 +1,12 @@
+2016-10-27 Youenn Fablet <you...@apple.com>
+
+ [Fetch API] Fetch ReadableStream should only clone the second branch
+ https://bugs.webkit.org/show_bug.cgi?id=164058
+
+ Reviewed by Darin Adler.
+
+ * web-platform-tests/fetch/api/response/response-clone-expected.txt:
+
2016-10-27 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Include ConsoleAgent in Workers - real console.log support
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-clone-expected.txt (208038 => 208039)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-clone-expected.txt 2016-10-28 06:12:10 UTC (rev 208038)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-clone-expected.txt 2016-10-28 06:27:29 UTC (rev 208039)
@@ -6,15 +6,15 @@
PASS Cannot clone a disturbed response
PASS Cloned responses should provide the same data
PASS Cancelling stream should not affect cloned one
-FAIL Check response clone use structureClone for teed ReadableStreams (Int8Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Int16Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Int32Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (ArrayBufferchunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Uint8Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Uint8ClampedArraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Uint16Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Uint32Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Float32Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Float64Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (DataViewchunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
+PASS Check response clone use structureClone for teed ReadableStreams (Int8Arraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (Int16Arraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (Int32Arraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (ArrayBufferchunk)
+PASS Check response clone use structureClone for teed ReadableStreams (Uint8Arraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (Uint8ClampedArraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (Uint16Arraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (Uint32Arraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (Float32Arraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (Float64Arraychunk)
+PASS Check response clone use structureClone for teed ReadableStreams (DataViewchunk)
Modified: trunk/Source/WebCore/ChangeLog (208038 => 208039)
--- trunk/Source/WebCore/ChangeLog 2016-10-28 06:12:10 UTC (rev 208038)
+++ trunk/Source/WebCore/ChangeLog 2016-10-28 06:27:29 UTC (rev 208039)
@@ -1,3 +1,15 @@
+2016-10-27 Youenn Fablet <you...@apple.com>
+
+ [Fetch API] Fetch ReadableStream should only clone the second branch
+ https://bugs.webkit.org/show_bug.cgi?id=164058
+
+ Reviewed by Darin Adler.
+
+ Covered by rebased tests.
+
+ * Modules/streams/ReadableStreamInternals.js:
+ (readableStreamTeePullFunction):
+
2016-10-27 Alex Christensen <achristen...@webkit.org>
Update ANGLE
Modified: trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js (208038 => 208039)
--- trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js 2016-10-28 06:12:10 UTC (rev 208038)
+++ trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js 2016-10-28 06:27:29 UTC (rev 208039)
@@ -183,7 +183,7 @@
if (teeState.closedOrErrored)
return;
if (!teeState.canceled1)
- @readableStreamDefaultControllerEnqueue(teeState.branch1.@readableStreamController, shouldClone ? @doStructuredClone(result.value) : result.value);
+ @readableStreamDefaultControllerEnqueue(teeState.branch1.@readableStreamController, result.value);
if (!teeState.canceled2)
@readableStreamDefaultControllerEnqueue(teeState.branch2.@readableStreamController, shouldClone ? @doStructuredClone(result.value) : result.value);
});
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
