Title: [208048] trunk/Source/WebKit2
- Revision
- 208048
- Author
- [email protected]
- Date
- 2016-10-28 08:11:21 -0700 (Fri, 28 Oct 2016)
Log Message
Enable CFNetwork connection cache fast lane for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=164129
Reviewed by Andreas Kling.
The idea of this feature is keep a connection free for higher priority requests so low-priority
image loads can't take all the available connections.
We have this enabled on WK1 but not on WK2. See what enabling it does for performance in bots.
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::initializeNetworkSettings):
Based on code inspection setting kHTTPMinimumFastLanePriority is not sufficient to enable this feature,
kHTTPNumFastLanes needs also be set to a non-zero value. Use the same constants as WK1.
Also enable this on Mac to unify behavior.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (208047 => 208048)
--- trunk/Source/WebKit2/ChangeLog 2016-10-28 14:21:04 UTC (rev 208047)
+++ trunk/Source/WebKit2/ChangeLog 2016-10-28 15:11:21 UTC (rev 208048)
@@ -1,3 +1,22 @@
+2016-10-28 Antti Koivisto <[email protected]>
+
+ Enable CFNetwork connection cache fast lane for WebKit2
+ https://bugs.webkit.org/show_bug.cgi?id=164129
+
+ Reviewed by Andreas Kling.
+
+ The idea of this feature is keep a connection free for higher priority requests so low-priority
+ image loads can't take all the available connections.
+
+ We have this enabled on WK1 but not on WK2. See what enabling it does for performance in bots.
+
+ * NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+ (WebKit::initializeNetworkSettings):
+
+ Based on code inspection setting kHTTPMinimumFastLanePriority is not sufficient to enable this feature,
+ kHTTPNumFastLanes needs also be set to a non-zero value. Use the same constants as WK1.
+ Also enable this on Mac to unify behavior.
+
2016-10-27 Michael Catanzaro <[email protected]>
[GTK] New stable DOM API headers should be included from webkitdom.h
Modified: trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm (208047 => 208048)
--- trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2016-10-28 14:21:04 UTC (rev 208047)
+++ trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2016-10-28 15:11:21 UTC (rev 208048)
@@ -60,10 +60,11 @@
WebCore::ResourceRequest::setHTTPPipeliningEnabled(prefValue);
if (WebCore::ResourceRequest::resourcePrioritiesEnabled()) {
+ const unsigned fastLaneConnectionCount = 1;
+
_CFNetworkHTTPConnectionCacheSetLimit(kHTTPPriorityNumLevels, toPlatformRequestPriority(WebCore::ResourceLoadPriority::Highest));
-#if PLATFORM(IOS)
_CFNetworkHTTPConnectionCacheSetLimit(kHTTPMinimumFastLanePriority, toPlatformRequestPriority(WebCore::ResourceLoadPriority::Medium));
-#endif
+ _CFNetworkHTTPConnectionCacheSetLimit(kHTTPNumFastLanes, fastLaneConnectionCount);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
