Title: [98693] trunk/Tools
- Revision
- 98693
- Author
- [email protected]
- Date
- 2011-10-27 22:39:13 -0700 (Thu, 27 Oct 2011)
Log Message
WebSocket: Connecting to localhost:8880 takes one second on Windows
https://bugs.webkit.org/show_bug.cgi?id=64788
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/servers/websocket_server.py:
Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
from timing out on Windows, because this test tries to open a lot of
connections to localhost and each attempt takes one second to fall back from
IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (98692 => 98693)
--- trunk/Tools/ChangeLog 2011-10-28 05:37:32 UTC (rev 98692)
+++ trunk/Tools/ChangeLog 2011-10-28 05:39:13 UTC (rev 98693)
@@ -1,3 +1,17 @@
+2011-10-27 Yuta Kitamura <[email protected]>
+
+ WebSocket: Connecting to localhost:8880 takes one second on Windows
+ https://bugs.webkit.org/show_bug.cgi?id=64788
+
+ Reviewed by Dirk Pranke.
+
+ * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
+ Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
+ IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
+ from timing out on Windows, because this test tries to open a lot of
+ connections to localhost and each attempt takes one second to fall back from
+ IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
+
2011-10-27 Adam Barth <[email protected]>
Dis-integrate run-bindings-tests with webkitpy
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py (98692 => 98693)
--- trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py 2011-10-28 05:37:32 UTC (rev 98692)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py 2011-10-28 05:39:13 UTC (rev 98693)
@@ -117,7 +117,7 @@
pywebsocket_script = self._filesystem.join(pywebsocket_base, 'mod_pywebsocket', 'standalone.py')
start_cmd = [
python_interp, '-u', pywebsocket_script,
- '--server-host', '127.0.0.1',
+ '--server-host', 'localhost',
'--port', str(self._port),
# FIXME: Don't we have a self._port_obj.layout_test_path?
'--document-root', self._filesystem.join(self._layout_tests, 'http', 'tests'),
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
