Title: [208241] trunk/Source/WebCore
- Revision
- 208241
- Author
- [email protected]
- Date
- 2016-11-01 14:43:12 -0700 (Tue, 01 Nov 2016)
Log Message
ShowRenderTree: Add information about the type of the needsLayout bit.
https://bugs.webkit.org/show_bug.cgi?id=164287
Reviewed by Simon Fraser.
Currently showRenderTree only tells you whether a renderer's "needs layout bit" is set or not.
With certain type of layout bugs, it's essential to know the kind of layout a particular
renderer needs.
This patch extends the renderer output by listing all the layout bits set.
B------- -+ BODY RenderBody (0.00, 0.00) (0.00, 0.00) renderer->(0x) node->(0x) layout->[self][normal child]
Not testable.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::showRenderObject):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (208240 => 208241)
--- trunk/Source/WebCore/ChangeLog 2016-11-01 21:42:51 UTC (rev 208240)
+++ trunk/Source/WebCore/ChangeLog 2016-11-01 21:43:12 UTC (rev 208241)
@@ -1,3 +1,22 @@
+2016-11-01 Zalan Bujtas <[email protected]>
+
+ ShowRenderTree: Add information about the type of the needsLayout bit.
+ https://bugs.webkit.org/show_bug.cgi?id=164287
+
+ Reviewed by Simon Fraser.
+
+ Currently showRenderTree only tells you whether a renderer's "needs layout bit" is set or not.
+ With certain type of layout bugs, it's essential to know the kind of layout a particular
+ renderer needs.
+ This patch extends the renderer output by listing all the layout bits set.
+
+ B------- -+ BODY RenderBody (0.00, 0.00) (0.00, 0.00) renderer->(0x) node->(0x) layout->[self][normal child]
+
+ Not testable.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::showRenderObject):
+
2016-11-01 Joseph Pecoraro <[email protected]>
Web Inspector: Use more references in inspector code
Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (208240 => 208241)
--- trunk/Source/WebCore/rendering/RenderObject.cpp 2016-11-01 21:42:51 UTC (rev 208240)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2016-11-01 21:43:12 UTC (rev 208241)
@@ -1129,6 +1129,19 @@
fprintf(stderr, " continuation->(%p)", renderer.continuation());
}
showRegionsInformation();
+ if (needsLayout()) {
+ fprintf(stderr, " layout->");
+ if (selfNeedsLayout())
+ fprintf(stderr, "[self]");
+ if (normalChildNeedsLayout())
+ fprintf(stderr, "[normal child]");
+ if (posChildNeedsLayout())
+ fprintf(stderr, "[positioned child]");
+ if (needsSimplifiedNormalFlowLayout())
+ fprintf(stderr, "[simplified]");
+ if (needsPositionedMovementLayout())
+ fprintf(stderr, "[positioned movement]");
+ }
fprintf(stderr, "\n");
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
