[webkit-changes] [208387] trunk/Tools

[beidson]

Title: [208387] trunk/Tools

Revision

208387

Author

beid...@apple.com

Date

2016-11-04 11:02:32 -0700 (Fri, 04 Nov 2016)

Log Message

REGRESSION (r208349) StringHasher::hashMemory behavior changed, causing API tests to fail
https://bugs.webkit.org/show_bug.cgi?id=164390

Reviewed by Geoffrey Garen.

Operating under the assumption that the behavior change is okay/desirable, this updates the test.

* TestWebKitAPI/Tests/WTF/StringHasher.cpp:
(TestWebKitAPI::TEST):

Modified Paths

• trunk/Tools/ChangeLog
• trunk/Tools/TestWebKitAPI/Tests/WTF/StringHasher.cpp

Diff

Modified: trunk/Tools/ChangeLog (208386 => 208387)

--- trunk/Tools/ChangeLog	2016-11-04 18:02:02 UTC (rev 208386)
+++ trunk/Tools/ChangeLog	2016-11-04 18:02:32 UTC (rev 208387)
@@ -1,3 +1,15 @@
+2016-11-04  Brady Eidson  <beid...@apple.com>
+
+        REGRESSION (r208349) StringHasher::hashMemory behavior changed, causing API tests to fail
+        https://bugs.webkit.org/show_bug.cgi?id=164390
+
+        Reviewed by Geoffrey Garen.
+
+        Operating under the assumption that the behavior change is okay/desirable, this updates the test.
+
+        * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
+        (TestWebKitAPI::TEST):
+
 2016-11-04  Joanmarie Diggs  <jdi...@igalia.com>
 
         AX: [ATK] Attempting to clear selection on ARIA listboxes results in crash

Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/StringHasher.cpp (208386 => 208387)

--- trunk/Tools/TestWebKitAPI/Tests/WTF/StringHasher.cpp	2016-11-04 18:02:02 UTC (rev 208386)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/StringHasher.cpp	2016-11-04 18:02:32 UTC (rev 208387)
@@ -427,18 +427,18 @@
 
 TEST(WTF, StringHasher_hashMemory)
 {
-    ASSERT_EQ(emptyStringHash & 0xFFFFFF, StringHasher::hashMemory(0, 0));
-    ASSERT_EQ(emptyStringHash & 0xFFFFFF, StringHasher::hashMemory(nullUChars, 0));
-    ASSERT_EQ(emptyStringHash & 0xFFFFFF, StringHasher::hashMemory<0>(0));
-    ASSERT_EQ(emptyStringHash & 0xFFFFFF, StringHasher::hashMemory<0>(nullUChars));
+    ASSERT_EQ(emptyStringHash, StringHasher::hashMemory(0, 0));
+    ASSERT_EQ(emptyStringHash, StringHasher::hashMemory(nullUChars, 0));
+    ASSERT_EQ(emptyStringHash, StringHasher::hashMemory<0>(0));
+    ASSERT_EQ(emptyStringHash, StringHasher::hashMemory<0>(nullUChars));
 
-    ASSERT_EQ(singleNullCharacterHash & 0xFFFFFF, StringHasher::hashMemory(nullUChars, 2));
-    ASSERT_EQ(singleNullCharacterHash & 0xFFFFFF, StringHasher::hashMemory<2>(nullUChars));
+    ASSERT_EQ(singleNullCharacterHash, StringHasher::hashMemory(nullUChars, 2));
+    ASSERT_EQ(singleNullCharacterHash, StringHasher::hashMemory<2>(nullUChars));
 
-    ASSERT_EQ(testAHash5 & 0xFFFFFF, StringHasher::hashMemory(testAUChars, 10));
-    ASSERT_EQ(testAHash5 & 0xFFFFFF, StringHasher::hashMemory<10>(testAUChars));
-    ASSERT_EQ(testBHash5 & 0xFFFFFF, StringHasher::hashMemory(testBUChars, 10));
-    ASSERT_EQ(testBHash5 & 0xFFFFFF, StringHasher::hashMemory<10>(testBUChars));
+    ASSERT_EQ(testAHash5, StringHasher::hashMemory(testAUChars, 10));
+    ASSERT_EQ(testAHash5, StringHasher::hashMemory<10>(testAUChars));
+    ASSERT_EQ(testBHash5, StringHasher::hashMemory(testBUChars, 10));
+    ASSERT_EQ(testBHash5, StringHasher::hashMemory<10>(testBUChars));
 }
 
 } // namespace TestWebKitAPI

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes