Title: [208416] trunk
- Revision
- 208416
- Author
- [email protected]
- Date
- 2016-11-05 00:56:49 -0700 (Sat, 05 Nov 2016)
Log Message
[SOUP] Layout test http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html fails
https://bugs.webkit.org/show_bug.cgi?id=139358
Reviewed by Michael Catanzaro.
Source/WebKit2:
Stop putting the credentials in the URL unconditionally and ensure we only do that when provided by the URL
itself. Libsoup has its own cache of SoupAuth, so we don't need to pass user/pass in the URL for every single
request, libsoup will authenticate those automatically.
* NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::applyAuthenticationToRequest):
LayoutTests:
* platform/gtk/TestExpectations: Unskip http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (208415 => 208416)
--- trunk/LayoutTests/ChangeLog 2016-11-05 03:02:39 UTC (rev 208415)
+++ trunk/LayoutTests/ChangeLog 2016-11-05 07:56:49 UTC (rev 208416)
@@ -1,3 +1,12 @@
+2016-11-05 Carlos Garcia Campos <[email protected]>
+
+ [SOUP] Layout test http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=139358
+
+ Reviewed by Michael Catanzaro.
+
+ * platform/gtk/TestExpectations: Unskip http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html.
+
2016-11-04 Yusuke Suzuki <[email protected]>
[DOMJIT] Add DOMJIT::Signature annotation to Document::getElementById
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (208415 => 208416)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2016-11-05 03:02:39 UTC (rev 208415)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2016-11-05 07:56:49 UTC (rev 208416)
@@ -2343,8 +2343,6 @@
webkit.org/b/139354 fast/repaint/selection-ruby-rl.html [ Failure ]
-webkit.org/b/139358 http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html [ Failure ]
-
webkit.org/b/139361 fast/css/data-attribute-style-sharing-5.html [ ImageOnlyFailure ]
webkit.org/b/139361 fast/css/data-attribute-style-sharing-6.html [ ImageOnlyFailure ]
webkit.org/b/139361 fast/css/data-attribute-style-sharing-7.html [ ImageOnlyFailure ]
Modified: trunk/Source/WebKit2/ChangeLog (208415 => 208416)
--- trunk/Source/WebKit2/ChangeLog 2016-11-05 03:02:39 UTC (rev 208415)
+++ trunk/Source/WebKit2/ChangeLog 2016-11-05 07:56:49 UTC (rev 208416)
@@ -1,3 +1,17 @@
+2016-11-05 Carlos Garcia Campos <[email protected]>
+
+ [SOUP] Layout test http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=139358
+
+ Reviewed by Michael Catanzaro.
+
+ Stop putting the credentials in the URL unconditionally and ensure we only do that when provided by the URL
+ itself. Libsoup has its own cache of SoupAuth, so we don't need to pass user/pass in the URL for every single
+ request, libsoup will authenticate those automatically.
+
+ * NetworkProcess/soup/NetworkDataTaskSoup.cpp:
+ (WebKit::NetworkDataTaskSoup::applyAuthenticationToRequest):
+
2016-11-04 Filip Pizlo <[email protected]>
WTF::ParkingLot should stop using std::chrono because std::chrono::duration casts are prone to overflows
Modified: trunk/Source/WebKit2/NetworkProcess/soup/NetworkDataTaskSoup.cpp (208415 => 208416)
--- trunk/Source/WebKit2/NetworkProcess/soup/NetworkDataTaskSoup.cpp 2016-11-05 03:02:39 UTC (rev 208415)
+++ trunk/Source/WebKit2/NetworkProcess/soup/NetworkDataTaskSoup.cpp 2016-11-05 07:56:49 UTC (rev 208416)
@@ -405,22 +405,16 @@
void NetworkDataTaskSoup::applyAuthenticationToRequest(ResourceRequest& request)
{
- // We always put the credentials into the URL. In the Coca port HTTP family credentials are applied in
- // the didReceiveChallenge callback, but libsoup requires us to use this method to override
- // any previously remembered credentials. It has its own per-session credential storage.
+ if (m_user.isEmpty() && m_password.isEmpty())
+ return;
+
auto url = ""
- if (!m_initialCredential.isEmpty()) {
- url.setUser(m_initialCredential.user());
- url.setPass(m_initialCredential.password());
- } else {
- url.setUser(m_user);
- url.setPass(m_password);
- }
+ url.setUser(m_user);
+ url.setPass(m_password);
+ request.setURL(url);
m_user = String();
m_password = String();
-
- request.setURL(url);
}
void NetworkDataTaskSoup::authenticateCallback(SoupSession* session, SoupMessage* soupMessage, SoupAuth* soupAuth, gboolean retrying, NetworkDataTaskSoup* task)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
