Title: [208427] trunk/Source/_javascript_Core
- Revision
- 208427
- Author
- [email protected]
- Date
- 2016-11-08 18:51:19 -0800 (Tue, 08 Nov 2016)
Log Message
REGRESSION: date-format-tofte.js is super slow
https://bugs.webkit.org/show_bug.cgi?id=164499
Patch by Geoffrey Garen <[email protected]> on 2016-11-08
Reviewed by Sam Weinig.
* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::CacheKey::operator==): Use character comparison,
not pointer comparison. (This function was always wrong, but I started
calling it in more places.)
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (208426 => 208427)
--- trunk/Source/_javascript_Core/ChangeLog 2016-11-09 02:50:05 UTC (rev 208426)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-11-09 02:51:19 UTC (rev 208427)
@@ -1,3 +1,15 @@
+2016-11-08 Geoffrey Garen <[email protected]>
+
+ REGRESSION: date-format-tofte.js is super slow
+ https://bugs.webkit.org/show_bug.cgi?id=164499
+
+ Reviewed by Sam Weinig.
+
+ * bytecode/EvalCodeCache.h:
+ (JSC::EvalCodeCache::CacheKey::operator==): Use character comparison,
+ not pointer comparison. (This function was always wrong, but I started
+ calling it in more places.)
+
2016-11-08 Saam Barati <[email protected]>
REGRESSION: Crashes in StringImpl destructor during GC when clearing the HasOwnPropertyCache
Modified: trunk/Source/_javascript_Core/bytecode/EvalCodeCache.h (208426 => 208427)
--- trunk/Source/_javascript_Core/bytecode/EvalCodeCache.h 2016-11-09 02:50:05 UTC (rev 208426)
+++ trunk/Source/_javascript_Core/bytecode/EvalCodeCache.h 2016-11-09 02:51:19 UTC (rev 208427)
@@ -66,7 +66,7 @@
bool operator==(const CacheKey& other) const
{
- return m_callSiteIndex == other.m_callSiteIndex && m_source == other.m_source;
+ return m_callSiteIndex == other.m_callSiteIndex && WTF::equal(m_source.get(), other.m_source.get());
}
bool isHashTableDeletedValue() const { return m_source.isHashTableDeletedValue(); }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
