Title: [208443] trunk/Source/WebInspectorUI
Revision
208443
Author
[email protected]
Date
2016-11-09 10:26:04 -0800 (Wed, 09 Nov 2016)

Log Message

Web Inspector: Settings tab: Checkbox labels should be clickable
https://bugs.webkit.org/show_bug.cgi?id=164470
<rdar://problem/29133787>

Reviewed by Matt Baker.

* UserInterface/Views/SettingsTabContentView.js:
(WebInspector.SettingsTabContentView.prototype.initialLayout):
Add a label element to make checkboxes clickable.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (208442 => 208443)


--- trunk/Source/WebInspectorUI/ChangeLog	2016-11-09 18:25:42 UTC (rev 208442)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-11-09 18:26:04 UTC (rev 208443)
@@ -1,3 +1,15 @@
+2016-11-09  Nikita Vasilyev  <[email protected]>
+
+        Web Inspector: Settings tab: Checkbox labels should be clickable
+        https://bugs.webkit.org/show_bug.cgi?id=164470
+        <rdar://problem/29133787>
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/SettingsTabContentView.js:
+        (WebInspector.SettingsTabContentView.prototype.initialLayout):
+        Add a label element to make checkboxes clickable.
+
 2016-11-09  Devin Rousso  <[email protected]>
 
         Web Inspector: Allow FolderTreeElement to display content when selected

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (208442 => 208443)


--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js	2016-11-09 18:25:42 UTC (rev 208442)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js	2016-11-09 18:26:04 UTC (rev 208443)
@@ -73,8 +73,9 @@
             titleContainer.textContent = title;
 
             let valueControllerContainer = container.createChild("div", "setting-value-controller");
+            let labelElement = valueControllerContainer.createChild("label");
             if (typeof createValueController === "function")
-                createValueController(valueControllerContainer);
+                createValueController(labelElement);
         };
 
         let createCheckbox = (setting) => {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to