Title: [208487] trunk/Source/WebCore
- Revision
- 208487
- Author
- [email protected]
- Date
- 2016-11-09 14:25:07 -0800 (Wed, 09 Nov 2016)
Log Message
No need to set setFlowThreadState on RenderText in createTextRenderer.
https://bugs.webkit.org/show_bug.cgi?id=164559
Reviewed by Antti Koivisto.
setFlowThreadState in create*Renderer ensures that by the time we issue the initial call to
styleWillChange/styleDidChange through initializeStyle, the state is already set.
However since RenderText does not have its own style, it's sufficient to have the flow state set
through the normal RenderElement::insertChildInternal code path.
No change in functionality.
* style/RenderTreeUpdater.cpp:
(WebCore::createTextRenderer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (208486 => 208487)
--- trunk/Source/WebCore/ChangeLog 2016-11-09 22:24:49 UTC (rev 208486)
+++ trunk/Source/WebCore/ChangeLog 2016-11-09 22:25:07 UTC (rev 208487)
@@ -1,3 +1,20 @@
+2016-11-09 Zalan Bujtas <[email protected]>
+
+ No need to set setFlowThreadState on RenderText in createTextRenderer.
+ https://bugs.webkit.org/show_bug.cgi?id=164559
+
+ Reviewed by Antti Koivisto.
+
+ setFlowThreadState in create*Renderer ensures that by the time we issue the initial call to
+ styleWillChange/styleDidChange through initializeStyle, the state is already set.
+ However since RenderText does not have its own style, it's sufficient to have the flow state set
+ through the normal RenderElement::insertChildInternal code path.
+
+ No change in functionality.
+
+ * style/RenderTreeUpdater.cpp:
+ (WebCore::createTextRenderer):
+
2016-11-09 Brady Eidson <[email protected]>
IndexedDB 2.0: Encapsulate cursor iteration parameters for easy future expansion.
Modified: trunk/Source/WebCore/style/RenderTreeUpdater.cpp (208486 => 208487)
--- trunk/Source/WebCore/style/RenderTreeUpdater.cpp 2016-11-09 22:24:49 UTC (rev 208486)
+++ trunk/Source/WebCore/style/RenderTreeUpdater.cpp 2016-11-09 22:25:07 UTC (rev 208487)
@@ -429,10 +429,6 @@
if (!renderTreePosition.canInsert(*newRenderer))
return;
- // Make sure the RenderObject already knows it is going to be added to a RenderFlowThread before we set the style
- // for the first time. Otherwise code using inRenderFlowThread() in the styleWillChange and styleDidChange will fail.
- newRenderer->setFlowThreadState(renderTreePosition.parent().flowThreadState());
-
textNode.setRenderer(newRenderer.get());
renderTreePosition.insert(*newRenderer.leakPtr());
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes