Title: [208514] trunk/Source/_javascript_Core
- Revision
- 208514
- Author
- [email protected]
- Date
- 2016-11-09 17:22:10 -0800 (Wed, 09 Nov 2016)
Log Message
jsc CLI should work with the remote inspector
https://bugs.webkit.org/show_bug.cgi?id=164569
Reviewed by Joseph Pecoraro.
This patch enables using the remote inspector on the jsc CLI.
In order to use the remote inspector, jsc users need to pass an option.
* jsc.cpp:
(CommandLine::parseArguments):
(runJSC):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (208513 => 208514)
--- trunk/Source/_javascript_Core/ChangeLog 2016-11-10 01:21:56 UTC (rev 208513)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-11-10 01:22:10 UTC (rev 208514)
@@ -1,3 +1,17 @@
+2016-11-09 Keith Miller <[email protected]>
+
+ jsc CLI should work with the remote inspector
+ https://bugs.webkit.org/show_bug.cgi?id=164569
+
+ Reviewed by Joseph Pecoraro.
+
+ This patch enables using the remote inspector on the jsc CLI.
+ In order to use the remote inspector, jsc users need to pass an option.
+
+ * jsc.cpp:
+ (CommandLine::parseArguments):
+ (runJSC):
+
2016-11-09 Saam Barati <[email protected]>
Math.min()/Math.max() with no arguments is lowered incorrectly in the BytecodeParser
Modified: trunk/Source/_javascript_Core/jsc.cpp (208513 => 208514)
--- trunk/Source/_javascript_Core/jsc.cpp 2016-11-10 01:21:56 UTC (rev 208513)
+++ trunk/Source/_javascript_Core/jsc.cpp 2016-11-10 01:22:10 UTC (rev 208514)
@@ -966,6 +966,7 @@
String m_uncaughtExceptionName;
bool m_alwaysDumpUncaughtException { false };
bool m_dumpSamplingProfilerData { false };
+ bool m_enableRemoteDebugging { false };
void parseArguments(int, char**);
};
@@ -2784,6 +2785,11 @@
continue;
}
+ if (!strcmp(arg, "--remote-debug")) {
+ m_enableRemoteDebugging = true;
+ continue;
+ }
+
static const unsigned strictFileStrLength = strlen("--strict-file=");
if (!strncmp(arg, "--strict-file=", strictFileStrLength)) {
m_scripts.append(Script(Script::StrictMode::Strict, Script::CodeSource::File, Script::ScriptType::Script, argv[i] + strictFileStrLength));
@@ -2851,6 +2857,7 @@
vm->m_perBytecodeProfiler = std::make_unique<Profiler::Database>(*vm);
GlobalObject* globalObject = GlobalObject::create(*vm, GlobalObject::createStructure(*vm, jsNull()), options.m_arguments);
+ globalObject->setRemoteDebuggingEnabled(options.m_enableRemoteDebugging);
bool success = runWithScripts(globalObject, options.m_scripts, options.m_uncaughtExceptionName, options.m_alwaysDumpUncaughtException, options.m_dump, options.m_module);
if (options.m_interactive && success)
runInteractive(globalObject);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes