Title: [208528] trunk/Source/WebKit2
Revision
208528
Author
[email protected]
Date
2016-11-10 00:01:10 -0800 (Thu, 10 Nov 2016)

Log Message

[WK2][GTK][GStreamer] Build fails when -plugins-base and -core headers are not installed in the same directory
https://bugs.webkit.org/show_bug.cgi?id=148894

Reviewed by Carlos Garcia Campos.

The pbutils (gst-plugins-base-utils) headers are needed in
WebKit2/GTK for the permission request API related with the
GStreamer codec installer. It builds fine in most cases without
explicitely requiring the pbutils include directory path because
usually all the GStreamer headers are installed in the same path,
excepted for some distributions, like NixOS.

* PlatformGTK.cmake: The GStreamer pbutils include directory was
missing in the header search path.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (208527 => 208528)


--- trunk/Source/WebKit2/ChangeLog	2016-11-10 07:53:34 UTC (rev 208527)
+++ trunk/Source/WebKit2/ChangeLog	2016-11-10 08:01:10 UTC (rev 208528)
@@ -1,3 +1,20 @@
+2016-11-10  Philippe Normand  <[email protected]>
+
+        [WK2][GTK][GStreamer] Build fails when -plugins-base and -core headers are not installed in the same directory
+        https://bugs.webkit.org/show_bug.cgi?id=148894
+
+        Reviewed by Carlos Garcia Campos.
+
+        The pbutils (gst-plugins-base-utils) headers are needed in
+        WebKit2/GTK for the permission request API related with the
+        GStreamer codec installer. It builds fine in most cases without
+        explicitely requiring the pbutils include directory path because
+        usually all the GStreamer headers are installed in the same path,
+        excepted for some distributions, like NixOS.
+
+        * PlatformGTK.cmake: The GStreamer pbutils include directory was
+        missing in the header search path.
+
 2016-11-09  Chris Dumez  <[email protected]>
 
         [WK2][!NETWORK_SESSION] Add support for downloading file backed blobs

Modified: trunk/Source/WebKit2/PlatformGTK.cmake (208527 => 208528)


--- trunk/Source/WebKit2/PlatformGTK.cmake	2016-11-10 07:53:34 UTC (rev 208527)
+++ trunk/Source/WebKit2/PlatformGTK.cmake	2016-11-10 08:01:10 UTC (rev 208528)
@@ -885,6 +885,7 @@
     ${ENCHANT_INCLUDE_DIRS}
     ${GEOCLUE_INCLUDE_DIRS}
     ${GSTREAMER_INCLUDE_DIRS}
+    ${GSTREAMER_PBUTILS_INCLUDE_DIRS}
     ${HARFBUZZ_INCLUDE_DIRS}
     ${LIBSOUP_INCLUDE_DIRS}
 )
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to