Title: [208569] trunk
Revision
208569
Author
cdu...@apple.com
Date
2016-11-10 15:59:42 -0800 (Thu, 10 Nov 2016)

Log Message

REGRESSION (r208522): LayoutTest fast/loader/reload-zero-byte-plugin.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=164570

Reviewed by Simon Fraser.

Tools:

Properly reset TestController::m_shouldDownloadUndisplayableMIMETypes between tests to
avoid flakiness.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Unskip test which should no longer be flaky.

* platform/mac/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (208568 => 208569)


--- trunk/LayoutTests/ChangeLog	2016-11-10 23:27:37 UTC (rev 208568)
+++ trunk/LayoutTests/ChangeLog	2016-11-10 23:59:42 UTC (rev 208569)
@@ -1,3 +1,14 @@
+2016-11-10  Chris Dumez  <cdu...@apple.com>
+
+        REGRESSION (r208522): LayoutTest fast/loader/reload-zero-byte-plugin.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=164570
+
+        Reviewed by Simon Fraser.
+
+        Unskip test which should no longer be flaky.
+
+        * platform/mac/TestExpectations:
+
 2016-11-10  Brady Eidson  <beid...@apple.com>
 
         IndexedDB 2.0 Support the IDBDatabase.onclose event.

Modified: trunk/LayoutTests/platform/mac/TestExpectations (208568 => 208569)


--- trunk/LayoutTests/platform/mac/TestExpectations	2016-11-10 23:27:37 UTC (rev 208568)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2016-11-10 23:59:42 UTC (rev 208569)
@@ -1469,4 +1469,3 @@
 
 webkit.org/b/164388 inspector/sampling-profiler [ Pass Timeout ]
 
-webkit.org/b/164570 fast/loader/reload-zero-byte-plugin.html [ Pass Failure ]

Modified: trunk/Tools/ChangeLog (208568 => 208569)


--- trunk/Tools/ChangeLog	2016-11-10 23:27:37 UTC (rev 208568)
+++ trunk/Tools/ChangeLog	2016-11-10 23:59:42 UTC (rev 208569)
@@ -1,3 +1,16 @@
+2016-11-10  Chris Dumez  <cdu...@apple.com>
+
+        REGRESSION (r208522): LayoutTest fast/loader/reload-zero-byte-plugin.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=164570
+
+        Reviewed by Simon Fraser.
+
+        Properly reset TestController::m_shouldDownloadUndisplayableMIMETypes between tests to
+        avoid flakiness.
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::resetStateToConsistentValues):
+
 2016-11-10  Miguel Gomez  <mago...@igalia.com>
 
         Unreviewed. Added myself to the list of committers.

Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (208568 => 208569)


--- trunk/Tools/WebKitTestRunner/TestController.cpp	2016-11-10 23:27:37 UTC (rev 208568)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp	2016-11-10 23:59:42 UTC (rev 208569)
@@ -771,6 +771,8 @@
     // Reset Custom Policy Delegate.
     setCustomPolicyDelegate(false, false);
 
+    m_shouldDownloadUndisplayableMIMETypes = false;
+
     m_workQueueManager.clearWorkQueue();
 
     m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges = false;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to