Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (208759 => 208760)
--- trunk/Source/_javascript_Core/ChangeLog 2016-11-15 22:50:35 UTC (rev 208759)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-11-15 23:12:40 UTC (rev 208760)
@@ -1,3 +1,12 @@
+2016-11-15 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Remove unused and untested Page.setTouchEmulationEnabled command
+ https://bugs.webkit.org/show_bug.cgi?id=164793
+
+ Reviewed by Matt Baker.
+
+ * inspector/protocol/Page.json:
+
2016-11-15 Yusuke Suzuki <[email protected]>
Unreviewed, build fix for Windows debug build after r208738
Modified: trunk/Source/_javascript_Core/inspector/protocol/Page.json (208759 => 208760)
--- trunk/Source/_javascript_Core/inspector/protocol/Page.json 2016-11-15 22:50:35 UTC (rev 208759)
+++ trunk/Source/_javascript_Core/inspector/protocol/Page.json 2016-11-15 23:12:40 UTC (rev 208760)
@@ -215,13 +215,6 @@
]
},
{
- "name": "setTouchEmulationEnabled",
- "parameters": [
- { "name": "enabled", "type": "boolean", "description": "Whether the touch event emulation should be enabled." }
- ],
- "description": "Toggles mouse event-based touch event emulation."
- },
- {
"name": "setEmulatedMedia",
"parameters": [
{ "name": "media", "type": "string", "description": "Media type to emulate. Empty string disables the override." }
Modified: trunk/Source/WebCore/ChangeLog (208759 => 208760)
--- trunk/Source/WebCore/ChangeLog 2016-11-15 22:50:35 UTC (rev 208759)
+++ trunk/Source/WebCore/ChangeLog 2016-11-15 23:12:40 UTC (rev 208760)
@@ -1,3 +1,16 @@
+2016-11-15 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Remove unused and untested Page.setTouchEmulationEnabled command
+ https://bugs.webkit.org/show_bug.cgi?id=164793
+
+ Reviewed by Matt Baker.
+
+ * inspector/InspectorPageAgent.cpp:
+ (WebCore::InspectorPageAgent::willDestroyFrontendAndBackend):
+ (WebCore::InspectorPageAgent::updateTouchEventEmulationInPage): Deleted.
+ (WebCore::InspectorPageAgent::setTouchEmulationEnabled): Deleted.
+ * inspector/InspectorPageAgent.h:
+
2016-11-15 Jiewen Tan <[email protected]>
Unreviewed, quick fix for r208751
Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (208759 => 208760)
--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2016-11-15 22:50:35 UTC (rev 208759)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2016-11-15 23:12:40 UTC (rev 208760)
@@ -358,9 +358,6 @@
{
ErrorString unused;
disable(unused);
-#if ENABLE(TOUCH_EVENTS)
- updateTouchEventEmulationInPage(false);
-#endif
}
double InspectorPageAgent::timestamp()
@@ -977,24 +974,6 @@
return result;
}
-#if ENABLE(TOUCH_EVENTS)
-void InspectorPageAgent::updateTouchEventEmulationInPage(bool enabled)
-{
- mainFrame().settings().setTouchEventEmulationEnabled(enabled);
-}
-#endif
-
-void InspectorPageAgent::setTouchEmulationEnabled(ErrorString& error, bool enabled)
-{
-#if ENABLE(TOUCH_EVENTS)
- UNUSED_PARAM(error);
- updateTouchEventEmulationInPage(enabled);
-#else
- error = ASCIILiteral("Touch events emulation not supported");
- UNUSED_PARAM(enabled);
-#endif
-}
-
void InspectorPageAgent::setEmulatedMedia(ErrorString&, const String& media)
{
if (media == m_emulatedMedia)
Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.h (208759 => 208760)
--- trunk/Source/WebCore/inspector/InspectorPageAgent.h 2016-11-15 22:50:35 UTC (rev 208759)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.h 2016-11-15 23:12:40 UTC (rev 208760)
@@ -102,7 +102,6 @@
void setShowPaintRects(ErrorString&, bool show) override;
void getScriptExecutionStatus(ErrorString&, Inspector::PageBackendDispatcherHandler::Result*) override;
void setScriptExecutionDisabled(ErrorString&, bool) override;
- void setTouchEmulationEnabled(ErrorString&, bool) override;
void setEmulatedMedia(ErrorString&, const String&) override;
void getCompositingBordersVisible(ErrorString&, bool* out_param) override;
void setCompositingBordersVisible(ErrorString&, bool) override;
@@ -148,10 +147,6 @@
static DocumentLoader* assertDocumentLoader(ErrorString&, Frame*);
private:
-#if ENABLE(TOUCH_EVENTS)
- void updateTouchEventEmulationInPage(bool);
-#endif
-
double timestamp();
static bool mainResourceContent(Frame*, bool withBase64Encode, String* result);
Modified: trunk/Source/WebInspectorUI/ChangeLog (208759 => 208760)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-11-15 22:50:35 UTC (rev 208759)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-11-15 23:12:40 UTC (rev 208760)
@@ -1,5 +1,23 @@
2016-11-15 Joseph Pecoraro <[email protected]>
+ Web Inspector: Remove unused and untested Page.setTouchEmulationEnabled command
+ https://bugs.webkit.org/show_bug.cgi?id=164793
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:
+ * Versions/Inspector-iOS-10.0.json:
+ * Versions/Inspector-iOS-7.0.json:
+ * Versions/Inspector-iOS-8.0.json:
+ * Versions/Inspector-iOS-9.0.json:
+ * Versions/Inspector-iOS-9.3.json:
+
+2016-11-15 Joseph Pecoraro <[email protected]>
+
Web Inspector: URL Breakpoints that resolve in multiple workers should only appear in the UI once
https://bugs.webkit.org/show_bug.cgi?id=164334
<rdar://problem/29073523>
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js (208759 => 208760)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js 2016-11-15 22:50:35 UTC (rev 208759)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js 2016-11-15 23:12:40 UTC (rev 208760)
@@ -333,7 +333,6 @@
InspectorBackend.registerCommand("Page.setShowPaintRects", [{"name": "result", "type": "boolean", "optional": false}], []);
InspectorBackend.registerCommand("Page.getScriptExecutionStatus", [], ["result"]);
InspectorBackend.registerCommand("Page.setScriptExecutionDisabled", [{"name": "value", "type": "boolean", "optional": false}], []);
-InspectorBackend.registerCommand("Page.setTouchEmulationEnabled", [{"name": "enabled", "type": "boolean", "optional": false}], []);
InspectorBackend.registerCommand("Page.setEmulatedMedia", [{"name": "media", "type": "string", "optional": false}], []);
InspectorBackend.registerCommand("Page.getCompositingBordersVisible", [], ["result"]);
InspectorBackend.registerCommand("Page.setCompositingBordersVisible", [{"name": "visible", "type": "boolean", "optional": false}], []);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js (208759 => 208760)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js 2016-11-15 22:50:35 UTC (rev 208759)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js 2016-11-15 23:12:40 UTC (rev 208760)
@@ -67,7 +67,6 @@
InspectorBackend.registerCommand("Page.setDocumentContent", [{"name": "frameId", "type": "string", "optional": false}, {"name": "html", "type": "string", "optional": false}], []);
InspectorBackend.registerCommand("Page.getScriptExecutionStatus", [], ["result"]);
InspectorBackend.registerCommand("Page.setScriptExecutionDisabled", [{"name": "value", "type": "boolean", "optional": false}], []);
-InspectorBackend.registerCommand("Page.setTouchEmulationEnabled", [{"name": "enabled", "type": "boolean", "optional": false}], []);
InspectorBackend.registerCommand("Page.setEmulatedMedia", [{"name": "media", "type": "string", "optional": false}], []);
InspectorBackend.registerCommand("Page.getCompositingBordersVisible", [], ["result"]);
InspectorBackend.registerCommand("Page.setCompositingBordersVisible", [{"name": "visible", "type": "boolean", "optional": false}], []);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js (208759 => 208760)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js 2016-11-15 22:50:35 UTC (rev 208759)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js 2016-11-15 23:12:40 UTC (rev 208760)
@@ -323,7 +323,6 @@
InspectorBackend.registerCommand("Page.setDocumentContent", [{"name": "frameId", "type": "string", "optional": false}, {"name": "html", "type": "string", "optional": false}], []);
InspectorBackend.registerCommand("Page.getScriptExecutionStatus", [], ["result"]);
InspectorBackend.registerCommand("Page.setScriptExecutionDisabled", [{"name": "value", "type": "boolean", "optional": false}], []);
-InspectorBackend.registerCommand("Page.setTouchEmulationEnabled", [{"name": "enabled", "type": "boolean", "optional": false}], []);
InspectorBackend.registerCommand("Page.setEmulatedMedia", [{"name": "media", "type": "string", "optional": false}], []);
InspectorBackend.registerCommand("Page.getCompositingBordersVisible", [], ["result"]);
InspectorBackend.registerCommand("Page.setCompositingBordersVisible", [{"name": "visible", "type": "boolean", "optional": false}], []);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js (208759 => 208760)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js 2016-11-15 22:50:35 UTC (rev 208759)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js 2016-11-15 23:12:40 UTC (rev 208760)
@@ -293,7 +293,6 @@
InspectorBackend.registerCommand("Page.setShowPaintRects", [{"name": "result", "type": "boolean", "optional": false}], []);
InspectorBackend.registerCommand("Page.getScriptExecutionStatus", [], ["result"]);
InspectorBackend.registerCommand("Page.setScriptExecutionDisabled", [{"name": "value", "type": "boolean", "optional": false}], []);
-InspectorBackend.registerCommand("Page.setTouchEmulationEnabled", [{"name": "enabled", "type": "boolean", "optional": false}], []);
InspectorBackend.registerCommand("Page.setEmulatedMedia", [{"name": "media", "type": "string", "optional": false}], []);
InspectorBackend.registerCommand("Page.getCompositingBordersVisible", [], ["result"]);
InspectorBackend.registerCommand("Page.setCompositingBordersVisible", [{"name": "visible", "type": "boolean", "optional": false}], []);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js (208759 => 208760)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js 2016-11-15 22:50:35 UTC (rev 208759)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js 2016-11-15 23:12:40 UTC (rev 208760)
@@ -304,7 +304,6 @@
InspectorBackend.registerCommand("Page.setShowPaintRects", [{"name": "result", "type": "boolean", "optional": false}], []);
InspectorBackend.registerCommand("Page.getScriptExecutionStatus", [], ["result"]);
InspectorBackend.registerCommand("Page.setScriptExecutionDisabled", [{"name": "value", "type": "boolean", "optional": false}], []);
-InspectorBackend.registerCommand("Page.setTouchEmulationEnabled", [{"name": "enabled", "type": "boolean", "optional": false}], []);
InspectorBackend.registerCommand("Page.setEmulatedMedia", [{"name": "media", "type": "string", "optional": false}], []);
InspectorBackend.registerCommand("Page.getCompositingBordersVisible", [], ["result"]);
InspectorBackend.registerCommand("Page.setCompositingBordersVisible", [{"name": "visible", "type": "boolean", "optional": false}], []);
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json (208759 => 208760)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json 2016-11-15 22:50:35 UTC (rev 208759)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json 2016-11-15 23:12:40 UTC (rev 208760)
@@ -2946,13 +2946,6 @@
]
},
{
- "name": "setTouchEmulationEnabled",
- "parameters": [
- { "name": "enabled", "type": "boolean", "description": "Whether the touch event emulation should be enabled." }
- ],
- "description": "Toggles mouse event-based touch event emulation."
- },
- {
"name": "setEmulatedMedia",
"parameters": [
{ "name": "media", "type": "string", "description": "Media type to emulate. Empty string disables the override." }
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json (208759 => 208760)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2016-11-15 22:50:35 UTC (rev 208759)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2016-11-15 23:12:40 UTC (rev 208760)
@@ -251,13 +251,6 @@
]
},
{
- "name": "setTouchEmulationEnabled",
- "parameters": [
- { "name": "enabled", "type": "boolean", "description": "Whether the touch event emulation should be enabled." }
- ],
- "description": "Toggles mouse event-based touch event emulation."
- },
- {
"name": "setEmulatedMedia",
"parameters": [
{ "name": "media", "type": "string", "description": "Media type to emulate. Empty string disables the override." }
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json (208759 => 208760)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json 2016-11-15 22:50:35 UTC (rev 208759)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json 2016-11-15 23:12:40 UTC (rev 208760)
@@ -2814,13 +2814,6 @@
]
},
{
- "name": "setTouchEmulationEnabled",
- "parameters": [
- { "name": "enabled", "type": "boolean", "description": "Whether the touch event emulation should be enabled." }
- ],
- "description": "Toggles mouse event-based touch event emulation."
- },
- {
"name": "setEmulatedMedia",
"parameters": [
{ "name": "media", "type": "string", "description": "Media type to emulate. Empty string disables the override." }
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json (208759 => 208760)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json 2016-11-15 22:50:35 UTC (rev 208759)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json 2016-11-15 23:12:40 UTC (rev 208760)
@@ -2692,13 +2692,6 @@
]
},
{
- "name": "setTouchEmulationEnabled",
- "parameters": [
- { "name": "enabled", "type": "boolean", "description": "Whether the touch event emulation should be enabled." }
- ],
- "description": "Toggles mouse event-based touch event emulation."
- },
- {
"name": "setEmulatedMedia",
"parameters": [
{ "name": "media", "type": "string", "description": "Media type to emulate. Empty string disables the override." }
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json (208759 => 208760)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json 2016-11-15 22:50:35 UTC (rev 208759)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json 2016-11-15 23:12:40 UTC (rev 208760)
@@ -2774,13 +2774,6 @@
]
},
{
- "name": "setTouchEmulationEnabled",
- "parameters": [
- { "name": "enabled", "type": "boolean", "description": "Whether the touch event emulation should be enabled." }
- ],
- "description": "Toggles mouse event-based touch event emulation."
- },
- {
"name": "setEmulatedMedia",
"parameters": [
{ "name": "media", "type": "string", "description": "Media type to emulate. Empty string disables the override." }
