Title: [208772] trunk/Source/WebCore
Revision
208772
Author
[email protected]
Date
2016-11-15 16:44:04 -0800 (Tue, 15 Nov 2016)

Log Message

Fix iOS API test assertion after r208534
https://bugs.webkit.org/show_bug.cgi?id=164751

Patch by Alex Christensen <[email protected]> on 2016-11-15
Reviewed by Geoffrey Garen.

This removes a firing assertion in the WebKit1.AudioSessionCategoryIOS API test on the iOS simulator.

* platform/MemoryPressureHandler.h:
(WebCore::MemoryPressureHandler::setLowMemoryHandler):
This assertion is no longer valid because we are using m_installed to determine if m_lowMemoryHandler xor m_releaseMemoryBlock is set,
and we should be setting both right now on iOS and they are both useful in freeing memory. These should be united.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (208771 => 208772)


--- trunk/Source/WebCore/ChangeLog	2016-11-16 00:25:28 UTC (rev 208771)
+++ trunk/Source/WebCore/ChangeLog	2016-11-16 00:44:04 UTC (rev 208772)
@@ -1,3 +1,17 @@
+2016-11-15  Alex Christensen  <[email protected]>
+
+        Fix iOS API test assertion after r208534
+        https://bugs.webkit.org/show_bug.cgi?id=164751
+
+        Reviewed by Geoffrey Garen.
+
+        This removes a firing assertion in the WebKit1.AudioSessionCategoryIOS API test on the iOS simulator.
+
+        * platform/MemoryPressureHandler.h:
+        (WebCore::MemoryPressureHandler::setLowMemoryHandler):
+        This assertion is no longer valid because we are using m_installed to determine if m_lowMemoryHandler xor m_releaseMemoryBlock is set,
+        and we should be setting both right now on iOS and they are both useful in freeing memory. These should be united.
+
 2016-11-15  Brady Eidson  <[email protected]>
 
         IndexedDB 2.0: Key collation during SQLite lookups is insanely slow.

Modified: trunk/Source/WebCore/platform/MemoryPressureHandler.h (208771 => 208772)


--- trunk/Source/WebCore/platform/MemoryPressureHandler.h	2016-11-16 00:25:28 UTC (rev 208771)
+++ trunk/Source/WebCore/platform/MemoryPressureHandler.h	2016-11-16 00:44:04 UTC (rev 208772)
@@ -69,7 +69,6 @@
 
     void setLowMemoryHandler(LowMemoryHandler&& handler)
     {
-        ASSERT(!m_installed);
         m_lowMemoryHandler = WTFMove(handler);
     }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to