Title: [208784] trunk/Source/WebKit2
Revision
208784
Author
[email protected]
Date
2016-11-15 22:11:29 -0800 (Tue, 15 Nov 2016)

Log Message

[iOS WK2] Scroll view scrolling and zooming animations can keep running across page loads
https://bugs.webkit.org/show_bug.cgi?id=164810

Reviewed by Tim Horton.

Scrolling and zooming animations can leak across page loads, which makes tests flakey,
and is unexpected by users.

Tested by scrollingcoordinator/ios/sync-layer-positions-after-scroll.html followed by
scrollingcoordinator/ios/ui-scrolling-tree.html

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLoadForMainFrame]):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (208783 => 208784)


--- trunk/Source/WebKit2/ChangeLog	2016-11-16 06:03:45 UTC (rev 208783)
+++ trunk/Source/WebKit2/ChangeLog	2016-11-16 06:11:29 UTC (rev 208784)
@@ -1,3 +1,19 @@
+2016-11-15  Simon Fraser  <[email protected]>
+
+        [iOS WK2] Scroll view scrolling and zooming animations can keep running across page loads
+        https://bugs.webkit.org/show_bug.cgi?id=164810
+
+        Reviewed by Tim Horton.
+        
+        Scrolling and zooming animations can leak across page loads, which makes tests flakey,
+        and is unexpected by users.
+
+        Tested by scrollingcoordinator/ios/sync-layer-positions-after-scroll.html followed by
+        scrollingcoordinator/ios/ui-scrolling-tree.html
+
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView _didCommitLoadForMainFrame]):
+
 2016-11-15  Jon Lee  <[email protected]>
 
         Report active video and audio capture devices separately

Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (208783 => 208784)


--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2016-11-16 06:03:45 UTC (rev 208783)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2016-11-16 06:11:29 UTC (rev 208784)
@@ -1204,6 +1204,8 @@
 
     _hasCommittedLoadForMainFrame = YES;
     _needsResetViewStateAfterCommitLoadForMainFrame = YES;
+
+    [_scrollView _stopScrollingAndZoomingAnimations];
 }
 
 static CGPoint contentOffsetBoundedInValidRange(UIScrollView *scrollView, CGPoint contentOffset)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to