Title: [208859] trunk
- Revision
- 208859
- Author
- [email protected]
- Date
- 2016-11-17 13:23:45 -0800 (Thu, 17 Nov 2016)
Log Message
Render tree should be all clean by the end of FrameView::layout().
https://bugs.webkit.org/show_bug.cgi?id=162834
Reviewed by Simon Fraser.
Source/WebCore:
This is a preventive patch to ensure we don't introduce new bugs through
dirty renderers. There are still 3 failing cases and they are skipped for now (debug only).
* page/FrameView.cpp:
(WebCore::RenderTreeNeedsLayoutChecker::~RenderTreeNeedsLayoutChecker):
LayoutTests:
* TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (208858 => 208859)
--- trunk/LayoutTests/ChangeLog 2016-11-17 21:20:20 UTC (rev 208858)
+++ trunk/LayoutTests/ChangeLog 2016-11-17 21:23:45 UTC (rev 208859)
@@ -1,3 +1,12 @@
+2016-11-17 Zalan Bujtas <[email protected]>
+
+ Render tree should be all clean by the end of FrameView::layout().
+ https://bugs.webkit.org/show_bug.cgi?id=162834
+
+ Reviewed by Simon Fraser.
+
+ * TestExpectations:
+
2016-11-17 Brent Fulgham <[email protected]>
keygen element should not support < 2048 RSA key lengths
Modified: trunk/LayoutTests/TestExpectations (208858 => 208859)
--- trunk/LayoutTests/TestExpectations 2016-11-17 21:20:20 UTC (rev 208858)
+++ trunk/LayoutTests/TestExpectations 2016-11-17 21:23:45 UTC (rev 208859)
@@ -1026,3 +1026,8 @@
webkit.org/b/164539 http/tests/security/module-crossorigin-error-event-information.html [ Failure ]
webkit.org/b/164539 http/tests/security/module-crossorigin-onerror-information.html [ Failure ]
+
+# Clean layout tree after FrameView::layout
+webkit.org/b/164856 [ Debug ] editing/execCommand/indent-block-in-list.html [ Skip ]
+webkit.org/b/162831 [ Debug ] imported/blink/css3/flexbox/relpos-with-scrollable-with-abspos-crash.html [ Skip ]
+webkit.org/b/162828 [ Debug ] tables/table-section-overflow-clip-crash.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (208858 => 208859)
--- trunk/Source/WebCore/ChangeLog 2016-11-17 21:20:20 UTC (rev 208858)
+++ trunk/Source/WebCore/ChangeLog 2016-11-17 21:23:45 UTC (rev 208859)
@@ -1,3 +1,16 @@
+2016-11-17 Zalan Bujtas <[email protected]>
+
+ Render tree should be all clean by the end of FrameView::layout().
+ https://bugs.webkit.org/show_bug.cgi?id=162834
+
+ Reviewed by Simon Fraser.
+
+ This is a preventive patch to ensure we don't introduce new bugs through
+ dirty renderers. There are still 3 failing cases and they are skipped for now (debug only).
+
+ * page/FrameView.cpp:
+ (WebCore::RenderTreeNeedsLayoutChecker::~RenderTreeNeedsLayoutChecker):
+
2016-11-17 Brent Fulgham <[email protected]>
keygen element should not support < 2048 RSA key lengths
Modified: trunk/Source/WebCore/page/FrameView.cpp (208858 => 208859)
--- trunk/Source/WebCore/page/FrameView.cpp 2016-11-17 21:20:20 UTC (rev 208858)
+++ trunk/Source/WebCore/page/FrameView.cpp 2016-11-17 21:23:45 UTC (rev 208859)
@@ -215,6 +215,7 @@
auto reportNeedsLayoutError = [] (const RenderObject& renderer) {
WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, "post-layout: dirty renderer(s)");
renderer.showRenderTreeForThis();
+ ASSERT_NOT_REACHED();
};
if (m_layoutRoot.needsLayout()) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
