Title: [208938] trunk/Source/WebCore
- Revision
- 208938
- Author
- [email protected]
- Date
- 2016-11-20 20:38:42 -0800 (Sun, 20 Nov 2016)
Log Message
REGRESSION (r208606?): LayoutTest fast/mediastream/enumerating-crash.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=164715
<rdar://problem/29277180>
Reviewed by Alexey Proskuryakov.
No new tests, fixes an existing test crash.
* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::contextDestroyed): Call base class method before clearing m_controller
because it nullifies the security context.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (208937 => 208938)
--- trunk/Source/WebCore/ChangeLog 2016-11-21 01:34:20 UTC (rev 208937)
+++ trunk/Source/WebCore/ChangeLog 2016-11-21 04:38:42 UTC (rev 208938)
@@ -1,3 +1,17 @@
+2016-11-20 Eric Carlson <[email protected]>
+
+ REGRESSION (r208606?): LayoutTest fast/mediastream/enumerating-crash.html is a flaky crash
+ https://bugs.webkit.org/show_bug.cgi?id=164715
+ <rdar://problem/29277180>
+
+ Reviewed by Alexey Proskuryakov.
+
+ No new tests, fixes an existing test crash.
+
+ * Modules/mediastream/UserMediaRequest.cpp:
+ (WebCore::UserMediaRequest::contextDestroyed): Call base class method before clearing m_controller
+ because it nullifies the security context.
+
2016-11-19 Chris Dumez <[email protected]>
Update HTML form validation messages
Modified: trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp (208937 => 208938)
--- trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp 2016-11-21 01:34:20 UTC (rev 208937)
+++ trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp 2016-11-21 04:38:42 UTC (rev 208938)
@@ -228,6 +228,7 @@
void UserMediaRequest::contextDestroyed()
{
+ ContextDestructionObserver::contextDestroyed();
Ref<UserMediaRequest> protectedThis(*this);
if (m_controller) {
@@ -234,8 +235,6 @@
m_controller->cancelUserMediaAccessRequest(*this);
m_controller = nullptr;
}
-
- ContextDestructionObserver::contextDestroyed();
}
Document* UserMediaRequest::document() const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
