Title: [208969] trunk/Source/WebKit/mac
Revision
208969
Author
[email protected]
Date
2016-11-22 20:05:21 -0800 (Tue, 22 Nov 2016)

Log Message

[Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
https://bugs.webkit.org/show_bug.cgi?id=165036
<rdar://problem/5708580>

Reviewed by Alexey Proskuryakov.

* WebView/WebHTMLView.mm:
(-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,
  similarly to what we do in -keyDown: and to what WKWebView does with all key events.

Modified Paths

Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (208968 => 208969)


--- trunk/Source/WebKit/mac/ChangeLog	2016-11-22 20:52:05 UTC (rev 208968)
+++ trunk/Source/WebKit/mac/ChangeLog	2016-11-23 04:05:21 UTC (rev 208969)
@@ -1,3 +1,15 @@
+2016-11-22  Dan Bernstein  <[email protected]>
+
+        [Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
+        https://bugs.webkit.org/show_bug.cgi?id=165036
+        <rdar://problem/5708580>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebView/WebHTMLView.mm:
+        (-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,
+          similarly to what we do in -keyDown: and to what WKWebView does with all key events.
+
 2016-11-21  Alex Christensen  <[email protected]>
 
         Fix Sierra CMake build after r208452

Modified: trunk/Source/WebKit/mac/WebView/WebHTMLView.mm (208968 => 208969)


--- trunk/Source/WebKit/mac/WebView/WebHTMLView.mm	2016-11-22 20:52:05 UTC (rev 208968)
+++ trunk/Source/WebKit/mac/WebView/WebHTMLView.mm	2016-11-23 04:05:21 UTC (rev 208969)
@@ -5529,7 +5529,9 @@
         if (Frame* frame = core([self _frame]))
             ret = frame->eventHandler().keyEvent(event);
 
-    if (!ret)
+    if (ret)
+        [NSCursor setHiddenUntilMouseMoves:YES];
+    else
         ret = [self _handleStyleKeyEquivalent:event] || [super performKeyEquivalent:event];
 
     [self release];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to