Title: [209009] trunk/Source/WebCore
- Revision
- 209009
- Author
- cdu...@apple.com
- Date
- 2016-11-28 12:45:27 -0800 (Mon, 28 Nov 2016)
Log Message
Limit HTML Form validation popovers to 4 lines
https://bugs.webkit.org/show_bug.cgi?id=165098
<rdar://problem/29403286>
Reviewed by Darin Adler.
Limit HTML Form validation popovers to 4 lines as per recent feedback.
* platform/ios/ValidationBubbleIOS.mm:
(WebCore::ValidationBubble::ValidationBubble):
* platform/mac/ValidationBubbleMac.mm:
(WebCore::ValidationBubble::ValidationBubble):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (209008 => 209009)
--- trunk/Source/WebCore/ChangeLog 2016-11-28 20:45:12 UTC (rev 209008)
+++ trunk/Source/WebCore/ChangeLog 2016-11-28 20:45:27 UTC (rev 209009)
@@ -1,3 +1,18 @@
+2016-11-28 Chris Dumez <cdu...@apple.com>
+
+ Limit HTML Form validation popovers to 4 lines
+ https://bugs.webkit.org/show_bug.cgi?id=165098
+ <rdar://problem/29403286>
+
+ Reviewed by Darin Adler.
+
+ Limit HTML Form validation popovers to 4 lines as per recent feedback.
+
+ * platform/ios/ValidationBubbleIOS.mm:
+ (WebCore::ValidationBubble::ValidationBubble):
+ * platform/mac/ValidationBubbleMac.mm:
+ (WebCore::ValidationBubble::ValidationBubble):
+
2016-11-28 Dave Hyatt <hy...@apple.com>
[CSS Parser] Filters and Reflections Fixes
Modified: trunk/Source/WebCore/platform/ios/ValidationBubbleIOS.mm (209008 => 209009)
--- trunk/Source/WebCore/platform/ios/ValidationBubbleIOS.mm 2016-11-28 20:45:12 UTC (rev 209008)
+++ trunk/Source/WebCore/platform/ios/ValidationBubbleIOS.mm 2016-11-28 20:45:27 UTC (rev 209009)
@@ -72,7 +72,7 @@
RetainPtr<UILabel> label = adoptNS([[getUILabelClass() alloc] initWithFrame:CGRectZero]);
[label setText:message];
[label setLineBreakMode:NSLineBreakByWordWrapping];
- [label setNumberOfLines:0]; // No limit.
+ [label setNumberOfLines:4];
[popoverView addSubview:label.get()];
CGSize labelSize = [label sizeThatFits:CGSizeMake(maxLabelWidth, CGFLOAT_MAX)];
Modified: trunk/Source/WebCore/platform/mac/ValidationBubbleMac.mm (209008 => 209009)
--- trunk/Source/WebCore/platform/mac/ValidationBubbleMac.mm 2016-11-28 20:45:12 UTC (rev 209008)
+++ trunk/Source/WebCore/platform/mac/ValidationBubbleMac.mm 2016-11-28 20:45:27 UTC (rev 209009)
@@ -51,6 +51,7 @@
[label setDrawsBackground:NO];
[label setBordered:NO];
[label setStringValue:message];
+ [label setMaximumNumberOfLines:4];
[popoverView addSubview:label.get()];
NSSize labelSize = [label sizeThatFits:NSMakeSize(maxLabelWidth, CGFLOAT_MAX)];
[label setFrame:NSMakeRect(horizontalPadding, verticalPadding, labelSize.width, labelSize.height)];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
