Title: [209013] trunk/Source/WebCore
Revision
209013
Author
[email protected]
Date
2016-11-28 13:42:56 -0800 (Mon, 28 Nov 2016)

Log Message

Blacklist Netflix for TouchBar support
https://bugs.webkit.org/show_bug.cgi?id=165104
-and corresponding-
rdar://problem/29404778

Reviewed by Darin Adler.

* html/HTMLMediaElement.cpp:
(WebCore::needsPlaybackControlsManagerQuirk):
(WebCore::HTMLMediaElement::updatePlaybackControlsManager):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (209012 => 209013)


--- trunk/Source/WebCore/ChangeLog	2016-11-28 21:37:07 UTC (rev 209012)
+++ trunk/Source/WebCore/ChangeLog	2016-11-28 21:42:56 UTC (rev 209013)
@@ -1,3 +1,16 @@
+2016-11-28  Beth Dakin  <[email protected]>
+
+        Blacklist Netflix for TouchBar support
+        https://bugs.webkit.org/show_bug.cgi?id=165104
+        -and corresponding-
+        rdar://problem/29404778
+
+        Reviewed by Darin Adler.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::needsPlaybackControlsManagerQuirk):
+        (WebCore::HTMLMediaElement::updatePlaybackControlsManager):
+
 2016-11-28  Chris Dumez  <[email protected]>
 
         Limit HTML Form validation popovers to 4 lines

Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (209012 => 209013)


--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2016-11-28 21:37:07 UTC (rev 209012)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2016-11-28 21:42:56 UTC (rev 209013)
@@ -7139,6 +7139,15 @@
     return renderer && renderer->visibleInViewportState() == RenderElement::VisibleInViewport;
 }
 
+static bool needsPlaybackControlsManagerQuirk(bool needsQuirks, const URL& url)
+{
+    if (!needsQuirks)
+        return false;
+
+    String host = url.host();
+    return equalLettersIgnoringASCIICase(host, "www.netflix.com");
+}
+
 void HTMLMediaElement::updatePlaybackControlsManager()
 {
     Page* page = document().page();
@@ -7145,8 +7154,11 @@
     if (!page)
         return;
 
+    auto bestMediaElement = bestMediaElementForShowingPlaybackControlsManager(MediaElementSession::PlaybackControlsPurpose::ControlsManager);
+    bool quirkDisablesPlaybackControlsManager = needsPlaybackControlsManagerQuirk(page->settings().needsSiteSpecificQuirks(), page->mainFrame().document()->url());
+
     // FIXME: Ensure that the renderer here should be up to date.
-    if (auto bestMediaElement = bestMediaElementForShowingPlaybackControlsManager(MediaElementSession::PlaybackControlsPurpose::ControlsManager))
+    if (bestMediaElement && !quirkDisablesPlaybackControlsManager)
         page->chrome().client().setUpPlaybackControlsManager(*bestMediaElement);
     else
         page->chrome().client().clearPlaybackControlsManager();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to