Title: [209016] trunk/Source/WebCore
Revision
209016
Author
[email protected]
Date
2016-11-28 14:16:20 -0800 (Mon, 28 Nov 2016)

Log Message

Unreviewed, fix crashes on Yosemite after r209009

NSTextField's maximumNumberOfLines was introduced in ElCapitan so
disable it at compile-time on previous OSes for now.

* platform/mac/ValidationBubbleMac.mm:
(WebCore::ValidationBubble::ValidationBubble):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (209015 => 209016)


--- trunk/Source/WebCore/ChangeLog	2016-11-28 22:13:57 UTC (rev 209015)
+++ trunk/Source/WebCore/ChangeLog	2016-11-28 22:16:20 UTC (rev 209016)
@@ -1,3 +1,13 @@
+2016-11-28  Chris Dumez  <[email protected]>
+
+        Unreviewed, fix crashes on Yosemite after r209009
+
+        NSTextField's maximumNumberOfLines was introduced in ElCapitan so
+        disable it at compile-time on previous OSes for now.
+
+        * platform/mac/ValidationBubbleMac.mm:
+        (WebCore::ValidationBubble::ValidationBubble):
+
 2016-11-28  Keith Rollin  <[email protected]>
 
         Unreviewed, rolling out r208607.

Modified: trunk/Source/WebCore/platform/mac/ValidationBubbleMac.mm (209015 => 209016)


--- trunk/Source/WebCore/platform/mac/ValidationBubbleMac.mm	2016-11-28 22:13:57 UTC (rev 209015)
+++ trunk/Source/WebCore/platform/mac/ValidationBubbleMac.mm	2016-11-28 22:16:20 UTC (rev 209016)
@@ -51,7 +51,9 @@
     [label setDrawsBackground:NO];
     [label setBordered:NO];
     [label setStringValue:message];
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100
     [label setMaximumNumberOfLines:4];
+#endif
     [popoverView addSubview:label.get()];
     NSSize labelSize = [label sizeThatFits:NSMakeSize(maxLabelWidth, CGFLOAT_MAX)];
     [label setFrame:NSMakeRect(horizontalPadding, verticalPadding, labelSize.width, labelSize.height)];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to