Title: [209049] trunk/Source/WebCore
- Revision
- 209049
- Author
- [email protected]
- Date
- 2016-11-28 17:08:29 -0800 (Mon, 28 Nov 2016)
Log Message
[Mac] Clicking on an HTML validation bubble should dismiss it
https://bugs.webkit.org/show_bug.cgi?id=165117
<rdar://problem/29409837>
Reviewed by Simon Fraser.
Clicking on an HTML validation bubble should dismiss it. It previously
did nothing.
No new tests, this is not easily testable as EventSender.keyDown() sends
the event to the view, not to a particular screen location.
* platform/mac/ValidationBubbleMac.mm:
(-[WebValidationPopover mouseDown:]):
(WebCore::ValidationBubble::ValidationBubble):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (209048 => 209049)
--- trunk/Source/WebCore/ChangeLog 2016-11-29 01:03:48 UTC (rev 209048)
+++ trunk/Source/WebCore/ChangeLog 2016-11-29 01:08:29 UTC (rev 209049)
@@ -1,3 +1,21 @@
+2016-11-28 Chris Dumez <[email protected]>
+
+ [Mac] Clicking on an HTML validation bubble should dismiss it
+ https://bugs.webkit.org/show_bug.cgi?id=165117
+ <rdar://problem/29409837>
+
+ Reviewed by Simon Fraser.
+
+ Clicking on an HTML validation bubble should dismiss it. It previously
+ did nothing.
+
+ No new tests, this is not easily testable as EventSender.keyDown() sends
+ the event to the view, not to a particular screen location.
+
+ * platform/mac/ValidationBubbleMac.mm:
+ (-[WebValidationPopover mouseDown:]):
+ (WebCore::ValidationBubble::ValidationBubble):
+
2016-11-27 Sam Weinig <[email protected]>
Make CanvasRenderingContext2D use WebIDL unions / Variants for createPattern and drawImage
Modified: trunk/Source/WebCore/platform/mac/ValidationBubbleMac.mm (209048 => 209049)
--- trunk/Source/WebCore/platform/mac/ValidationBubbleMac.mm 2016-11-29 01:03:48 UTC (rev 209048)
+++ trunk/Source/WebCore/platform/mac/ValidationBubbleMac.mm 2016-11-29 01:08:29 UTC (rev 209049)
@@ -31,6 +31,19 @@
#import <AppKit/AppKit.h>
#import <wtf/text/WTFString.h>
+@interface WebValidationPopover : NSPopover
+@end
+
+@implementation WebValidationPopover
+
+- (void)mouseDown:(NSEvent *)event
+{
+ UNUSED_PARAM(event);
+ [self close];
+}
+
+@end
+
namespace WebCore {
static const CGFloat horizontalPadding = 5;
@@ -59,7 +72,7 @@
[label setFrame:NSMakeRect(horizontalPadding, verticalPadding, labelSize.width, labelSize.height)];
[popoverView setFrame:NSMakeRect(0, 0, labelSize.width + horizontalPadding * 2, labelSize.height + verticalPadding * 2)];
- m_popover = adoptNS([[NSPopover alloc] init]);
+ m_popover = adoptNS([[WebValidationPopover alloc] init]);
[m_popover setContentViewController:controller.get()];
[m_popover setBehavior:NSPopoverBehaviorTransient];
[m_popover setAnimates:NO];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes