Title: [209079] trunk/Source/WebCore
- Revision
- 209079
- Author
- [email protected]
- Date
- 2016-11-29 11:02:54 -0800 (Tue, 29 Nov 2016)
Log Message
Avoid ref-count churn in ShadowParseContext::commitColor()
https://bugs.webkit.org/show_bug.cgi?id=165125
Reviewed by Simon Fraser.
Avoid ref-count churn in ShadowParseContext::commitColor() by moving the passed
color into its instance variable.
Also modified ShadowParseContext::commitColor() to take a Ref<> instead of a
RefPtr<> because it is never passed a nullptr.
* css/parser/CSSParser.cpp:
(WebCore::ShadowParseContext::commitColor):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (209078 => 209079)
--- trunk/Source/WebCore/ChangeLog 2016-11-29 18:53:07 UTC (rev 209078)
+++ trunk/Source/WebCore/ChangeLog 2016-11-29 19:02:54 UTC (rev 209079)
@@ -1,5 +1,21 @@
2016-11-29 Daniel Bates <[email protected]>
+ Avoid ref-count churn in ShadowParseContext::commitColor()
+ https://bugs.webkit.org/show_bug.cgi?id=165125
+
+ Reviewed by Simon Fraser.
+
+ Avoid ref-count churn in ShadowParseContext::commitColor() by moving the passed
+ color into its instance variable.
+
+ Also modified ShadowParseContext::commitColor() to take a Ref<> instead of a
+ RefPtr<> because it is never passed a nullptr.
+
+ * css/parser/CSSParser.cpp:
+ (WebCore::ShadowParseContext::commitColor):
+
+2016-11-29 Daniel Bates <[email protected]>
+
Avoid ref-count churn in CSSParser::ValueWithCalculation::setCalculation()
https://bugs.webkit.org/show_bug.cgi?id=165127
Modified: trunk/Source/WebCore/css/parser/CSSParser.cpp (209078 => 209079)
--- trunk/Source/WebCore/css/parser/CSSParser.cpp 2016-11-29 18:53:07 UTC (rev 209078)
+++ trunk/Source/WebCore/css/parser/CSSParser.cpp 2016-11-29 19:02:54 UTC (rev 209079)
@@ -7897,9 +7897,9 @@
}
}
- void commitColor(RefPtr<CSSPrimitiveValue>&& val)
+ void commitColor(Ref<CSSPrimitiveValue>&& value)
{
- color = val;
+ color = WTFMove(value);
allowColor = false;
if (allowX) {
allowStyle = false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes