Title: [209084] trunk/Source/WebCore
Revision
209084
Author
[email protected]
Date
2016-11-29 11:46:31 -0800 (Tue, 29 Nov 2016)

Log Message

HTMLMediaElement::updateVolume should updateIsPlayingMedia
https://bugs.webkit.org/show_bug.cgi?id=165132

Reviewed by Darin Adler & Jer Noble.

HTMLMediaElement::mediaState takes the volume into account when determining whether media
is playing (audio is not considered to be playing if volume is 0). As such, any change to
the volume may require mediaState to be recomputed.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateVolume):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (209083 => 209084)


--- trunk/Source/WebCore/ChangeLog	2016-11-29 19:37:00 UTC (rev 209083)
+++ trunk/Source/WebCore/ChangeLog	2016-11-29 19:46:31 UTC (rev 209084)
@@ -1,3 +1,17 @@
+2016-11-28  Gavin Barraclough  <[email protected]>
+
+        HTMLMediaElement::updateVolume should updateIsPlayingMedia
+        https://bugs.webkit.org/show_bug.cgi?id=165132
+
+        Reviewed by Darin Adler & Jer Noble.
+
+        HTMLMediaElement::mediaState takes the volume into account when determining whether media
+        is playing (audio is not considered to be playing if volume is 0). As such, any change to
+        the volume may require mediaState to be recomputed.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::updateVolume):
+
 2016-11-29  Daniel Bates  <[email protected]>
 
         Avoid ref-count churn in ShadowParseContext::commitColor()

Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (209083 => 209084)


--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2016-11-29 19:37:00 UTC (rev 209083)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2016-11-29 19:46:31 UTC (rev 209084)
@@ -4824,6 +4824,12 @@
         m_player->setVolume(m_volume * volumeMultiplier);
     }
 
+#if ENABLE(MEDIA_SESSION)
+    document().updateIsPlayingMedia(m_elementID);
+#else
+    document().updateIsPlayingMedia();
+#endif
+
     if (hasMediaControls())
         mediaControls()->changedVolume();
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to