Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (209087 => 209088)
--- trunk/Source/_javascript_Core/ChangeLog 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-11-29 21:36:51 UTC (rev 209088)
@@ -1,3 +1,12 @@
+2016-11-29 Andy Estes <[email protected]>
+
+ [Cocoa] Enable two clang warnings recommended by Xcode
+ https://bugs.webkit.org/show_bug.cgi?id=164498
+
+ Reviewed by Mark Lam.
+
+ * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
+
2016-11-29 Keith Miller <[email protected]>
Add simple way to implement Wasm ops that require more than one B3 opcode
Modified: trunk/Source/_javascript_Core/Configurations/Base.xcconfig (209087 => 209088)
--- trunk/Source/_javascript_Core/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/_javascript_Core/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
@@ -35,7 +35,9 @@
CLANG_WARN_CXX0X_EXTENSIONS = NO;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
+CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
+CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COMBINE_HIDPI_IMAGES = NO;
DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
Modified: trunk/Source/WTF/ChangeLog (209087 => 209088)
--- trunk/Source/WTF/ChangeLog 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/WTF/ChangeLog 2016-11-29 21:36:51 UTC (rev 209088)
@@ -1,3 +1,12 @@
+2016-11-29 Andy Estes <[email protected]>
+
+ [Cocoa] Enable two clang warnings recommended by Xcode
+ https://bugs.webkit.org/show_bug.cgi?id=164498
+
+ Reviewed by Mark Lam.
+
+ * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
+
2016-11-29 Darin Adler <[email protected]>
REGRESSION (r209058): API test StringBuilderTest.Equal crashing
Modified: trunk/Source/WTF/Configurations/Base.xcconfig (209087 => 209088)
--- trunk/Source/WTF/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/WTF/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
@@ -35,7 +35,9 @@
CLANG_WARN_CXX0X_EXTENSIONS = NO;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
+CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
+CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COMBINE_HIDPI_IMAGES = NO;
Modified: trunk/Source/WebCore/ChangeLog (209087 => 209088)
--- trunk/Source/WebCore/ChangeLog 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/WebCore/ChangeLog 2016-11-29 21:36:51 UTC (rev 209088)
@@ -1,3 +1,12 @@
+2016-11-29 Andy Estes <[email protected]>
+
+ [Cocoa] Enable two clang warnings recommended by Xcode
+ https://bugs.webkit.org/show_bug.cgi?id=164498
+
+ Reviewed by Mark Lam.
+
+ * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
+
2016-11-29 Wenson Hsieh <[email protected]>
Address post-review feedback following r209070 (AppKit momentum scrolling adoption for scroll snapping)
Modified: trunk/Source/WebCore/Configurations/Base.xcconfig (209087 => 209088)
--- trunk/Source/WebCore/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/WebCore/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
@@ -35,7 +35,9 @@
CLANG_WARN_CXX0X_EXTENSIONS = NO;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
+CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
+CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
GCC_WARN_UNDECLARED_SELECTOR = YES;
Modified: trunk/Source/WebKit/mac/ChangeLog (209087 => 209088)
--- trunk/Source/WebKit/mac/ChangeLog 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-11-29 21:36:51 UTC (rev 209088)
@@ -1,3 +1,12 @@
+2016-11-29 Andy Estes <[email protected]>
+
+ [Cocoa] Enable two clang warnings recommended by Xcode
+ https://bugs.webkit.org/show_bug.cgi?id=164498
+
+ Reviewed by Mark Lam.
+
+ * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
+
2016-11-26 Yusuke Suzuki <[email protected]>
[WTF] Import std::optional reference implementation as WTF::Optional
Modified: trunk/Source/WebKit/mac/Configurations/Base.xcconfig (209087 => 209088)
--- trunk/Source/WebKit/mac/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/WebKit/mac/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
@@ -35,7 +35,9 @@
CLANG_WARN_CXX0X_EXTENSIONS = NO;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
+CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
+CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
GCC_WARN_UNDECLARED_SELECTOR = YES;
Modified: trunk/Source/WebKit2/ChangeLog (209087 => 209088)
--- trunk/Source/WebKit2/ChangeLog 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/WebKit2/ChangeLog 2016-11-29 21:36:51 UTC (rev 209088)
@@ -1,3 +1,12 @@
+2016-11-29 Andy Estes <[email protected]>
+
+ [Cocoa] Enable two clang warnings recommended by Xcode
+ https://bugs.webkit.org/show_bug.cgi?id=164498
+
+ Reviewed by Mark Lam.
+
+ * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
+
2016-11-29 Eric Carlson <[email protected]>
[MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
Modified: trunk/Source/WebKit2/Configurations/Base.xcconfig (209087 => 209088)
--- trunk/Source/WebKit2/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/WebKit2/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
@@ -35,7 +35,9 @@
CLANG_WARN_CXX0X_EXTENSIONS = NO;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
+CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
+CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COMBINE_HIDPI_IMAGES = NO;
Modified: trunk/Source/bmalloc/ChangeLog (209087 => 209088)
--- trunk/Source/bmalloc/ChangeLog 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/bmalloc/ChangeLog 2016-11-29 21:36:51 UTC (rev 209088)
@@ -1,3 +1,12 @@
+2016-11-29 Andy Estes <[email protected]>
+
+ [Cocoa] Enable two clang warnings recommended by Xcode
+ https://bugs.webkit.org/show_bug.cgi?id=164498
+
+ Reviewed by Mark Lam.
+
+ * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
+
2016-11-10 Geoffrey Garen <[email protected]>
bmalloc threads should have a non-default QoS
Modified: trunk/Source/bmalloc/Configurations/Base.xcconfig (209087 => 209088)
--- trunk/Source/bmalloc/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/bmalloc/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
@@ -35,7 +35,9 @@
CLANG_WARN_CXX0X_EXTENSIONS = NO;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
+CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
+CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
Modified: trunk/Tools/ChangeLog (209087 => 209088)
--- trunk/Tools/ChangeLog 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Tools/ChangeLog 2016-11-29 21:36:51 UTC (rev 209088)
@@ -1,3 +1,15 @@
+2016-11-29 Andy Estes <[email protected]>
+
+ [Cocoa] Enable two clang warnings recommended by Xcode
+ https://bugs.webkit.org/show_bug.cgi?id=164498
+
+ Reviewed by Mark Lam.
+
+ * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
+ * MiniBrowser/Configurations/Base.xcconfig: Ditto.
+ * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
+ * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
+
2016-11-29 Eric Carlson <[email protected]>
[MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
Modified: trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig (209087 => 209088)
--- trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
@@ -60,7 +60,9 @@
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
+CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
+CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO
Modified: trunk/Tools/MiniBrowser/Configurations/Base.xcconfig (209087 => 209088)
--- trunk/Tools/MiniBrowser/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Tools/MiniBrowser/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
@@ -41,7 +41,9 @@
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
+CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
+CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO;
Modified: trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig (209087 => 209088)
--- trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
@@ -51,7 +51,9 @@
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
+CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
+CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO
GCC_WARN_ABOUT_RETURN_TYPE = YES;
Modified: trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig (209087 => 209088)
--- trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
@@ -31,6 +31,8 @@
CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
CLANG_CXX_LIBRARY = libc++;
CLANG_WARN_CXX0X_EXTENSIONS = NO;
+CLANG_WARN_INFINITE_RECURSION = YES;
+CLANG_WARN_SUSPICIOUS_MOVE = YES;
HEADER_SEARCH_PATHS = $(BUILT_PRODUCTS_DIR)/usr/local/include $(WEBCORE_PRIVATE_HEADERS_DIR)/ForwardingHeaders $(SRCROOT)/../../Source/_javascript_Core/icu $(NEXT_ROOT)/usr/local/include/WebCoreTestSupport;
GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) ENABLE_DASHBOARD_SUPPORT;
DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;