Title: [209099] trunk/Source/WebCore
Revision
209099
Author
[email protected]
Date
2016-11-29 15:38:40 -0800 (Tue, 29 Nov 2016)

Log Message

[Modern Media Controls] Inline controls show when entering fullscreen
https://bugs.webkit.org/show_bug.cgi?id=165161

Patch by Antoine Quint <[email protected]> on 2016-11-29
Reviewed by Dean Jackson.

We would error when entering fullscreen due to the TracksSupport having its destroy() method
called when tearing down the inline controls and the `mediaController` reference being incorrect.

* Modules/modern-media-controls/media/tracks-support.js:
(TracksSupport.prototype.destroy):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (209098 => 209099)


--- trunk/Source/WebCore/ChangeLog	2016-11-29 23:38:19 UTC (rev 209098)
+++ trunk/Source/WebCore/ChangeLog	2016-11-29 23:38:40 UTC (rev 209099)
@@ -1,5 +1,18 @@
 2016-11-29  Antoine Quint  <[email protected]>
 
+        [Modern Media Controls] Inline controls show when entering fullscreen
+        https://bugs.webkit.org/show_bug.cgi?id=165161
+
+        Reviewed by Dean Jackson.
+
+        We would error when entering fullscreen due to the TracksSupport having its destroy() method
+        called when tearing down the inline controls and the `mediaController` reference being incorrect.
+
+        * Modules/modern-media-controls/media/tracks-support.js:
+        (TracksSupport.prototype.destroy):
+
+2016-11-29  Antoine Quint  <[email protected]>
+
         [Modern Media Controls] Status text stuck saying "Loading" after media starts playing
         https://bugs.webkit.org/show_bug.cgi?id=165162
 

Modified: trunk/Source/WebCore/Modules/modern-media-controls/media/tracks-support.js (209098 => 209099)


--- trunk/Source/WebCore/Modules/modern-media-controls/media/tracks-support.js	2016-11-29 23:38:19 UTC (rev 209098)
+++ trunk/Source/WebCore/Modules/modern-media-controls/media/tracks-support.js	2016-11-29 23:38:40 UTC (rev 209099)
@@ -46,7 +46,7 @@
     {
         super.destroy();
 
-        const media = mediaController.media;
+        const media = this.mediaController.media;
         for (let tracks of [media.audioTracks, media.textTracks]) {
             for (let eventType of ["addtrack", "removetrack"])
                 tracks.removeEventListener(eventType, this);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to