Title: [98796] trunk/Source/WebCore
- Revision
- 98796
- Author
- [email protected]
- Date
- 2011-10-28 23:31:16 -0700 (Fri, 28 Oct 2011)
Log Message
Potential crash in ReplaceNodeWithSpanCommand
https://bugs.webkit.org/show_bug.cgi?id=71145
Reviewed by Ojan Vafai.
Fix a potential crash without tests because we don't have a reduction.
* editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (98795 => 98796)
--- trunk/Source/WebCore/ChangeLog 2011-10-29 05:51:51 UTC (rev 98795)
+++ trunk/Source/WebCore/ChangeLog 2011-10-29 06:31:16 UTC (rev 98796)
@@ -1,3 +1,15 @@
+2011-10-28 Ryosuke Niwa <[email protected]>
+
+ Potential crash in ReplaceNodeWithSpanCommand
+ https://bugs.webkit.org/show_bug.cgi?id=71145
+
+ Reviewed by Ojan Vafai.
+
+ Fix a potential crash without tests because we don't have a reduction.
+
+ * editing/ReplaceNodeWithSpanCommand.cpp:
+ (WebCore::swapInNodePreservingAttributesAndChildren):
+
2011-10-28 Adam Barth <[email protected]>
MessagePort should be a ContextDestructionObserver
Modified: trunk/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp (98795 => 98796)
--- trunk/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp 2011-10-29 05:51:51 UTC (rev 98795)
+++ trunk/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp 2011-10-29 06:31:16 UTC (rev 98796)
@@ -52,7 +52,7 @@
{
ASSERT(nodeToReplace->inDocument());
ExceptionCode ec = 0;
- ContainerNode* parentNode = nodeToReplace->parentNode();
+ RefPtr<ContainerNode> parentNode = nodeToReplace->parentNode();
parentNode->insertBefore(newNode, nodeToReplace, ec);
ASSERT(!ec);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
