Title: [209258] trunk
Revision
209258
Author
[email protected]
Date
2016-12-02 13:02:44 -0800 (Fri, 02 Dec 2016)

Log Message

[CSS Parser] Make sure the z-component of transform-origin can be implicit
https://bugs.webkit.org/show_bug.cgi?id=165326

Reviewed by Tim Horton.

Source/WebCore:

* css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::consumeTransformOrigin):

LayoutTests:

* TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (209257 => 209258)


--- trunk/LayoutTests/ChangeLog	2016-12-02 20:59:00 UTC (rev 209257)
+++ trunk/LayoutTests/ChangeLog	2016-12-02 21:02:44 UTC (rev 209258)
@@ -1,5 +1,14 @@
 2016-12-02  Dave Hyatt  <[email protected]>
 
+        [CSS Parser] Make sure the z-component of transform-origin can be implicit
+        https://bugs.webkit.org/show_bug.cgi?id=165326
+
+        Reviewed by Tim Horton.
+
+        * TestExpectations:
+
+2016-12-02  Dave Hyatt  <[email protected]>
+
         [CSS Parser] Fix invalid test font specification
         https://bugs.webkit.org/show_bug.cgi?id=165324
 

Modified: trunk/LayoutTests/TestExpectations (209257 => 209258)


--- trunk/LayoutTests/TestExpectations	2016-12-02 20:59:00 UTC (rev 209257)
+++ trunk/LayoutTests/TestExpectations	2016-12-02 21:02:44 UTC (rev 209258)
@@ -1006,6 +1006,7 @@
 webkit.org/b/165195 fast/css/parsing-css-number-types.html [ Pass Failure ]
 webkit.org/b/165195 fast/css/parsing-css-wrap.html [ Pass Failure ]
 webkit.org/b/165195 fast/css/transform-origin-parsing.html [ Pass Failure ]
+webkit.org/b/165195 fast/css/transform-inline-style-remove.html [ Pass Failure ]
 webkit.org/b/165195 fast/css/variables/custom-property-dynamic-update.html [ Pass Failure ]
 webkit.org/b/165195 fast/events/mouse-cursor.html [ Pass Failure ]
 webkit.org/b/165195 fast/forms/basic-selects.html [ Pass Failure ]

Modified: trunk/Source/WebCore/ChangeLog (209257 => 209258)


--- trunk/Source/WebCore/ChangeLog	2016-12-02 20:59:00 UTC (rev 209257)
+++ trunk/Source/WebCore/ChangeLog	2016-12-02 21:02:44 UTC (rev 209258)
@@ -1,5 +1,15 @@
 2016-12-02  Dave Hyatt  <[email protected]>
 
+        [CSS Parser] Make sure the z-component of transform-origin can be implicit
+        https://bugs.webkit.org/show_bug.cgi?id=165326
+
+        Reviewed by Tim Horton.
+
+        * css/parser/CSSPropertyParser.cpp:
+        (WebCore::CSSPropertyParser::consumeTransformOrigin):
+
+2016-12-02  Dave Hyatt  <[email protected]>
+
         [CSS Parser] Fix :any/:host to allow pseudo-elements. Support -webkit-border-radius.
         https://bugs.webkit.org/show_bug.cgi?id=165323
 

Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (209257 => 209258)


--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp	2016-12-02 20:59:00 UTC (rev 209257)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp	2016-12-02 21:02:44 UTC (rev 209258)
@@ -376,11 +376,9 @@
         RefPtr<CSSPrimitiveValue> resultZ = consumeLength(m_range, m_context.mode, ValueRangeAll);
         if (!resultZ && !atEnd)
             return false;
-        if (!resultZ)
-            resultZ = CSSValuePool::singleton().createValue(0, CSSPrimitiveValue::UnitTypes::CSS_PX);
         addProperty(CSSPropertyTransformOriginX, CSSPropertyTransformOrigin, resultX.releaseNonNull(), important);
         addProperty(CSSPropertyTransformOriginY, CSSPropertyTransformOrigin, resultY.releaseNonNull(), important);
-        addProperty(CSSPropertyTransformOriginZ, CSSPropertyTransformOrigin, resultZ.releaseNonNull(), important);
+        addProperty(CSSPropertyTransformOriginZ, CSSPropertyTransformOrigin, resultZ ? resultZ.releaseNonNull() : CSSValuePool::singleton().createValue(0, CSSPrimitiveValue::UnitTypes::CSS_PX), important, !resultZ);
         
         return true;
     }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to