Title: [209288] trunk
Revision
209288
Author
[email protected]
Date
2016-12-02 17:31:48 -0800 (Fri, 02 Dec 2016)

Log Message

[Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
https://bugs.webkit.org/show_bug.cgi?id=164492

Reviewed by Dan Bernstein.

Source/_javascript_Core:

* Configurations/_javascript_Core.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
com.apple.$(PRODUCT_NAME:rfc1034identifier).
* Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
${PRODUCT_BUNDLE_IDENTIFIER}.

Source/WebCore:

* Configurations/WebCore.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
com.apple.$(PRODUCT_NAME:rfc1034identifier).
* Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
${PRODUCT_BUNDLE_IDENTIFIER}.

Source/WebInspectorUI:

* Configurations/WebInspectorUIFramework.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
com.apple.$(PRODUCT_NAME:rfc1034identifier).
* Info.plist: Changed CFBundleIdentifier's value from
com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.

Source/WebKit/mac:

* Configurations/WebKitLegacy.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
com.apple.$(PRODUCT_NAME:rfc1034identifier).
* Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
${PRODUCT_BUNDLE_IDENTIFIER}.

Source/WebKit2:

* Configurations/DatabaseService.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
$(PRODUCT_NAME).
* Configurations/NetworkService.xcconfig: Ditto.
* Configurations/PluginService.32.xcconfig: Ditto.
* Configurations/PluginService.64.xcconfig: Ditto.
* Configurations/WebContentService.xcconfig: Ditto.
* Configurations/WebKit.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
com.apple.$(PRODUCT_NAME:rfc1034identifier).
* DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist: Changed
CFBundleIdentifier's value from ${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
* Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
${PRODUCT_BUNDLE_IDENTIFIER}.
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX-10.9-10.10.plist: Changed
CFBundleIdentifier's value from ${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist: Ditto.
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist: Ditto.
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64-10.9-10.10.Info.plist: Ditto.
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist: Ditto.
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX-10.9-10.10.plist: Ditto.
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist: Ditto.
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist: Ditto.

Tools:

* DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Changed CFBundleIdentifier's value from
com.apple.testnetscapeplugin to ${PRODUCT_BUNDLE_IDENTIFIER}.
* DumpRenderTree/ios/Info.plist: Changed CFBundleIdentifier's value from
org.webkit.DumpRenderTree to ${PRODUCT_BUNDLE_IDENTIFIER}.
* DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Set
PRODUCT_BUNDLE_IDENTIFIER to org.webkit.DumpRenderTree.
* DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Set
PRODUCT_BUNDLE_IDENTIFIER to com.apple.testnetscapeplugin.
* MiniBrowser/Configurations/MiniBrowser.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
org.webkit.$(PRODUCT_NAME:rfc1034identifier).
* MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
com.apple.$(PRODUCT_NAME:rfc1034identifier).
* MiniBrowser/mac/Bundle/Info.plist: Changed CFBundleIdentifier's value from
com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
* MiniBrowser/mac/Info.plist: Changed CFBundleIdentifier's value from
org.webkit.${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
* TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
com.apple.$(PRODUCT_NAME:rfc1034identifier).
* TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
com.apple.$(PRODUCT_NAME:rfc1034identifier).
* TestWebKitAPI/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
com.yourcompany.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
* TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added a CFBundleIdentifier key with the
value ${PRODUCT_BUNDLE_IDENTIFIER}.
* WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
com.apple.WebKitTestRunner.InjectedBundle.
* WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Set
PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier).
* WebKitTestRunner/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
com.apple.WebKitTestRunner.InjectedBundle to ${PRODUCT_BUNDLE_IDENTIFIER}.
* WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Changed
CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME:rfc1034identifier} to
${PRODUCT_BUNDLE_IDENTIFIER}.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (209287 => 209288)


--- trunk/Source/_javascript_Core/ChangeLog	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-12-03 01:31:48 UTC (rev 209288)
@@ -1,3 +1,15 @@
+2016-12-02  Andy Estes  <[email protected]>
+
+        [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
+        https://bugs.webkit.org/show_bug.cgi?id=164492
+
+        Reviewed by Dan Bernstein.
+
+        * Configurations/_javascript_Core.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
+        com.apple.$(PRODUCT_NAME:rfc1034identifier).
+        * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
+        ${PRODUCT_BUNDLE_IDENTIFIER}.
+
 2016-12-02  JF Bastien  <[email protected]>
 
         WebAssembly: mark WasmOps.h as private

Modified: trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig (209287 => 209288)


--- trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -51,6 +51,7 @@
 INSTALL_PATH = $(_javascript_CORE_FRAMEWORKS_DIR);
 DYLIB_INSTALL_NAME_BASE = $(NORMAL_JAVASCRIPTCORE_FRAMEWORKS_DIR);
 PRODUCT_NAME = _javascript_Core;
+PRODUCT_BUNDLE_IDENTIFIER = com.apple.$(PRODUCT_NAME:rfc1034identifier);
 
 INSTALLHDRS_SCRIPT_PHASE = YES;
 

Modified: trunk/Source/_javascript_Core/Info.plist (209287 => 209288)


--- trunk/Source/_javascript_Core/Info.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/_javascript_Core/Info.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -9,7 +9,7 @@
 	<key>CFBundleGetInfoString</key>
 	<string>${BUNDLE_VERSION}, Copyright 2003-2016 Apple Inc.; Copyright 1999-2001 Harri Porten &lt;[email protected]&gt;; Copyright 2001 Peter Kelly &lt;[email protected]&gt;; Copyright 1997-2005 University of Cambridge; Copyright 1991, 2000, 2001 by Lucent Technologies.</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.apple.${PRODUCT_NAME}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

Modified: trunk/Source/WebCore/ChangeLog (209287 => 209288)


--- trunk/Source/WebCore/ChangeLog	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebCore/ChangeLog	2016-12-03 01:31:48 UTC (rev 209288)
@@ -1,3 +1,15 @@
+2016-12-02  Andy Estes  <[email protected]>
+
+        [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
+        https://bugs.webkit.org/show_bug.cgi?id=164492
+
+        Reviewed by Dan Bernstein.
+
+        * Configurations/WebCore.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
+        com.apple.$(PRODUCT_NAME:rfc1034identifier).
+        * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
+        ${PRODUCT_BUNDLE_IDENTIFIER}.
+
 2016-12-02  Chris Dumez  <[email protected]>
 
         HTML Interactive Form Validation popovers do not show in iOS WKWebViews

Modified: trunk/Source/WebCore/Configurations/WebCore.xcconfig (209287 => 209288)


--- trunk/Source/WebCore/Configurations/WebCore.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebCore/Configurations/WebCore.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -56,6 +56,7 @@
 INSTALLHDRS_COPY_PHASE = YES;
 INSTALLHDRS_SCRIPT_PHASE = YES;
 PRODUCT_NAME = WebCore;
+PRODUCT_BUNDLE_IDENTIFIER = com.apple.$(PRODUCT_NAME:rfc1034identifier);
 UNEXPORTED_SYMBOLS_FILE = Configurations/WebCore.unexp;
 
 WK_PREFIXED_IPHONEOS_DEPLOYMENT_TARGET = V$(IPHONEOS_DEPLOYMENT_TARGET);

Modified: trunk/Source/WebCore/Info.plist (209287 => 209288)


--- trunk/Source/WebCore/Info.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebCore/Info.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -9,7 +9,7 @@
 	<key>CFBundleGetInfoString</key>
 	<string>${BUNDLE_VERSION}, Copyright 2003-2016 Apple Inc.; Copyright 1997 Martin Jones &lt;[email protected]&gt;; Copyright 1998, 1999 Torben Weis &lt;[email protected]&gt;; Copyright 1998, 1999, 2002 Waldo Bastian &lt;[email protected]&gt;; Copyright 1998-2000 Lars Knoll &lt;[email protected]&gt;; Copyright 1999, 2001 Antti Koivisto &lt;[email protected]&gt;; Copyright 1999-2001 Harri Porten &lt;[email protected]&gt;; Copyright 2000 Simon Hausmann &lt;[email protected]&gt;; Copyright 2000, 2001 Dirk Mueller &lt;[email protected]&gt;; Copyright 2000, 2001 Peter Kelly &lt;[email protected]&gt;; Copyright 2000 Daniel Molkentin &lt;[email protected]&gt;; Copyright 2000 Stefan Schimanski &lt;[email protected]&gt;; Copyright 1998-2000 Netscape Communications Corporation; Copyright 1998, 1999, 2000 Thai Open Source Software Center Ltd and Clark Cooper; Copyright 2001, 2002 Expat maintainers.
 </string>
 	<key>CFBundleIdentifier</key>
-	<string>com.apple.${PRODUCT_NAME}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

Modified: trunk/Source/WebInspectorUI/ChangeLog (209287 => 209288)


--- trunk/Source/WebInspectorUI/ChangeLog	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-12-03 01:31:48 UTC (rev 209288)
@@ -1,3 +1,15 @@
+2016-12-02  Andy Estes  <[email protected]>
+
+        [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
+        https://bugs.webkit.org/show_bug.cgi?id=164492
+
+        Reviewed by Dan Bernstein.
+
+        * Configurations/WebInspectorUIFramework.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
+        com.apple.$(PRODUCT_NAME:rfc1034identifier).
+        * Info.plist: Changed CFBundleIdentifier's value from
+        com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
+
 2016-12-02  Nikita Vasilyev  <[email protected]>
 
         REGRESSION (r192344): Web Inspector: Turning off Code Coverage or Type Profiler logs an error

Modified: trunk/Source/WebInspectorUI/Configurations/WebInspectorUIFramework.xcconfig (209287 => 209288)


--- trunk/Source/WebInspectorUI/Configurations/WebInspectorUIFramework.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebInspectorUI/Configurations/WebInspectorUIFramework.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -10,6 +10,7 @@
 INSTALL_PATH_YES = $(WK_OVERRIDE_FRAMEWORKS_DIR);
 DYLIB_INSTALL_NAME_BASE = $(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
 PRODUCT_NAME = WebInspectorUI;
+PRODUCT_BUNDLE_IDENTIFIER = com.apple.$(PRODUCT_NAME:rfc1034identifier);
 
 GCC_DYNAMIC_NO_PIC = NO;
 GCC_PRECOMPILE_PREFIX_HEADER = YES;

Modified: trunk/Source/WebInspectorUI/Info.plist (209287 => 209288)


--- trunk/Source/WebInspectorUI/Info.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebInspectorUI/Info.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -7,7 +7,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.apple.${PRODUCT_NAME:rfc1034identifier}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

Modified: trunk/Source/WebKit/mac/ChangeLog (209287 => 209288)


--- trunk/Source/WebKit/mac/ChangeLog	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit/mac/ChangeLog	2016-12-03 01:31:48 UTC (rev 209288)
@@ -1,3 +1,15 @@
+2016-12-02  Andy Estes  <[email protected]>
+
+        [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
+        https://bugs.webkit.org/show_bug.cgi?id=164492
+
+        Reviewed by Dan Bernstein.
+
+        * Configurations/WebKitLegacy.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
+        com.apple.$(PRODUCT_NAME:rfc1034identifier).
+        * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
+        ${PRODUCT_BUNDLE_IDENTIFIER}.
+
 2016-12-02  Chris Dumez  <[email protected]>
 
         Regression(r209252): HTML interactive validation should not be enabled on iOS WK1 yet

Modified: trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig (209287 => 209288)


--- trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -70,6 +70,7 @@
 INSTALLHDRS_COPY_PHASE = YES;
 INSTALLHDRS_SCRIPT_PHASE = YES;
 PRODUCT_NAME = WebKitLegacy;
+PRODUCT_BUNDLE_IDENTIFIER = com.apple.$(PRODUCT_NAME:rfc1034identifier);
 UMBRELLA_FRAMEWORKS_DIR = $(PRODUCTION_FRAMEWORKS_DIR)/WebKit.framework/Versions/A/Frameworks;
 
 OTHER_LDFLAGS[sdk=iphone*] = $(inherited) -lobjc -lsqlite3 -framework CFNetwork -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework Foundation -framework GraphicsServices -framework ImageIO -framework OpenGLES -framework MobileCoreServices -lMobileGestalt;

Modified: trunk/Source/WebKit/mac/Info.plist (209287 => 209288)


--- trunk/Source/WebKit/mac/Info.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit/mac/Info.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -9,7 +9,7 @@
 	<key>CFBundleGetInfoString</key>
 	<string>${BUNDLE_VERSION}, Copyright 2003-2016 Apple Inc.</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.apple.${PRODUCT_NAME}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

Modified: trunk/Source/WebKit2/ChangeLog (209287 => 209288)


--- trunk/Source/WebKit2/ChangeLog	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit2/ChangeLog	2016-12-03 01:31:48 UTC (rev 209288)
@@ -1,3 +1,32 @@
+2016-12-02  Andy Estes  <[email protected]>
+
+        [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
+        https://bugs.webkit.org/show_bug.cgi?id=164492
+
+        Reviewed by Dan Bernstein.
+
+        * Configurations/DatabaseService.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
+        $(PRODUCT_NAME).
+        * Configurations/NetworkService.xcconfig: Ditto.
+        * Configurations/PluginService.32.xcconfig: Ditto.
+        * Configurations/PluginService.64.xcconfig: Ditto.
+        * Configurations/WebContentService.xcconfig: Ditto.
+        * Configurations/WebKit.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
+        com.apple.$(PRODUCT_NAME:rfc1034identifier).
+        * DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist: Changed
+        CFBundleIdentifier's value from ${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
+        * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
+        ${PRODUCT_BUNDLE_IDENTIFIER}.
+        * NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX-10.9-10.10.plist: Changed
+        CFBundleIdentifier's value from ${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
+        * NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist: Ditto.
+        * NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist: Ditto.
+        * PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64-10.9-10.10.Info.plist: Ditto.
+        * PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist: Ditto.
+        * WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX-10.9-10.10.plist: Ditto.
+        * WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist: Ditto.
+        * WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist: Ditto.
+
 2016-12-02  Brent Fulgham  <[email protected]>
 
         [Mac] Update sandbox profiles to use modern syntax and avoid duplication

Modified: trunk/Source/WebKit2/Configurations/DatabaseService.xcconfig (209287 => 209288)


--- trunk/Source/WebKit2/Configurations/DatabaseService.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit2/Configurations/DatabaseService.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -26,4 +26,5 @@
 WK_XPC_SERVICE_IOS_ENTITLEMENTS_BASE = Databases-iOS;
 
 PRODUCT_NAME = com.apple.WebKit.Databases;
+PRODUCT_BUNDLE_IDENTIFIER = $(PRODUCT_NAME);
 INFOPLIST_FILE = DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist;

Modified: trunk/Source/WebKit2/Configurations/NetworkService.xcconfig (209287 => 209288)


--- trunk/Source/WebKit2/Configurations/NetworkService.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit2/Configurations/NetworkService.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -26,6 +26,7 @@
 WK_XPC_SERVICE_IOS_ENTITLEMENTS_BASE = Network-iOS;
 
 PRODUCT_NAME = com.apple.WebKit.Networking;
+PRODUCT_BUNDLE_IDENTIFIER = $(PRODUCT_NAME);
 INFOPLIST_FILE[sdk=iphone*] = NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist;
 INFOPLIST_FILE[sdk=macosx*] = NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX$(WK_XPC_SERVICE_INFOPLIST_SUFFIX).plist;
 

Modified: trunk/Source/WebKit2/Configurations/PluginService.32.xcconfig (209287 => 209288)


--- trunk/Source/WebKit2/Configurations/PluginService.32.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit2/Configurations/PluginService.32.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -26,6 +26,7 @@
 VALID_ARCHS_macosx_NO = i386;
 
 PRODUCT_NAME = com.apple.WebKit.Plugin.32;
+PRODUCT_BUNDLE_IDENTIFIER = $(PRODUCT_NAME);
 INFOPLIST_FILE = PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64$(WK_XPC_SERVICE_INFOPLIST_SUFFIX).Info.plist;
 
 OTHER_LDFLAGS = $(OTHER_LDFLAGS) $(OTHER_LDFLAGS_PLATFORM) $(OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH) $(WK_RELOCATABLE_FRAMEWORKS_LDFLAGS);

Modified: trunk/Source/WebKit2/Configurations/PluginService.64.xcconfig (209287 => 209288)


--- trunk/Source/WebKit2/Configurations/PluginService.64.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit2/Configurations/PluginService.64.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -26,6 +26,7 @@
 VALID_ARCHS_macosx_NO = x86_64;
 
 PRODUCT_NAME = com.apple.WebKit.Plugin.64;
+PRODUCT_BUNDLE_IDENTIFIER = $(PRODUCT_NAME);
 INFOPLIST_FILE = PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64$(WK_XPC_SERVICE_INFOPLIST_SUFFIX).Info.plist;
 
 OTHER_LDFLAGS = $(OTHER_LDFLAGS) $(OTHER_LDFLAGS_PLATFORM) $(OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH) $(WK_RELOCATABLE_FRAMEWORKS_LDFLAGS);

Modified: trunk/Source/WebKit2/Configurations/WebContentService.xcconfig (209287 => 209288)


--- trunk/Source/WebKit2/Configurations/WebContentService.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit2/Configurations/WebContentService.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -30,6 +30,7 @@
 OTHER_CODE_SIGN_FLAGS[sdk=macosx*] = $(WK_XPC_DOMAIN_EXTENSION_CODE_SIGN_FLAGS);
 
 PRODUCT_NAME = com.apple.WebKit.WebContent;
+PRODUCT_BUNDLE_IDENTIFIER = $(PRODUCT_NAME);
 INFOPLIST_FILE[sdk=iphone*] = WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist;
 INFOPLIST_FILE[sdk=macosx*] = WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX$(WK_XPC_SERVICE_INFOPLIST_SUFFIX).plist;
 

Modified: trunk/Source/WebKit2/Configurations/WebKit.xcconfig (209287 => 209288)


--- trunk/Source/WebKit2/Configurations/WebKit.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit2/Configurations/WebKit.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -24,6 +24,7 @@
 #include "BaseTarget.xcconfig"
 
 PRODUCT_NAME = WebKit;
+PRODUCT_BUNDLE_IDENTIFIER = com.apple.$(PRODUCT_NAME:rfc1034identifier);
 INFOPLIST_FILE = Info.plist;
 
 DEFINES_MODULE=YES;

Modified: trunk/Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist (209287 => 209288)


--- trunk/Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -9,7 +9,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>${PRODUCT_NAME}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

Modified: trunk/Source/WebKit2/Info.plist (209287 => 209288)


--- trunk/Source/WebKit2/Info.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit2/Info.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -9,7 +9,7 @@
 	<key>CFBundleGetInfoString</key>
 	<string>${BUNDLE_VERSION}, Copyright 2003-2016 Apple Inc.</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.apple.${PRODUCT_NAME}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

Modified: trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX-10.9-10.10.plist (209287 => 209288)


--- trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX-10.9-10.10.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX-10.9-10.10.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -9,7 +9,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>${PRODUCT_NAME}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

Modified: trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist (209287 => 209288)


--- trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -9,7 +9,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>${PRODUCT_NAME}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

Modified: trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist (209287 => 209288)


--- trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -9,7 +9,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>${PRODUCT_NAME}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

Modified: trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64-10.9-10.10.Info.plist (209287 => 209288)


--- trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64-10.9-10.10.Info.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64-10.9-10.10.Info.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -9,7 +9,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>${PRODUCT_NAME}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

Modified: trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist (209287 => 209288)


--- trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -9,7 +9,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>${PRODUCT_NAME}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

Modified: trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX-10.9-10.10.plist (209287 => 209288)


--- trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX-10.9-10.10.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX-10.9-10.10.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -11,7 +11,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>${PRODUCT_NAME}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

Modified: trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist (209287 => 209288)


--- trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -11,7 +11,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>${PRODUCT_NAME}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

Modified: trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist (209287 => 209288)


--- trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -11,7 +11,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>${PRODUCT_NAME}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

Modified: trunk/Tools/ChangeLog (209287 => 209288)


--- trunk/Tools/ChangeLog	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Tools/ChangeLog	2016-12-03 01:31:48 UTC (rev 209288)
@@ -1,3 +1,46 @@
+2016-12-02  Andy Estes  <[email protected]>
+
+        [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
+        https://bugs.webkit.org/show_bug.cgi?id=164492
+
+        Reviewed by Dan Bernstein.
+
+        * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Changed CFBundleIdentifier's value from
+        com.apple.testnetscapeplugin to ${PRODUCT_BUNDLE_IDENTIFIER}.
+        * DumpRenderTree/ios/Info.plist: Changed CFBundleIdentifier's value from
+        org.webkit.DumpRenderTree to ${PRODUCT_BUNDLE_IDENTIFIER}.
+        * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Set
+        PRODUCT_BUNDLE_IDENTIFIER to org.webkit.DumpRenderTree.
+        * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Set
+        PRODUCT_BUNDLE_IDENTIFIER to com.apple.testnetscapeplugin.
+        * MiniBrowser/Configurations/MiniBrowser.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
+        org.webkit.$(PRODUCT_NAME:rfc1034identifier).
+        * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
+        com.apple.$(PRODUCT_NAME:rfc1034identifier).
+        * MiniBrowser/mac/Bundle/Info.plist: Changed CFBundleIdentifier's value from
+        com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
+        * MiniBrowser/mac/Info.plist: Changed CFBundleIdentifier's value from
+        org.webkit.${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
+        * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
+        InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
+        com.apple.$(PRODUCT_NAME:rfc1034identifier).
+        * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
+        com.apple.$(PRODUCT_NAME:rfc1034identifier).
+        * TestWebKitAPI/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
+        com.yourcompany.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
+        * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added a CFBundleIdentifier key with the
+        value ${PRODUCT_BUNDLE_IDENTIFIER}.
+        * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
+        InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
+        com.apple.WebKitTestRunner.InjectedBundle.
+        * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Set
+        PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier).
+        * WebKitTestRunner/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
+        com.apple.WebKitTestRunner.InjectedBundle to ${PRODUCT_BUNDLE_IDENTIFIER}.
+        * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Changed
+        CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME:rfc1034identifier} to
+        ${PRODUCT_BUNDLE_IDENTIFIER}.
+
 2016-12-02  Brady Eidson  <[email protected]>
 
         Make IndexedDB.WebProcessKillIDBCleanup even more reliable.

Modified: trunk/Tools/DumpRenderTree/TestNetscapePlugIn/mac/Info.plist (209287 => 209288)


--- trunk/Tools/DumpRenderTree/TestNetscapePlugIn/mac/Info.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Tools/DumpRenderTree/TestNetscapePlugIn/mac/Info.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -11,7 +11,7 @@
 	<key>CFBundleIconFile</key>
 	<string></string>
 	<key>CFBundleIdentifier</key>
-	<string>com.apple.testnetscapeplugin</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundlePackageType</key>

Modified: trunk/Tools/DumpRenderTree/ios/Info.plist (209287 => 209288)


--- trunk/Tools/DumpRenderTree/ios/Info.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Tools/DumpRenderTree/ios/Info.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -9,7 +9,7 @@
 	<key>CFBundleExecutable</key>
 	<string>DumpRenderTree</string>
 	<key>CFBundleIdentifier</key>
-	<string>org.webkit.DumpRenderTree</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

Modified: trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig (209287 => 209288)


--- trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -38,5 +38,6 @@
 EXCLUDED_SOURCE_FILE_NAMES[sdk=watch*] = ios/Launch.storyboard;
 
 PRODUCT_NAME = DumpRenderTree;
+PRODUCT_BUNDLE_IDENTIFIER = org.webkit.DumpRenderTree;
 
 TARGETED_DEVICE_FAMILY = 1,2;

Modified: trunk/Tools/DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig (209287 => 209288)


--- trunk/Tools/DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -24,6 +24,7 @@
 #include "BaseTarget.xcconfig"
 
 PRODUCT_NAME = TestNetscapePlugIn
+PRODUCT_BUNDLE_IDENTIFIER = com.apple.testnetscapeplugin
 WRAPPER_EXTENSION = plugin
 INFOPLIST_FILE = TestNetscapePlugIn.subproj/Info.plist
 INSTALL_PATH = "$(USER_LIBRARY_DIR)/Plugins"

Modified: trunk/Tools/MiniBrowser/Configurations/MiniBrowser.xcconfig (209287 => 209288)


--- trunk/Tools/MiniBrowser/Configurations/MiniBrowser.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Tools/MiniBrowser/Configurations/MiniBrowser.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -22,6 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 PRODUCT_NAME = MiniBrowser
+PRODUCT_BUNDLE_IDENTIFIER = org.webkit.$(PRODUCT_NAME:rfc1034identifier)
 GCC_PREFIX_HEADER = mac/MiniBrowser_Prefix.pch
 INFOPLIST_FILE = mac/Info.plist
 EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = *

Modified: trunk/Tools/MiniBrowser/Configurations/MiniBrowserBundle.xcconfig (209287 => 209288)


--- trunk/Tools/MiniBrowser/Configurations/MiniBrowserBundle.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Tools/MiniBrowser/Configurations/MiniBrowserBundle.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -22,6 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 PRODUCT_NAME = MiniBrowser
+PRODUCT_BUNDLE_IDENTIFIER = com.apple.$(PRODUCT_NAME:rfc1034identifier)
 GCC_PREFIX_HEADER = mac/Bundle/MiniBrowserBundle_Prefix.pch
 INFOPLIST_FILE = mac/Bundle/Info.plist
 EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = *

Modified: trunk/Tools/MiniBrowser/mac/Bundle/Info.plist (209287 => 209288)


--- trunk/Tools/MiniBrowser/mac/Bundle/Info.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Tools/MiniBrowser/mac/Bundle/Info.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -9,7 +9,7 @@
 	<key>CFBundleIconFile</key>
 	<string></string>
 	<key>CFBundleIdentifier</key>
-	<string>com.apple.${PRODUCT_NAME:rfc1034identifier}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

Modified: trunk/Tools/MiniBrowser/mac/Info.plist (209287 => 209288)


--- trunk/Tools/MiniBrowser/mac/Info.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Tools/MiniBrowser/mac/Info.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -9,7 +9,7 @@
 	<key>CFBundleIconFile</key>
 	<string>MiniBrowser</string>
 	<key>CFBundleIdentifier</key>
-	<string>org.webkit.${PRODUCT_NAME}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

Modified: trunk/Tools/TestWebKitAPI/Configurations/InjectedBundle.xcconfig (209287 => 209288)


--- trunk/Tools/TestWebKitAPI/Configurations/InjectedBundle.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Tools/TestWebKitAPI/Configurations/InjectedBundle.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -21,7 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
+INFOPLIST_FILE = InjectedBundle-Info.plist;
 PRODUCT_NAME = InjectedBundleTestWebKitAPI;
+PRODUCT_BUNDLE_IDENTIFIER = com.apple.$(PRODUCT_NAME:rfc1034identifier);
 
 FRAMEWORK_AND_LIBRARY_LDFLAGS[sdk=iphone*] = -lobjc -framework UIKit;
 FRAMEWORK_AND_LIBRARY_LDFLAGS[sdk=macosx*] = -framework _javascript_Core -framework WebKit -framework CoreGraphics -framework Cocoa;

Modified: trunk/Tools/TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig (209287 => 209288)


--- trunk/Tools/TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Tools/TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -27,6 +27,7 @@
 
 INFOPLIST_FILE = cocoa/WebProcessPlugIn/Info.plist;
 PRODUCT_NAME = TestWebKitAPI;
+PRODUCT_BUNDLE_IDENTIFIER = com.apple.$(PRODUCT_NAME:rfc1034identifier);
 EXECUTABLE_SUFFIX = .bundle;
 WRAPPER_EXTENSION = wkbundle;
 OTHER_LDFLAGS = $(inherited) -framework _javascript_Core -framework WebKit -lWebCoreTestSupport;

Modified: trunk/Tools/TestWebKitAPI/InjectedBundle-Info.plist (209287 => 209288)


--- trunk/Tools/TestWebKitAPI/InjectedBundle-Info.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Tools/TestWebKitAPI/InjectedBundle-Info.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -7,7 +7,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.yourcompany.${PRODUCT_NAME:rfc1034identifier}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundlePackageType</key>

Modified: trunk/Tools/TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist (209287 => 209288)


--- trunk/Tools/TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Tools/TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -2,6 +2,8 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
+	<key>CFBundleIdentifier</key>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleDevelopmentRegion</key>
 	<string>en</string>
 	<key>CFBundleExecutable</key>

Modified: trunk/Tools/WebKitTestRunner/Configurations/InjectedBundle.xcconfig (209287 => 209288)


--- trunk/Tools/WebKitTestRunner/Configurations/InjectedBundle.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Tools/WebKitTestRunner/Configurations/InjectedBundle.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -23,8 +23,10 @@
 
 #include "BaseTarget.xcconfig"
 
+INFOPLIST_FILE = InjectedBundle-Info.plist;
 LD_RUNPATH_SEARCH_PATHS = "@loader_path/../../..";
 PRODUCT_NAME = WebKitTestRunnerInjectedBundle;
+PRODUCT_BUNDLE_IDENTIFIER = com.apple.WebKitTestRunner.InjectedBundle;
 
 SKIP_INSTALL = NO;
 

Modified: trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig (209287 => 209288)


--- trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig	2016-12-03 01:31:48 UTC (rev 209288)
@@ -26,6 +26,7 @@
 #include "BaseTarget.xcconfig"
 
 PRODUCT_NAME = WebKitTestRunner;
+PRODUCT_BUNDLE_IDENTIFIER = org.webkit.$(PRODUCT_NAME:rfc1034identifier);
 
 GCC_ENABLE_OBJC_EXCEPTIONS = YES;
 

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle-Info.plist (209287 => 209288)


--- trunk/Tools/WebKitTestRunner/InjectedBundle-Info.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle-Info.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -7,7 +7,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.apple.WebKitTestRunner.InjectedBundle</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundlePackageType</key>

Modified: trunk/Tools/WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist (209287 => 209288)


--- trunk/Tools/WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist	2016-12-03 01:20:48 UTC (rev 209287)
+++ trunk/Tools/WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist	2016-12-03 01:31:48 UTC (rev 209288)
@@ -9,7 +9,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>org.webkit.${PRODUCT_NAME:rfc1034identifier}</string>
+	<string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to