Title: [209344] trunk/LayoutTests
Revision
209344
Author
[email protected]
Date
2016-12-05 12:51:55 -0800 (Mon, 05 Dec 2016)

Log Message

[CSS Parser] Fix flex property parsing test
https://bugs.webkit.org/show_bug.cgi?id=165402

Reviewed by Simon Fraser.

flex-grow and flex-shrink must occur together. They cannot be before and after
the flex-basis. Since this test is about valid property declarations, just fix it
by removing the invalid ones.

* css3/flexbox/flex-property-parsing-expected.txt:
* css3/flexbox/flex-property-parsing.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (209343 => 209344)


--- trunk/LayoutTests/ChangeLog	2016-12-05 20:38:39 UTC (rev 209343)
+++ trunk/LayoutTests/ChangeLog	2016-12-05 20:51:55 UTC (rev 209344)
@@ -1,3 +1,17 @@
+2016-12-05  Dave Hyatt  <[email protected]>
+
+        [CSS Parser] Fix flex property parsing test
+        https://bugs.webkit.org/show_bug.cgi?id=165402
+
+        Reviewed by Simon Fraser.
+
+        flex-grow and flex-shrink must occur together. They cannot be before and after
+        the flex-basis. Since this test is about valid property declarations, just fix it
+        by removing the invalid ones.
+
+        * css3/flexbox/flex-property-parsing-expected.txt:
+        * css3/flexbox/flex-property-parsing.html:
+
 2016-12-05  Ryan Haddad  <[email protected]>
 
         Marking media/modern-media-controls/seek-backward-support/seek-backward-support.html as flaky on mac-wk1.

Modified: trunk/LayoutTests/css3/flexbox/flex-property-parsing-expected.txt (209343 => 209344)


--- trunk/LayoutTests/css3/flexbox/flex-property-parsing-expected.txt	2016-12-05 20:38:39 UTC (rev 209343)
+++ trunk/LayoutTests/css3/flexbox/flex-property-parsing-expected.txt	2016-12-05 20:51:55 UTC (rev 209344)
@@ -65,8 +65,6 @@
 PASS getComputedStyle(flexitem).webkitFlex is "1.75 2 3px"
 PASS flexitem.style.webkitFlex is "1 2 3px"
 PASS getComputedStyle(flexitem).webkitFlex is "1 2 3px"
-PASS flexitem.style.webkitFlex is "1 2 3px"
-PASS getComputedStyle(flexitem).webkitFlex is "1 2 3px"
 PASS flexitem.style.webkitFlex is "0 0 auto"
 PASS getComputedStyle(flexitem).webkitFlex is "0 0 auto"
 PASS flexitem.style.webkitFlex is "0 1 auto"
@@ -75,8 +73,6 @@
 PASS getComputedStyle(flexitem).webkitFlex is "3 1 auto"
 PASS flexitem.style.webkitFlex is "0 1 0px"
 PASS getComputedStyle(flexitem).webkitFlex is "0 1 0px"
-PASS flexitem.style.webkitFlex is "0 0 0px"
-PASS getComputedStyle(flexitem).webkitFlex is "0 0 0px"
 PASS flexitem.style.webkitFlex is "0 0 auto"
 PASS getComputedStyle(flexitem).webkitFlex is "0 0 auto"
 PASS flexitem.style.webkitFlex is "0 0 auto"

Modified: trunk/LayoutTests/css3/flexbox/flex-property-parsing.html (209343 => 209344)


--- trunk/LayoutTests/css3/flexbox/flex-property-parsing.html	2016-12-05 20:38:39 UTC (rev 209343)
+++ trunk/LayoutTests/css3/flexbox/flex-property-parsing.html	2016-12-05 20:51:55 UTC (rev 209344)
@@ -137,10 +137,6 @@
 shouldBeEqualToString('flexitem.style.webkitFlex', '1.75 2 3px');
 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1.75 2 3px');
 
-flexitem.style.webkitFlex = '1 3px 2';
-shouldBeEqualToString('flexitem.style.webkitFlex', '1 2 3px');
-shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1 2 3px');
-
 flexitem.style.webkitFlex = '3px 1 2';
 shouldBeEqualToString('flexitem.style.webkitFlex', '1 2 3px');
 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1 2 3px');
@@ -161,10 +157,6 @@
 shouldBeEqualToString('flexitem.style.webkitFlex', '0 1 0px');
 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 1 0px');
 
-flexitem.style.webkitFlex = '0 0px 0';
-shouldBeEqualToString('flexitem.style.webkitFlex', '0 0 0px');
-shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 0px');
-
 flexitem.style.webkitFlex = 'none';
 flexitem.style.webkitFlex = '1 2 3'; // Invalid, return previous value.
 shouldBeEqualToString('flexitem.style.webkitFlex', '0 0 auto');
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to