Title: [209362] trunk/Source/_javascript_Core
Revision
209362
Author
[email protected]
Date
2016-12-05 15:38:36 -0800 (Mon, 05 Dec 2016)

Log Message

2016-12-05  Geoffrey Garen  <[email protected]>

        Fixed a bug in my last patch.

        Unreviewed.

        * bytecode/UnlinkedFunctionExecutable.h: Restore the conversion to
        one-based counting.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (209361 => 209362)


--- trunk/Source/_javascript_Core/ChangeLog	2016-12-05 23:27:59 UTC (rev 209361)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-12-05 23:38:36 UTC (rev 209362)
@@ -1,5 +1,14 @@
 2016-12-05  Geoffrey Garen  <[email protected]>
 
+        Fixed a bug in my last patch.
+
+        Unreviewed.
+
+        * bytecode/UnlinkedFunctionExecutable.h: Restore the conversion to
+        one-based counting.
+
+2016-12-05  Geoffrey Garen  <[email protected]>
+
         Moved start and end column linking into helper functions
         https://bugs.webkit.org/show_bug.cgi?id=165422
 

Modified: trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.h (209361 => 209362)


--- trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.h	2016-12-05 23:27:59 UTC (rev 209361)
+++ trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.h	2016-12-05 23:38:36 UTC (rev 209362)
@@ -90,7 +90,8 @@
 
     unsigned lineCount() const { return m_lineCount; }
     unsigned linkedStartColumn(unsigned parentStartColumn) const { return m_unlinkedBodyStartColumn + (!m_firstLineOffset ? parentStartColumn : 1); }
-    unsigned linkedEndColumn(unsigned startColumn) const { return m_lineCount ? m_unlinkedBodyEndColumn : startColumn + m_unlinkedBodyEndColumn; }
+    unsigned linkedEndColumn(unsigned startColumn) const { return m_unlinkedBodyEndColumn + (!m_lineCount ? startColumn : 1); }
+
     unsigned unlinkedFunctionNameStart() const { return m_unlinkedFunctionNameStart; }
     unsigned unlinkedBodyStartColumn() const { return m_unlinkedBodyStartColumn; }
     unsigned unlinkedBodyEndColumn() const { return m_unlinkedBodyEndColumn; }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to