Title: [209374] trunk/LayoutTests
Revision
209374
Author
[email protected]
Date
2016-12-05 18:30:38 -0800 (Mon, 05 Dec 2016)

Log Message

[CSS Parser] Tweak more layout tests to pass
https://bugs.webkit.org/show_bug.cgi?id=165447

Reviewed by Zalan Bujtas.

* TestExpectations:
Add a few more tests to avoid.

* fast/css/parsing-font-variant-ligatures-expected.txt:
* fast/css/parsing-font-variant-ligatures.html:
Remove the assumption that multiple occurrences of the
same value are allowed.

* fast/filter-image/parse-filter-image-expected.txt:
* fast/filter-image/parse-filter-image.html:
Change the test to require url(), since you cannot omit it
and expect the filter to parse properly.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (209373 => 209374)


--- trunk/LayoutTests/ChangeLog	2016-12-06 02:19:40 UTC (rev 209373)
+++ trunk/LayoutTests/ChangeLog	2016-12-06 02:30:38 UTC (rev 209374)
@@ -1,3 +1,23 @@
+2016-12-05  Dave Hyatt  <[email protected]>
+
+        [CSS Parser] Tweak more layout tests to pass
+        https://bugs.webkit.org/show_bug.cgi?id=165447
+
+        Reviewed by Zalan Bujtas.
+
+        * TestExpectations:
+        Add a few more tests to avoid.
+
+        * fast/css/parsing-font-variant-ligatures-expected.txt:
+        * fast/css/parsing-font-variant-ligatures.html:
+        Remove the assumption that multiple occurrences of the
+        same value are allowed.
+
+        * fast/filter-image/parse-filter-image-expected.txt:
+        * fast/filter-image/parse-filter-image.html:
+        Change the test to require url(), since you cannot omit it
+        and expect the filter to parse properly.
+
 2016-12-05  Dean Jackson  <[email protected]>
 
         MediaDocuments crash with modern media controls

Modified: trunk/LayoutTests/TestExpectations (209373 => 209374)


--- trunk/LayoutTests/TestExpectations	2016-12-06 02:19:40 UTC (rev 209373)
+++ trunk/LayoutTests/TestExpectations	2016-12-06 02:30:38 UTC (rev 209374)
@@ -1011,6 +1011,7 @@
 webkit.org/b/165195 fast/forms/basic-selects.html [ Pass Failure ]
 webkit.org/b/165195 fast/shadow-dom/slotted-pseudo-element-css-text.html [ Pass Failure ]
 webkit.org/b/165195 fast/inspector-support/style.html [ Pass Failure ]
+webkit.org/b/165195 svg/webarchive/svg-script-subresouces.svg [ Pass Failure ]
 
 # The following layout tests need to be changed when the new CSS Parser is turned on, since they
 # incorrectly indicate failures on valid syntax.
@@ -1057,6 +1058,7 @@
 webkit.org/b/165195 fast/css-grid-layout/grid-auto-flow-get-set.html [ Pass Failure ]
 webkit.org/b/165195 fast/css-grid-layout/grid-columns-rows-get-set.html [ Pass Failure ]
 webkit.org/b/165195 fast/css-grid-layout/non-grid-columns-rows-get-set.html [ Pass Failure ]
+webkit.org/b/165195 fast/masking/parsing-mask.html [ Pass Failure ]
 
 # The following tests match Blink/Chrome, but we're not sure yet what to do with them when the
 # new CSS parser is turned on. The tests may be right, and these may be bugs in Blink/Chrome, or
@@ -1073,4 +1075,5 @@
 # the new CSS Parser turns on.
 webkit.org/b/165195 svg/dom/SVGColor.html [ Pass Failure ]
 webkit.org/b/165195 svg/dom/SVGPaint.html [ Pass Failure ]
+webkit.org/b/165195 svg/dom/rgb-color-parser.html [ Pass Failure ]
 

Modified: trunk/LayoutTests/fast/css/parsing-font-variant-ligatures-expected.txt (209373 => 209374)


--- trunk/LayoutTests/fast/css/parsing-font-variant-ligatures-expected.txt	2016-12-06 02:19:40 UTC (rev 209373)
+++ trunk/LayoutTests/fast/css/parsing-font-variant-ligatures-expected.txt	2016-12-06 02:30:38 UTC (rev 209374)
@@ -13,7 +13,6 @@
 PASS: 'no-historical-ligatures' parsed as 'no-historical-ligatures' and computed to 'no-historical-ligatures'
 PASS: 'historical-ligatures' parsed as 'historical-ligatures' and computed to 'historical-ligatures'
 
-PASS: 'no-common-ligatures no-common-ligatures' parsed as 'no-common-ligatures' and computed to 'no-common-ligatures'
 PASS: 'common-ligatures no-discretionary-ligatures' parsed as 'common-ligatures no-discretionary-ligatures' and computed to 'common-ligatures no-discretionary-ligatures'
 PASS: 'common-ligatures no-discretionary-ligatures historical-ligatures' parsed as 'common-ligatures no-discretionary-ligatures historical-ligatures' and computed to 'common-ligatures no-discretionary-ligatures historical-ligatures'
 PASS: 'common-ligatures no-discretionary-ligatures normal' parsed as '' and computed to 'normal'

Modified: trunk/LayoutTests/fast/css/parsing-font-variant-ligatures.html (209373 => 209374)


--- trunk/LayoutTests/fast/css/parsing-font-variant-ligatures.html	2016-12-06 02:19:40 UTC (rev 209373)
+++ trunk/LayoutTests/fast/css/parsing-font-variant-ligatures.html	2016-12-06 02:30:38 UTC (rev 209374)
@@ -43,7 +43,6 @@
     test('historical-ligatures', 'historical-ligatures', 'historical-ligatures');
 
     log("");
-    test('no-common-ligatures no-common-ligatures', 'no-common-ligatures', 'no-common-ligatures');
     test('common-ligatures no-discretionary-ligatures', 'common-ligatures no-discretionary-ligatures', 'common-ligatures no-discretionary-ligatures');
     test('common-ligatures no-discretionary-ligatures historical-ligatures', 'common-ligatures no-discretionary-ligatures historical-ligatures', 'common-ligatures no-discretionary-ligatures historical-ligatures');
     test('common-ligatures no-discretionary-ligatures normal', '', 'normal');

Modified: trunk/LayoutTests/fast/filter-image/parse-filter-image-expected.txt (209373 => 209374)


--- trunk/LayoutTests/fast/filter-image/parse-filter-image-expected.txt	2016-12-06 02:19:40 UTC (rev 209373)
+++ trunk/LayoutTests/fast/filter-image/parse-filter-image-expected.txt	2016-12-06 02:30:38 UTC (rev 209374)
@@ -80,7 +80,7 @@
 PASS innerStyle("background-image", "filter(linear-gradient(0deg, white -20%, blue, black 120%), hue-rotate(90deg))") is "filter(linear-gradient(0deg, white -20%, blue, black 120%), hue-rotate(90deg))"
 PASS innerStyle("background-image", "filter(-webkit-cross-fade(url(http://image1.png), url(http://image2.png), 50%), contrast(0.5))") is "filter(-webkit-cross-fade(url(http://image1.png/), url(http://image2.png/), 0.5), contrast(0.5))"
 PASS innerStyle("background-image", "filter(url(http://image1.png), brightness(50%))") is "filter(url(http://image1.png/), brightness(50%))"
-PASS innerStyle("background-image", "filter('http://image1.png', brightness(50%))") is "filter(url(http://image1.png/), brightness(50%))"
+PASS innerStyle("background-image", "filter(url('http://image1.png'), brightness(50%))") is "filter(url(http://image1.png/), brightness(50%))"
 PASS innerStyle("border-image-source", "filter(url(http://image1.png), invert(50%))") is "filter(url(http://image1.png/), invert(50%))"
 PASS innerStyle("-webkit-mask-image", "filter(url(http://image1.png), invert(50%))") is "filter(url(http://image1.png/), invert(50%))"
 PASS innerStyle("-webkit-mask-box-image-source", "filter(url(http://image1.png), invert(50%))") is "filter(url(http://image1.png/), invert(50%))"

Modified: trunk/LayoutTests/fast/filter-image/parse-filter-image.html (209373 => 209374)


--- trunk/LayoutTests/fast/filter-image/parse-filter-image.html	2016-12-06 02:19:40 UTC (rev 209373)
+++ trunk/LayoutTests/fast/filter-image/parse-filter-image.html	2016-12-06 02:30:38 UTC (rev 209374)
@@ -353,7 +353,7 @@
     "filter(url(http://image1.png/), brightness(50%))");
 testInner(
     "background-image",
-    "filter('http://image1.png', brightness(50%))",
+    "filter(url('http://image1.png'), brightness(50%))",
     "filter(url(http://image1.png/), brightness(50%))");
 
 // Test different properties, taking CSS Image values.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to