Title: [209415] trunk/Source/WebCore
Revision
209415
Author
[email protected]
Date
2016-12-06 13:40:02 -0800 (Tue, 06 Dec 2016)

Log Message

Add HTML interactive form validation blacklist for some WebKit-specific sites
https://bugs.webkit.org/show_bug.cgi?id=165470
<rdar://problem/29509424>

Reviewed by Simon Fraser.

Add HTML interactive form validation blacklist for some WebKit-specific sites
expecting our old behavior, until they get a chance to be updated.

* html/HTMLFormElement.cpp:
(WebCore::isURLBlacklistedForInteractiveFormValidation):
(WebCore::HTMLFormElement::prepareForSubmission):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (209414 => 209415)


--- trunk/Source/WebCore/ChangeLog	2016-12-06 21:34:38 UTC (rev 209414)
+++ trunk/Source/WebCore/ChangeLog	2016-12-06 21:40:02 UTC (rev 209415)
@@ -1,5 +1,20 @@
 2016-12-06  Chris Dumez  <[email protected]>
 
+        Add HTML interactive form validation blacklist for some WebKit-specific sites
+        https://bugs.webkit.org/show_bug.cgi?id=165470
+        <rdar://problem/29509424>
+
+        Reviewed by Simon Fraser.
+
+        Add HTML interactive form validation blacklist for some WebKit-specific sites
+        expecting our old behavior, until they get a chance to be updated.
+
+        * html/HTMLFormElement.cpp:
+        (WebCore::isURLBlacklistedForInteractiveFormValidation):
+        (WebCore::HTMLFormElement::prepareForSubmission):
+
+2016-12-06  Chris Dumez  <[email protected]>
+
         Unreviewed, rollout r209050.
 
         This change may impact other popovers than the HTML validation one.

Modified: trunk/Source/WebCore/html/HTMLFormElement.cpp (209414 => 209415)


--- trunk/Source/WebCore/html/HTMLFormElement.cpp	2016-12-06 21:34:38 UTC (rev 209414)
+++ trunk/Source/WebCore/html/HTMLFormElement.cpp	2016-12-06 21:40:02 UTC (rev 209415)
@@ -254,6 +254,14 @@
     return false;
 }
 
+static bool isURLBlacklistedForInteractiveFormValidation(const URL& url)
+{
+    // FIXME: Remove this workaround once <rdar://problem/29518605> is fixed.
+    if (url.host() == "idmsa.apple.com")
+        return true;
+    return false;
+}
+
 void HTMLFormElement::prepareForSubmission(Event& event)
 {
     Frame* frame = document().frame();
@@ -263,7 +271,7 @@
     m_isSubmittingOrPreparingForSubmission = true;
     m_shouldSubmit = false;
 
-    bool shouldValidate = document().page() && document().page()->settings().interactiveFormValidationEnabled() && !noValidate();
+    bool shouldValidate = document().page() && document().page()->settings().interactiveFormValidationEnabled() && !noValidate() && !isURLBlacklistedForInteractiveFormValidation(document().url());
 
     HTMLFormControlElement* submitElement = submitElementFromEvent(event);
     if (submitElement && submitElement->formNoValidate())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to