Title: [209421] trunk
- Revision
- 209421
- Author
- [email protected]
- Date
- 2016-12-06 14:31:45 -0800 (Tue, 06 Dec 2016)
Log Message
REGRESSION (Safari 10): Scrolling not working inside height 100% table
https://bugs.webkit.org/show_bug.cgi?id=164366
<rdar://problem/29095535>
Reviewed by Zalan Bujtas.
Source/WebCore:
Added fast/table/overflow-percent-height-regression.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):
This patch wasn't merged correctly from Blink. The value returned needed
to be 0, not unset.
LayoutTests:
* fast/table/overflow-percent-height-regression-expected.html: Added.
* fast/table/overflow-percent-height-regression.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (209420 => 209421)
--- trunk/LayoutTests/ChangeLog 2016-12-06 22:21:36 UTC (rev 209420)
+++ trunk/LayoutTests/ChangeLog 2016-12-06 22:31:45 UTC (rev 209421)
@@ -1,3 +1,14 @@
+2016-12-06 Dave Hyatt <[email protected]>
+
+ REGRESSION (Safari 10): Scrolling not working inside height 100% table
+ https://bugs.webkit.org/show_bug.cgi?id=164366
+ <rdar://problem/29095535>
+
+ Reviewed by Zalan Bujtas.
+
+ * fast/table/overflow-percent-height-regression-expected.html: Added.
+ * fast/table/overflow-percent-height-regression.html: Added.
+
2016-12-06 Ryan Haddad <[email protected]>
Rebaseline fast/shadow-dom/slotted-pseudo-element-css-text.html after r209396.
Added: trunk/LayoutTests/fast/table/overflow-percent-height-regression-expected.html (0 => 209421)
--- trunk/LayoutTests/fast/table/overflow-percent-height-regression-expected.html (rev 0)
+++ trunk/LayoutTests/fast/table/overflow-percent-height-regression-expected.html 2016-12-06 22:31:45 UTC (rev 209421)
@@ -0,0 +1,39 @@
+<!doctype html>
+<head>
+ <style>
+ html, body {
+ height:100%;
+ margin: 0;
+ overflow:hidden;
+ }
+
+ #table1 {
+ width:90%;
+ height:90%;
+ }
+
+ #scrollable {
+ background-color: steelblue;
+ width: 100%;
+ height: 100%;
+ overflow-y: scroll;
+ overflow-x: hidden;
+ }
+ #content {
+ width:100%;
+ height:1000px;
+ background-color:salmon;
+ box-sizing:border-box;
+ }
+ </style>
+</head>
+<body>
+<div id="table1">
+ <div id="scrollable">
+ <div id="content">
+ CONTENT
+ </div>
+ </div>
+
+</div>
+</body>
Added: trunk/LayoutTests/fast/table/overflow-percent-height-regression.html (0 => 209421)
--- trunk/LayoutTests/fast/table/overflow-percent-height-regression.html (rev 0)
+++ trunk/LayoutTests/fast/table/overflow-percent-height-regression.html 2016-12-06 22:31:45 UTC (rev 209421)
@@ -0,0 +1,42 @@
+<!doctype html>
+<head>
+ <style>
+ html, body {
+ height:100%;
+ margin: 0;
+ overflow:hidden;
+ }
+
+ #table1 {
+ width:90%;
+ height:90%;
+ }
+
+ #scrollable {
+ background-color: steelblue;
+ width: 100%;
+ height: 100%;
+ overflow-y: scroll;
+ overflow-x: hidden;
+ }
+
+ #content {
+ width:100%;
+ height:1000px;
+ background-color:salmon;
+ }
+ </style>
+</head>
+<body>
+<table id="table1" cellpadding="0" cellspacing="0">
+ <tr>
+ <td>
+ <div id="scrollable">
+ <div id="content">
+ CONTENT
+ </div>
+ </div>
+ </td>
+ </tr>
+</table>
+</body>
Modified: trunk/Source/WebCore/ChangeLog (209420 => 209421)
--- trunk/Source/WebCore/ChangeLog 2016-12-06 22:21:36 UTC (rev 209420)
+++ trunk/Source/WebCore/ChangeLog 2016-12-06 22:31:45 UTC (rev 209421)
@@ -1,3 +1,18 @@
+2016-12-06 Dave Hyatt <[email protected]>
+
+ REGRESSION (Safari 10): Scrolling not working inside height 100% table
+ https://bugs.webkit.org/show_bug.cgi?id=164366
+ <rdar://problem/29095535>
+
+ Reviewed by Zalan Bujtas.
+
+ Added fast/table/overflow-percent-height-regression.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::computePercentageLogicalHeight):
+ This patch wasn't merged correctly from Blink. The value returned needed
+ to be 0, not unset.
+
2016-12-06 Sam Weinig <[email protected]>
REGRESSION: media/track LayoutTests are flaky failures
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (209420 => 209421)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2016-12-06 22:21:36 UTC (rev 209420)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2016-12-06 22:31:45 UTC (rev 209421)
@@ -3014,7 +3014,7 @@
// don't care if the cell specified a height or not. We just always make ourselves
// be a percentage of the cell's current content height.
if (!cb->hasOverrideLogicalContentHeight())
- return tableCellShouldHaveZeroInitialSize(*cb, scrollsOverflowY()) ? std::optional<LayoutUnit>() : std::nullopt;
+ return tableCellShouldHaveZeroInitialSize(*cb, scrollsOverflowY()) ? std::optional<LayoutUnit>(0) : std::nullopt;
availableHeight = cb->overrideLogicalContentHeight();
includeBorderPadding = true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
