Title: [98830] trunk/Tools
- Revision
- 98830
- Author
- [email protected]
- Date
- 2011-10-30 15:42:24 -0700 (Sun, 30 Oct 2011)
Log Message
new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691
Unreviewed.
This is a temporary hack until someone from the cr-win port
can take a look and determine which environment variable
lighttpd is missing.
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (98829 => 98830)
--- trunk/Tools/ChangeLog 2011-10-30 22:06:03 UTC (rev 98829)
+++ trunk/Tools/ChangeLog 2011-10-30 22:42:24 UTC (rev 98830)
@@ -3,6 +3,19 @@
new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691
+ Unreviewed.
+
+ This is a temporary hack until someone from the cr-win port
+ can take a look and determine which environment variable
+ lighttpd is missing.
+
+ * Scripts/webkitpy/layout_tests/port/chromium_win.py:
+
+2011-10-30 Eric Seidel <[email protected]>
+
+ new-run-webkit-tests is locale dependent
+ https://bugs.webkit.org/show_bug.cgi?id=68691
+
Unreviewed. I would have preferred to have this reviewed,
but relevant reviewers are asleep and bots are broken.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py (98829 => 98830)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py 2011-10-30 22:06:03 UTC (rev 98829)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py 2011-10-30 22:42:24 UTC (rev 98830)
@@ -123,6 +123,15 @@
def setup_environ_for_server(self, server_name=None):
env = chromium.ChromiumPort.setup_environ_for_server(self, server_name)
+
+ # FIXME: lighttpd depends on some environment variable we're not whitelisting.
+ # We should add the variable to an explicit whitelist in base.Port.
+ # FIXME: This is a temporary hack to get the cr-win bot online until
+ # someone from the cr-win port can take a look.
+ for key, value in os.environ.items():
+ if key not in env:
+ env[key] = value
+
# Put the cygwin directory first in the path to find cygwin1.dll.
env["PATH"] = "%s;%s" % (self.path_from_chromium_base("third_party", "cygwin", "bin"), env["PATH"])
# Configure the cygwin directory so that pywebsocket finds proper
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
