Diff
Modified: trunk/LayoutTests/ChangeLog (209513 => 209514)
--- trunk/LayoutTests/ChangeLog 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/LayoutTests/ChangeLog 2016-12-08 02:53:41 UTC (rev 209514)
@@ -1,3 +1,19 @@
+2016-12-07 Dean Jackson <[email protected]>
+
+ Remove runtime toggle for pointer-lock
+ https://bugs.webkit.org/show_bug.cgi?id=165577
+ <rdar://problems/29566996>
+
+ Reviewed by Jon Lee.
+
+ Remove any runtime calls to check if pointer-lock is enabled. It's
+ either compiled in or out.
+
+ * platform/mac/TestExpectations: Enable the pointer-lock tests that should work.
+ * pointer-lock/pointer-lock-api.html: Fix a bad DOM call.
+ * pointer-lock/pointerlock-interface-disabled-expected.txt: Removed.
+ * pointer-lock/pointerlock-interface-disabled.html: Removed.
+
2016-12-07 Dave Hyatt <[email protected]>
[CSS Parser] Unskip gradients tests
Modified: trunk/LayoutTests/platform/mac/TestExpectations (209513 => 209514)
--- trunk/LayoutTests/platform/mac/TestExpectations 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2016-12-08 02:53:41 UTC (rev 209514)
@@ -278,8 +278,16 @@
fast/events/platform-wheelevent-paging-y-in-scrolling-div.html
fast/events/platform-wheelevent-paging-y-in-scrolling-page.html
-# Pointer Lock is not implemented.
-pointer-lock/
+# Pointer Lock can only check some of the API at the moment.
+pointer-lock/bug90391-move-then-window-open-crash.html
+pointer-lock/lock-already-locked.html
+pointer-lock/lock-element-not-in-dom.html
+pointer-lock/locked-element-iframe-removed-from-dom.html
+pointer-lock/locked-element-removed-from-dom.html
+pointer-lock/mouse-event-delivery.html
+pointer-lock/pointerlockchange-event-on-lock-lost.html
+pointer-lock/pointerlockchange-pointerlockerror-events.html
+pointer-lock/pointerlockelement-null-when-pending.html
http/tests/pointer-lock/
webkit.org/b/82763 fast/forms/textarea-placeholder-set-attribute.html
Modified: trunk/LayoutTests/pointer-lock/lock-lost-on-esc-in-fullscreen.html (209513 => 209514)
--- trunk/LayoutTests/pointer-lock/lock-lost-on-esc-in-fullscreen.html 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/LayoutTests/pointer-lock/lock-lost-on-esc-in-fullscreen.html 2016-12-08 02:53:41 UTC (rev 209514)
@@ -1,4 +1,4 @@
-<!DOCTYPE HTML><!-- webkit-test-runner [ enablePointerLock=true ] -->
+<!DOCTYPE HTML>
<html>
<head>
<script src=""
Modified: trunk/LayoutTests/pointer-lock/pointer-lock-api.html (209513 => 209514)
--- trunk/LayoutTests/pointer-lock/pointer-lock-api.html 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/LayoutTests/pointer-lock/pointer-lock-api.html 2016-12-08 02:53:41 UTC (rev 209514)
@@ -11,7 +11,7 @@
shouldBeDefined("document.onpointerlockerror");
shouldBeDefined("document.exitPointerLock");
shouldEvaluateTo("document.pointerLockElement", null);
- element = document.createElement();
+ element = document.createElement("div");
shouldBeDefined("element.requestPointerLock");
</script>
<script src=""
Deleted: trunk/LayoutTests/pointer-lock/pointerlock-interface-disabled-expected.txt (209513 => 209514)
--- trunk/LayoutTests/pointer-lock/pointerlock-interface-disabled-expected.txt 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/LayoutTests/pointer-lock/pointerlock-interface-disabled-expected.txt 2016-12-08 02:53:41 UTC (rev 209514)
@@ -1,7 +0,0 @@
-
-PASS Document.prototype.exitPointerLock does not exist
-PASS Document.prototype.pointerLockElement does not exist
-PASS Document.prototype.onpointerlockchange does not exist
-PASS Document.prototype.onpointerlockerror does not exist
-PASS Element.prototype.requestPointerLock does not exist
-
Deleted: trunk/LayoutTests/pointer-lock/pointerlock-interface-disabled.html (209513 => 209514)
--- trunk/LayoutTests/pointer-lock/pointerlock-interface-disabled.html 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/LayoutTests/pointer-lock/pointerlock-interface-disabled.html 2016-12-08 02:53:41 UTC (rev 209514)
@@ -1,32 +0,0 @@
-<!DOCTYPE html><!-- webkit-test-runner [ enablePointerLock=false ] -->
-<head>
- <title>PointerLock interface tests.</title>
- <link rel="help" href=""
- <script src=""
- <script src=""
-</head>
-<body>
-<div id="log"></div>
-<script>
-test(function() {
- assert_false('exitPointerLock' in Document.prototype);
-},'Document.prototype.exitPointerLock does not exist');
-
-test(function() {
- assert_false('pointerLockElement' in Document.prototype);
-},'Document.prototype.pointerLockElement does not exist');
-
-test(function() {
- assert_false('onpointerlockchange' in Document.prototype);
-},'Document.prototype.onpointerlockchange does not exist');
-
-test(function() {
- assert_false('onpointerlockerror' in Document.prototype);
-},'Document.prototype.onpointerlockerror does not exist');
-
-test(function() {
- assert_false('requestPointerLock' in Element.prototype);
-},'Element.prototype.requestPointerLock does not exist');
-</script>
-</body>
-</html>
Modified: trunk/LayoutTests/pointer-lock/pointerlock-interface.html (209513 => 209514)
--- trunk/LayoutTests/pointer-lock/pointerlock-interface.html 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/LayoutTests/pointer-lock/pointerlock-interface.html 2016-12-08 02:53:41 UTC (rev 209514)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ enablePointerLock=true ] -->
+<!DOCTYPE html>
<head>
<title>PointerLock interface tests.</title>
<link rel="help" href=""
Modified: trunk/Source/WebCore/ChangeLog (209513 => 209514)
--- trunk/Source/WebCore/ChangeLog 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Source/WebCore/ChangeLog 2016-12-08 02:53:41 UTC (rev 209514)
@@ -1,3 +1,27 @@
+2016-12-07 Dean Jackson <[email protected]>
+
+ Remove runtime toggle for pointer-lock
+ https://bugs.webkit.org/show_bug.cgi?id=165577
+ <rdar://problems/29566996>
+
+ Reviewed by Jon Lee.
+
+ Remove any runtime calls to check if pointer-lock is enabled. It's
+ either compiled in or out.
+
+ Covered by existing tests.
+
+ * bindings/generic/RuntimeEnabledFeatures.h:
+ (WebCore::RuntimeEnabledFeatures::setPointerLockEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::pointerLockEnabled): Deleted.
+ * dom/Document.idl:
+ * dom/Element.idl:
+ * page/Page.h:
+ * page/PointerLockController.cpp:
+ (WebCore::PointerLockController::requestPointerLock):
+ (WebCore::PointerLockController::requestPointerUnlock):
+ (WebCore::PointerLockController::requestPointerUnlockAndForceCursorVisible):
+
2016-12-07 John Wilander <[email protected]>
Allow commas in Accept, Accept-Language, and Content-Language request headers for simple CORS
Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (209513 => 209514)
--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2016-12-08 02:53:41 UTC (rev 209514)
@@ -212,11 +212,6 @@
bool webGL2Enabled() const { return m_isWebGL2Enabled; }
#endif
-#if ENABLE(POINTER_LOCK)
- void setPointerLockEnabled(bool isEnabled) { m_isPointerLockEnabled = isEnabled; }
- bool pointerLockEnabled() const { return m_isPointerLockEnabled; }
-#endif
-
#if ENABLE(FETCH_API)
void setFetchAPIEnabled(bool isEnabled) { m_isFetchAPIEnabled = isEnabled; }
bool fetchAPIEnabled() const { return m_isFetchAPIEnabled; }
@@ -352,10 +347,6 @@
bool m_isWebGL2Enabled;
#endif
-#if ENABLE(POINTER_LOCK)
- bool m_isPointerLockEnabled;
-#endif
-
#if ENABLE(FETCH_API)
bool m_isFetchAPIEnabled { false };
#endif
Modified: trunk/Source/WebCore/dom/Document.idl (209513 => 209514)
--- trunk/Source/WebCore/dom/Document.idl 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Source/WebCore/dom/Document.idl 2016-12-08 02:53:41 UTC (rev 209514)
@@ -152,8 +152,8 @@
void webkitExitFullscreen();
#endif
- [Conditional=POINTER_LOCK, EnabledAtRuntime=PointerLock] void exitPointerLock();
- [Conditional=POINTER_LOCK, EnabledAtRuntime=PointerLock] readonly attribute Element? pointerLockElement;
+ [Conditional=POINTER_LOCK] void exitPointerLock();
+ [Conditional=POINTER_LOCK] readonly attribute Element? pointerLockElement;
[Conditional=CSS_REGIONS] DOMNamedFlowCollection webkitGetNamedFlows();
@@ -202,8 +202,8 @@
// Unique to Document
[LenientThis] attribute EventHandler onreadystatechange;
[NotEnumerable, Conditional=CSP_NEXT] attribute EventHandler onsecuritypolicyviolation;
- [NotEnumerable, Conditional=POINTER_LOCK, EnabledAtRuntime=PointerLock] attribute EventHandler onpointerlockchange;
- [NotEnumerable, Conditional=POINTER_LOCK, EnabledAtRuntime=PointerLock] attribute EventHandler onpointerlockerror;
+ [NotEnumerable, Conditional=POINTER_LOCK] attribute EventHandler onpointerlockchange;
+ [NotEnumerable, Conditional=POINTER_LOCK] attribute EventHandler onpointerlockerror;
};
Document implements ParentNode;
Modified: trunk/Source/WebCore/dom/Element.idl (209513 => 209514)
--- trunk/Source/WebCore/dom/Element.idl 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Source/WebCore/dom/Element.idl 2016-12-08 02:53:41 UTC (rev 209514)
@@ -128,7 +128,7 @@
[CEReactions, MayThrowException] void insertAdjacentHTML(DOMString where, DOMString html);
[MayThrowException] void insertAdjacentText(DOMString where, DOMString text);
- [Conditional=POINTER_LOCK, EnabledAtRuntime=PointerLock] void requestPointerLock();
+ [Conditional=POINTER_LOCK] void requestPointerLock();
// CSS Regions API
[Conditional=CSS_REGIONS] readonly attribute DOMString webkitRegionOverset;
Modified: trunk/Source/WebCore/page/Page.h (209513 => 209514)
--- trunk/Source/WebCore/page/Page.h 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Source/WebCore/page/Page.h 2016-12-08 02:53:41 UTC (rev 209514)
@@ -108,7 +108,9 @@
class PluginData;
class PluginInfoProvider;
class PluginViewBase;
+#if ENABLE(POINTER_LOCK)
class PointerLockController;
+#endif
class ProgressTracker;
class ProgressTrackerClient;
class Range;
Modified: trunk/Source/WebCore/page/PointerLockController.cpp (209513 => 209514)
--- trunk/Source/WebCore/page/PointerLockController.cpp 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Source/WebCore/page/PointerLockController.cpp 2016-12-08 02:53:41 UTC (rev 209514)
@@ -50,9 +50,6 @@
void PointerLockController::requestPointerLock(Element* target)
{
- if (!RuntimeEnabledFeatures::sharedFeatures().pointerLockEnabled())
- return;
-
if (!target || !target->inDocument() || m_documentOfRemovedElementWhileWaitingForUnlock) {
enqueueEvent(eventNames().pointerlockerrorEvent, target);
return;
@@ -93,15 +90,12 @@
if (!m_element)
return;
- if (!RuntimeEnabledFeatures::sharedFeatures().pointerLockEnabled())
- return;
-
m_page.chrome().client().requestPointerUnlock();
}
void PointerLockController::requestPointerUnlockAndForceCursorVisible()
{
- if (!m_element || !RuntimeEnabledFeatures::sharedFeatures().pointerLockEnabled())
+ if (!m_element)
return;
m_page.chrome().client().requestPointerUnlock();
Modified: trunk/Source/WebKit/mac/ChangeLog (209513 => 209514)
--- trunk/Source/WebKit/mac/ChangeLog 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-12-08 02:53:41 UTC (rev 209514)
@@ -1,3 +1,22 @@
+2016-12-07 Dean Jackson <[email protected]>
+
+ Remove runtime toggle for pointer-lock
+ https://bugs.webkit.org/show_bug.cgi?id=165577
+ <rdar://problems/29566996>
+
+ Reviewed by Jon Lee.
+
+ Remove any runtime calls to check if pointer-lock is enabled. It's
+ either compiled in or out.
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (-[WebPreferences pointerLockEnabled]): Deleted.
+ (-[WebPreferences setPointerLockEnabled:]): Deleted.
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
2016-12-06 Alexey Proskuryakov <[email protected]>
Correct SDKROOT values in xcconfig files
Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (209513 => 209514)
--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2016-12-08 02:53:41 UTC (rev 209514)
@@ -172,7 +172,6 @@
#define WebKitCSSGridLayoutEnabledPreferenceKey @"WebKitCSSGridLayoutEnabled"
#define WebKitVisualViewportEnabledPreferenceKey @"WebKitVisualViewportEnabled"
#define WebKitModernMediaControlsEnabledPreferenceKey @"WebKitModernMediaControlsEnabled"
-#define WebKitPointerLockEnabledPreferenceKey @"WebKitPointerLockEnabled"
#define WebKitSubtleCryptoEnabledPreferenceKey @"WebKitSubtleCryptoEnabled"
#if !TARGET_OS_IPHONE
Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (209513 => 209514)
--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2016-12-08 02:53:41 UTC (rev 209514)
@@ -2380,16 +2380,6 @@
[self _setBoolValue:flag forKey:WebKitAllowsPictureInPictureMediaPlaybackPreferenceKey];
}
-- (BOOL)pointerLockEnabled
-{
- return [self _boolValueForKey:WebKitPointerLockEnabledPreferenceKey];
-}
-
-- (void)setPointerLockEnabled:(BOOL)flag
-{
- [self _setBoolValue:flag forKey:WebKitPointerLockEnabledPreferenceKey];
-}
-
- (BOOL)mockScrollbarsEnabled
{
return [self _boolValueForKey:WebKitMockScrollbarsEnabledPreferenceKey];
Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (209513 => 209514)
--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-12-08 02:53:41 UTC (rev 209514)
@@ -284,9 +284,6 @@
- (void)setAllowsPictureInPictureMediaPlayback:(BOOL)flag;
- (BOOL)allowsPictureInPictureMediaPlayback;
-- (void)setPointerLockEnabled:(BOOL)flag;
-- (BOOL)pointerLockEnabled;
-
- (NSString *)pictographFontFamily;
- (void)setPictographFontFamily:(NSString *)family;
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (209513 => 209514)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-12-08 02:53:41 UTC (rev 209514)
@@ -2842,10 +2842,6 @@
RuntimeEnabledFeatures::sharedFeatures().setCustomElementsEnabled([preferences customElementsEnabled]);
-#if ENABLE(POINTER_LOCK)
- RuntimeEnabledFeatures::sharedFeatures().setPointerLockEnabled([preferences pointerLockEnabled]);
-#endif
-
#if ENABLE(FETCH_API)
RuntimeEnabledFeatures::sharedFeatures().setFetchAPIEnabled([preferences fetchAPIEnabled]);
#endif
Modified: trunk/Source/WebKit2/ChangeLog (209513 => 209514)
--- trunk/Source/WebKit2/ChangeLog 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Source/WebKit2/ChangeLog 2016-12-08 02:53:41 UTC (rev 209514)
@@ -1,3 +1,22 @@
+2016-12-07 Dean Jackson <[email protected]>
+
+ Remove runtime toggle for pointer-lock
+ https://bugs.webkit.org/show_bug.cgi?id=165577
+ <rdar://problems/29566996>
+
+ Reviewed by Jon Lee.
+
+ Remove any runtime calls to check if pointer-lock is enabled. It's
+ either compiled in or out.
+
+ * Shared/WebPreferencesDefinitions.h:
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetPointerLockEnabled): Deleted.
+ (WKPreferencesGetPointerLockEnabled): Deleted.
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+
2016-12-07 Eric Carlson <[email protected]>
[MediaStream][Mac] Revoke sandbox extensions when capture ends
Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (209513 => 209514)
--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-12-08 02:53:41 UTC (rev 209514)
@@ -320,7 +320,6 @@
macro(SubtleCryptoEnabled, subtleCryptoEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "SubtleCrypto", "Enable SubtleCrypto support") \
macro(WebGL2Enabled, webGL2Enabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "WebGL 2.0", "WebGL 2 prototype") \
macro(ES6ModulesEnabled, es6ModulesEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "ES6 Modules", "Enable ES6 Modules support") \
- macro(PointerLockEnabled, pointerLockEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "PointerLock", "Pointer Lock API support") \
\
#if PLATFORM(COCOA)
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (209513 => 209514)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-12-08 02:53:41 UTC (rev 209514)
@@ -832,16 +832,6 @@
return toImpl(preferencesRef)->modernMediaControlsEnabled();
}
-void WKPreferencesSetPointerLockEnabled(WKPreferencesRef preferencesRef, bool flag)
-{
- toImpl(preferencesRef)->setPointerLockEnabled(flag);
-}
-
-bool WKPreferencesGetPointerLockEnabled(WKPreferencesRef preferencesRef)
-{
- return toImpl(preferencesRef)->pointerLockEnabled();
-}
-
void WKPreferencesSetShowsToolTipOverTruncatedText(WKPreferencesRef preferencesRef, bool flag)
{
toImpl(preferencesRef)->setShowsToolTipOverTruncatedText(flag);
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h (209513 => 209514)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-12-08 02:53:41 UTC (rev 209514)
@@ -209,10 +209,6 @@
WK_EXPORT bool WKPreferencesGetModernMediaControlsEnabled(WKPreferencesRef preferencesRef);
// Defaults to false.
-WK_EXPORT void WKPreferencesSetPointerLockEnabled(WKPreferencesRef preferencesRef, bool flag);
-WK_EXPORT bool WKPreferencesGetPointerLockEnabled(WKPreferencesRef preferencesRef);
-
-// Defaults to false.
WK_EXPORT void WKPreferencesSetShowsToolTipOverTruncatedText(WKPreferencesRef preferencesRef, bool flag);
WK_EXPORT bool WKPreferencesGetShowsToolTipOverTruncatedText(WKPreferencesRef preferencesRef);
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (209513 => 209514)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-12-08 02:53:41 UTC (rev 209514)
@@ -3185,10 +3185,6 @@
RuntimeEnabledFeatures::sharedFeatures().setWebGL2Enabled(store.getBoolValueForKey(WebPreferencesKey::webGL2EnabledKey()));
#endif
-#if ENABLE(POINTER_LOCK)
- RuntimeEnabledFeatures::sharedFeatures().setPointerLockEnabled(store.getBoolValueForKey(WebPreferencesKey::pointerLockEnabledKey()));
-#endif
-
settings.setSpringTimingFunctionEnabled(store.getBoolValueForKey(WebPreferencesKey::springTimingFunctionEnabledKey()));
settings.setVisualViewportEnabled(store.getBoolValueForKey(WebPreferencesKey::visualViewportEnabledKey()));
Modified: trunk/Tools/ChangeLog (209513 => 209514)
--- trunk/Tools/ChangeLog 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Tools/ChangeLog 2016-12-08 02:53:41 UTC (rev 209514)
@@ -1,3 +1,19 @@
+2016-12-07 Dean Jackson <[email protected]>
+
+ Remove runtime toggle for pointer-lock
+ https://bugs.webkit.org/show_bug.cgi?id=165577
+ <rdar://problems/29566996>
+
+ Reviewed by Jon Lee.
+
+ Remove any runtime calls to check if pointer-lock is enabled. It's
+ either compiled in or out.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (resetWebPreferencesToConsistentValues):
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::resetPreferencesToConsistentValues):
+
2016-12-07 Eric Carlson <[email protected]>
[MediaStream][Mac] Revoke sandbox extensions when capture ends
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (209513 => 209514)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-12-08 02:53:41 UTC (rev 209514)
@@ -1000,7 +1000,6 @@
preferences.intersectionObserverEnabled = options.enableIntersectionObserver;
preferences.modernMediaControlsEnabled = options.enableModernMediaControls;
- preferences.pointerLockEnabled = options.enablePointerLock;
[preferences setSubtleCryptoEnabled:YES];
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (209513 => 209514)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2016-12-08 02:53:41 UTC (rev 209514)
@@ -665,7 +665,6 @@
WKPreferencesSetNeedsSiteSpecificQuirks(preferences, options.needsSiteSpecificQuirks);
WKPreferencesSetIntersectionObserverEnabled(preferences, options.enableIntersectionObserver);
WKPreferencesSetModernMediaControlsEnabled(preferences, options.enableModernMediaControls);
- WKPreferencesSetPointerLockEnabled(preferences, options.enablePointerLock);
static WKStringRef defaultTextEncoding = WKStringCreateWithUTF8CString("ISO-8859-1");
WKPreferencesSetDefaultTextEncodingName(preferences, defaultTextEncoding);
Modified: trunk/Websites/webkit.org/ChangeLog (209513 => 209514)
--- trunk/Websites/webkit.org/ChangeLog 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Websites/webkit.org/ChangeLog 2016-12-08 02:53:41 UTC (rev 209514)
@@ -1,3 +1,15 @@
+2016-12-07 Dean Jackson <[email protected]>
+
+ Remove runtime toggle for pointer-lock
+ https://bugs.webkit.org/show_bug.cgi?id=165577
+ <rdar://problems/29566996>
+
+ Reviewed by Jon Lee.
+
+ No need to have pointer-lock tested.
+
+ * experimental-features.html: Also sort the list alphabetically.
+
2016-12-05 Dean Jackson <[email protected]>
pointer lock needs to be feature detectable
Modified: trunk/Websites/webkit.org/experimental-features.html (209513 => 209514)
--- trunk/Websites/webkit.org/experimental-features.html 2016-12-08 02:51:41 UTC (rev 209513)
+++ trunk/Websites/webkit.org/experimental-features.html 2016-12-08 02:53:41 UTC (rev 209514)
@@ -99,10 +99,6 @@
return window.InputEvent;
}
-function testPointerLock() {
- return "exitPointerLock" in Document.prototype;
-}
-
function testES6Modules() {
return window.es6modules;
}
@@ -124,14 +120,13 @@
<p>These tests do not exercise actual functionality. They are just the most basic check to see if the feature claims to be available.</p>
<div class="test" id="CSSGrid"><p>CSS Grid</p></div>
+ <div class="test" id="SpringAnimation"><p>CSS Spring Animations</p></div>
+ <div class="test" id="ES6Modules"><p>ES6 Modules in HTML</p></div>
<div class="test" id="Gamepad"><p>Gamepad API</p></div>
+ <div class="test" id="FormValidation"><p>HTML Form Validation</p></div>
+ <div class="test" id="InputEvents"><p>HTML Input Events</p></div>
<div class="test" id="VariationFonts"><p>Variation Fonts</p></div>
- <div class="test" id="PointerLock"><p>Mouse Pointer Lock</p></div>
<div class="test" id="WebGL2"><p>WebGL 2.0</p></div>
- <div class="test" id="FormValidation"><p>HTML Form Validation</p></div>
- <div class="test" id="InputEvents"><p>HTML Input Events</p></div>
- <div class="test" id="SpringAnimation"><p>CSS Spring Animations</p></div>
- <div class="test" id="ES6Modules"><p>ES6 Modules in HTML</p></div>
</div>
</body>
</html>
