Title: [209527] trunk/LayoutTests
- Revision
- 209527
- Author
- [email protected]
- Date
- 2016-12-07 22:47:53 -0800 (Wed, 07 Dec 2016)
Log Message
[CSS Parser] Remove font test that tests something nobody supports
https://bugs.webkit.org/show_bug.cgi?id=165596
Reviewed by Zalan Bujtas.
Remove this test that thinks "default" should be a special keyword in fonts. No
other browser treat this as special. Our old parser did, but it's just from some
reading of ancient CSS2 specs and not for any real-world reason.
* TestExpectations:
* fast/css/font-family-parse-keyword.html: Removed.
* fast/css/font-family-parse-keyword-expected.html: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (209526 => 209527)
--- trunk/LayoutTests/ChangeLog 2016-12-08 06:29:46 UTC (rev 209526)
+++ trunk/LayoutTests/ChangeLog 2016-12-08 06:47:53 UTC (rev 209527)
@@ -1,5 +1,20 @@
2016-12-07 Dave Hyatt <[email protected]>
+ [CSS Parser] Remove font test that tests something nobody supports
+ https://bugs.webkit.org/show_bug.cgi?id=165596
+
+ Reviewed by Zalan Bujtas.
+
+ Remove this test that thinks "default" should be a special keyword in fonts. No
+ other browser treat this as special. Our old parser did, but it's just from some
+ reading of ancient CSS2 specs and not for any real-world reason.
+
+ * TestExpectations:
+ * fast/css/font-family-parse-keyword.html: Removed.
+ * fast/css/font-family-parse-keyword-expected.html: Removed.
+
+2016-12-07 Dave Hyatt <[email protected]>
+
REGRESSION: font shorthand parsing is broken
https://bugs.webkit.org/show_bug.cgi?id=165594
Modified: trunk/LayoutTests/TestExpectations (209526 => 209527)
--- trunk/LayoutTests/TestExpectations 2016-12-08 06:29:46 UTC (rev 209526)
+++ trunk/LayoutTests/TestExpectations 2016-12-08 06:47:53 UTC (rev 209527)
@@ -998,7 +998,6 @@
# The following layout tests need to be changed when the new CSS Parser is turned on, since they
# incorrectly indicate failures on valid syntax.
webkit.org/b/165195 fast/css/attr-parsing.html [ Pass Failure ]
-webkit.org/b/165195 fast/css/font-family-parse-keyword.html [ Skip ]
webkit.org/b/165195 fast/css/font-property-priority.html [ Pass Failure ]
webkit.org/b/165195 fast/css/font_property_normal.html [ Pass Failure ]
webkit.org/b/165195 fast/css/image-set-unprefixed.html [ Pass Failure ]
Deleted: trunk/LayoutTests/fast/css/font-family-parse-keyword-expected.html (209526 => 209527)
--- trunk/LayoutTests/fast/css/font-family-parse-keyword-expected.html 2016-12-08 06:29:46 UTC (rev 209526)
+++ trunk/LayoutTests/fast/css/font-family-parse-keyword-expected.html 2016-12-08 06:47:53 UTC (rev 209527)
@@ -1,46 +0,0 @@
-<!DOCTYPE html>
-<style>
-@font-face {
- font-family: webkit-ahem;
- src: url(../../resources/Ahem.ttf) format(truetype);
-}
-</style>
-<body>
- <p>
- https://bugs.webkit.org/b/107231 - CSSParser::parseFontFamily should allow
- the keyword "default" as part of a font name
- </p>
- <p>
- The next 4 lines should use the default font (same as this line):<br>
- Test 1<br>
- Test 2<br>
- Test 3<br>
- Test 4
- </p>
- <p>
- The next 6 lines should use the font Arial:<br>
- <span style="font-family: arial">
- Test 1<br>
- Test 2<br>
- Test 3<br>
- Test 4<br>
- Test 5<br>
- Test 6
- </span>
- </p>
- <p>
- The next 9 lines should use the font Ahem (black boxes):<br>
- <span style="font-family: webkit-ahem">
- Test 1<br>
- Test 2<br>
- Test 3<br>
- Test 4<br>
- Test 5<br>
- Test 6<br>
- Test 7<br>
- Test 8<br>
- Test 9
- </span>
- </p>
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/css/font-family-parse-keyword.html (209526 => 209527)
--- trunk/LayoutTests/fast/css/font-family-parse-keyword.html 2016-12-08 06:29:46 UTC (rev 209526)
+++ trunk/LayoutTests/fast/css/font-family-parse-keyword.html 2016-12-08 06:47:53 UTC (rev 209527)
@@ -1,50 +0,0 @@
-<!DOCTYPE html>
-<style>
-@font-face {
- font-family: webkit-ahem;
- src: url(../../resources/Ahem.ttf) format(truetype);
-}
-@font-face {
- font-family: default foo;
- src: url(../../resources/Ahem.ttf) format(truetype);
-}
-@font-face {
- font-family: bar default;
- src: url(../../resources/Ahem.ttf) format(truetype);
-}
-</style>
-<body>
- <p>
- https://bugs.webkit.org/b/107231 - CSSParser::parseFontFamily should allow
- the keyword "default" as part of a font name
- </p>
- <p>
- The next 4 lines should use the default font (same as this line):<br>
- Test 1<br>
- <span style="font-family: default">Test 2</span><br>
- <span style="font-family: default, invalid">Test 3</span><br>
- <span style="font-family: invalid, default">Test 4</span>
- </p>
- <p>
- The next 6 lines should use the font Arial:<br>
- <span style="font-family: arial">Test 1</span><br>
- <span style="font-family: default, arial">Test 2</span><br>
- <span style="font-family: default foobar, arial">Test 3</span><br>
- <span style="font-family: arial, default">Test 4</span><br>
- <span style="font-family: arial, default foobar">Test 5</span><br>
- <span style="font-family: invalid, default, arial">Test 6</span>
- </p>
- <p>
- The next 9 lines should use the font Ahem (black boxes):<br>
- <span style="font-family: webkit-ahem">Test 1</span><br>
- <span style="font-family: default foo">Test 2</span><br>
- <span style="font-family: default foo, invalid">Test 3</span><br>
- <span style="font-family: invalid, default foo">Test 4</span><br>
- <span style="font-family: invalid, default foo, foobar">Test 5</span><br>
- <span style="font-family: bar default">Test 6</span><br>
- <span style="font-family: bar default, invalid">Test 7</span><br>
- <span style="font-family: invalid, bar default">Test 8</span><br>
- <span style="font-family: invalid, bar default, foobar">Test 9</span>
- </p>
-</body>
-</html>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
