Title: [209529] trunk/LayoutTests
- Revision
- 209529
- Author
- [email protected]
- Date
- 2016-12-08 00:07:42 -0800 (Thu, 08 Dec 2016)
Log Message
REGRESSION (r209490): [ios-simulator] LayoutTest fast/shadow-dom/media-shadow-manipulation.html is failing
https://bugs.webkit.org/show_bug.cgi?id=165590
Unreviewed. Revert r209490 on this test and make the check conditional
since iOS and Mac implements video element differently.
In any case, these tests aren't testing anything useful after r209486.
We should consider removing them or make them use internals.shadowRoot instead in a near term.
* fast/shadow-dom/media-shadow-manipulation-expected.txt:
* fast/shadow-dom/media-shadow-manipulation.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (209528 => 209529)
--- trunk/LayoutTests/ChangeLog 2016-12-08 07:20:37 UTC (rev 209528)
+++ trunk/LayoutTests/ChangeLog 2016-12-08 08:07:42 UTC (rev 209529)
@@ -1,3 +1,17 @@
+2016-12-08 Ryosuke Niwa <[email protected]>
+
+ REGRESSION (r209490): [ios-simulator] LayoutTest fast/shadow-dom/media-shadow-manipulation.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=165590
+
+ Unreviewed. Revert r209490 on this test and make the check conditional
+ since iOS and Mac implements video element differently.
+
+ In any case, these tests aren't testing anything useful after r209486.
+ We should consider removing them or make them use internals.shadowRoot instead in a near term.
+
+ * fast/shadow-dom/media-shadow-manipulation-expected.txt:
+ * fast/shadow-dom/media-shadow-manipulation.html:
+
2016-12-07 Dave Hyatt <[email protected]>
[CSS Parser] Remove font test that tests something nobody supports
Modified: trunk/LayoutTests/fast/shadow-dom/media-shadow-manipulation-expected.txt (209528 => 209529)
--- trunk/LayoutTests/fast/shadow-dom/media-shadow-manipulation-expected.txt 2016-12-08 07:20:37 UTC (rev 209528)
+++ trunk/LayoutTests/fast/shadow-dom/media-shadow-manipulation-expected.txt 2016-12-08 08:07:42 UTC (rev 209529)
@@ -1,4 +1,4 @@
-PASS bounds = video_element.getBoundingClientRect(); document.caretRangeFromPoint(bounds.left + 10, bounds.bottom - 10) is null
+PASS Passes if we did not debug assert.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/shadow-dom/media-shadow-manipulation.html (209528 => 209529)
--- trunk/LayoutTests/fast/shadow-dom/media-shadow-manipulation.html 2016-12-08 07:20:37 UTC (rev 209528)
+++ trunk/LayoutTests/fast/shadow-dom/media-shadow-manipulation.html 2016-12-08 08:07:42 UTC (rev 209529)
@@ -6,7 +6,13 @@
window.jsTestIsAsync = true;
function runTest() {
- shouldBe('bounds = video_element.getBoundingClientRect(); document.caretRangeFromPoint(bounds.left + 10, bounds.bottom - 10)', 'null');
+ var bounds = video_element.getBoundingClientRect();
+ var range = document.caretRangeFromPoint(bounds.left + 10, bounds.bottom - 10);
+ shadow_tree_container = range ? range.commonAncestorContainer : null;
+ if (shadow_tree_container)
+ shadow_tree_container.prepend("foo");
+ video_element.disabled = true;
+ testPassed("Passes if we did not debug assert.");
finishJSTest();
}
</script>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
